From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by dpdk.org (Postfix) with ESMTP id 141A1199B5 for ; Mon, 8 Jan 2018 18:03:41 +0100 (CET) Received: by mail-pg0-f66.google.com with SMTP id i196so5929459pgd.0 for ; Mon, 08 Jan 2018 09:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5rPilGh4NBO8UmnA+PsCv/fS/X7C28G+U35agQ0p3Bk=; b=OTAWCtaM5J1Euz38P6s4/h1+fW5/B2nBk276z8DvkAvNK4MI44fe74Y0o34+VtOQgp 9zsRVrCRRjYuH8KUHtYEpsX8D6CqdN+WxjaoSk+skJNZfCd4DJtFjgFx6oDAzcvdYujC YX1BP6DnmyqXpmn80ZeqtEOJw9kBfgroMz2GzrUtjN0hee4t1Jsrj30OWRzj7lXomZSU j7p2XqHyxDO42kDjniPWXFEQo0EbmsC7Gya4RIULuTni9erTtNWY4oyf7K5wMX/SSpiI CTz6qMqy5Ybd5fDMdlERb1h/ZTCUabc/z0tPj3W2NRi42IQdBqMZ04b3305o6DHFTUPJ MxtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5rPilGh4NBO8UmnA+PsCv/fS/X7C28G+U35agQ0p3Bk=; b=lyOzAKSd0lznzCBaNcddLhyFm1vPapVS7DF/Z0ap885PTydrWH+Fdlg+es9qDQ0ydQ 8Iow0f2I4iOJF6IG17a/5CU41awWReEnYd2yg5mKDH05oz7XTHVfPnQn33qsoLGw1DBP dBkzrfmNaPh5ou8tfUKe70k6DDChxFp7ejrppfK/Nppu836RT3mN8K0mI9lODQjuEQH0 XPTv9s6RcnoAMVprFqqbHNQ35wg6LzIGlsWuktCzAinfSwciMuApU1SSj/O4WuDG/YJh VX1Lkah2tqGY03wT6P5l1tAJAcJYWxpKQWvOKA/yKbRafVTo2Wcg9rjIxC+WDtDyzQCd 2Vtg== X-Gm-Message-State: AKGB3mLMdxLF9h02qDzSKy7bM6ENyuIsHiGxq4sVntcWRPpRRTyRG4FV d0mXtdytpnParlvCfXqIRPdnGQSI1bY= X-Google-Smtp-Source: ACJfBosUFcN04bhRJVUQagP7nFWwJE2x6iohNM5Zk3qFKXYfmfn/waHk+fE/yVKd/foxT0wBucwDXw== X-Received: by 10.99.45.68 with SMTP id t65mr10031569pgt.216.1515431020997; Mon, 08 Jan 2018 09:03:40 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id s73sm29471572pfi.167.2018.01.08.09.03.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2018 09:03:40 -0800 (PST) Date: Mon, 8 Jan 2018 09:03:38 -0800 From: Stephen Hemminger To: Tiwei Bie Cc: dev@dpdk.org Message-ID: <20180108090338.796c7796@xeon-e3> In-Reply-To: <20180106031008.pz65udjogohdu3fz@debian-xvivbkq.sh.intel.com> References: <20180106010656.9167-1-stephen@networkplumber.org> <20180106010656.9167-4-stephen@networkplumber.org> <20180106031008.pz65udjogohdu3fz@debian-xvivbkq.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 03/15] virtio: use eth_linkstatus_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 17:03:42 -0000 On Sat, 6 Jan 2018 11:10:08 +0800 Tiwei Bie wrote: > Hi Stephen, > > On Fri, Jan 05, 2018 at 05:06:44PM -0800, Stephen Hemminger wrote: > > Use the new comon code in ethdev to handle link status update. > > Typo: comon -> common > > > > > Signed-off-by: Stephen Hemminger > [...] > > static void > > virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > > { > > @@ -1913,8 +1872,13 @@ static void > > virtio_dev_stop(struct rte_eth_dev *dev) > > { > > struct virtio_hw *hw = dev->data->dev_private; > > - struct rte_eth_link link; > > struct rte_intr_conf *intr_conf = &dev->data->dev_conf.intr_conf; > > + struct rte_eth_link link = { > > + .link_speed = SPEED_10G, > > SPEED_10G has been removed on dpdk-next-virtio: Patch was intended for current release so not looking at -next