From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 3F78B7D30 for ; Mon, 8 Jan 2018 12:20:00 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2018 03:19:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,330,1511856000"; d="scan'208";a="17546604" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by FMSMGA003.fm.intel.com with ESMTP; 08 Jan 2018 03:19:58 -0800 Received: from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com [10.237.217.45]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id w08BJvQw016754; Mon, 8 Jan 2018 11:19:57 GMT Received: from sivswdev01.ir.intel.com (localhost [127.0.0.1]) by sivswdev01.ir.intel.com with ESMTP id w08BJv1E007218; Mon, 8 Jan 2018 11:19:57 GMT Received: (from lma25@localhost) by sivswdev01.ir.intel.com with LOCAL id w08BJvhV007214; Mon, 8 Jan 2018 11:19:57 GMT Date: Mon, 8 Jan 2018 11:19:57 +0000 From: "Liang, Ma" To: Jerin Jacob Cc: Sean Harte , dev@dpdk.org, harry.van.haaren@intel.com, Bruce Richardson , deepak.k.jain@intel.com, john.geary@intel.com, "Mccarthy, Peter" Message-ID: <20180108111957.GA16365@sivswdev01.ir.intel.com> References: <1513941830-186503-1-git-send-email-liang.j.ma@intel.com> <1513941830-186503-2-git-send-email-liang.j.ma@intel.com> <20180108064644.GB19071@jerin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180108064644.GB19071@jerin> User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 11:20:01 -0000 On 08 Jan 12:16, Jerin Jacob wrote: > -----Original Message----- > > Date: Fri, 22 Dec 2017 16:02:42 +0000 > > From: Sean Harte > > To: Liang Ma > > Cc: jerin.jacob@caviumnetworks.com, dev@dpdk.org, > > harry.van.haaren@intel.com, Bruce Richardson , > > deepak.k.jain@intel.com, john.geary@intel.com, "Mccarthy, Peter" > > > > Subject: Re: [PATCH v4 1/8] event/opdl: add the opdl ring infrastructure > > library > > > > On 22 December 2017 at 11:23, Liang Ma wrote: > > > > > > OPDL ring is the core infrastructure of OPDL PMD. OPDL ring library > > > provide the core data structure and core helper function set. The Ring > > > implements a single ring multi-port/stage pipelined packet distribution > > > mechanism. This mechanism has the following characteristics: > > > > > > • No multiple queue cost, therefore, latency is significant reduced. > > > • Fixed dependencies between queue/ports is more suitable for complex. > > > fixed pipelines of stateless packet processing (static pipeline). > > > • Has decentralized distribution (no scheduling core). > > > • Packets remain in order (no reorder core(s)). > > > * Update build system to enable compilation. > > > > > > Signed-off-by: Liang Ma > > > Signed-off-by: Peter Mccarthy > > > --- > > > config/common_base | 6 + > > > drivers/event/Makefile | 1 + > > > drivers/event/opdl/Makefile | 62 + > > > drivers/event/opdl/opdl_log.h | 59 + > > > drivers/event/opdl/opdl_ring.c | 1252 +++++++++++++++++++++ > > > drivers/event/opdl/opdl_ring.h | 628 +++++++++++ > > > drivers/event/opdl/rte_pmd_evdev_opdl_version.map | 3 + > > > mk/rte.app.mk | 1 + > > > mk/toolchain/gcc/rte.toolchain-compat.mk | 6 + > > > mk/toolchain/icc/rte.toolchain-compat.mk | 6 + > > > 10 files changed, 2024 insertions(+) > > > create mode 100644 drivers/event/opdl/Makefile > > > create mode 100644 drivers/event/opdl/opdl_log.h > > > create mode 100644 drivers/event/opdl/opdl_ring.c > > > create mode 100644 drivers/event/opdl/opdl_ring.h > > > create mode 100644 drivers/event/opdl/rte_pmd_evdev_opdl_version.map > > > > [...] > > > > Reviewed-by: Seán Harte > > I think, the series is not addressed all the v3 comments. I think, the > missing ones are > > 1) Use dynamic logging dynamic logging is added in second patch, the first one is not the entry of the PMD. Please ref to the opdl_evdev.c opdl_log.h > 2) Split the patches based on eventdev ops: > example: > See the example from latest dpaa eventdev driver: > http://dpdk.org/dev/patchwork/project/dpdk/list/?submitter=Sunil > 3) Fix check-patch and check-git-log.sh errors. > > Wrong headline format: > doc:update 18.02 release notes > Wrong headline prefix: > eventdev/opdl: opdl eventdev pmd unit test function > event/*: apply the three new capability flags for > sw/dppa2/octeontx > Wrong headline lowercase: > event/opdl: add the opdl pmd main body and helper function > eventdev/opdl: opdl eventdev pmd unit test function > event/*: apply the three new capability flags for > sw/dppa2/octeontx > maintainers: add the opdl pmd maintainer information > doc: add eventdev opdl pmd docuement > Headline too long: > event/*: apply the three new capability flags for > sw/dppa2/octeontx > > ### event/opdl: add the opdl ring infrastructure library > > WARNING:LONG_LINE: line over 80 characters > #451: FILE: drivers/event/opdl/opdl_ring.c:260: > + PMD_DRV_LOG(ERR, "%u entries is more than max (%u)", n, > s->num_slots); > > WARNING:LONG_LINE: line over 80 characters > #1202: FILE: drivers/event/opdl/opdl_ring.c:1011: > + ev_orig = (struct rte_event *)get_slot(t, > s->shadow_head+i); > > WARNING:LONG_LINE: line over 80 characters > #1203: FILE: drivers/event/opdl/opdl_ring.c:1012: > + if ((ev_orig->flow_id%s->nb_instance) == > s->instance_id) { > > WARNING:LONG_LINE: line over 80 characters > #1206: FILE: drivers/event/opdl/opdl_ring.c:1015: > + if > ((ev_orig->event&OPDL_EVENT_MASK) != ev_temp) { > > total: 0 errors, 4 warnings, 2049 lines checked > > ### event/opdl: add the opdl pmd main body and helper function > > WARNING:LONG_LINE: line over 80 characters > #1489: FILE: drivers/event/opdl/opdl_evdev_init.c:301: > + opdl_ring_cas_slot(p->enq_stage_inst, &ev[i], i, > p->atomic_claim); > > WARNING:LONG_LINE: line over 80 characters > #2027: FILE: drivers/event/opdl/opdl_evdev_init.c:839: > + > opdl_pmd_dev_id(port->opdl), > > WARNING:LONG_LINE: line over 80 characters > #2056: FILE: drivers/event/opdl/opdl_evdev_init.c:868: > + > opdl_pmd_dev_id(port->opdl), > > total: 0 errors, 3 warnings, 2309 lines checked > > ### eventdev/opdl: opdl eventdev pmd unit test function > > WARNING:LONG_LINE: line over 80 characters > #247: FILE: drivers/event/opdl/opdl_test.c:189: > + PMD_DRV_LOG(ERR, "%d: error creating qid %d\n ", > __LINE__, i); > > WARNING:LONG_LINE: line over 80 characters > #314: FILE: drivers/event/opdl/opdl_test.c:256: > + PMD_DRV_LOG(ERR, "%d: error mapping lb qid\n", > __LINE__); > > WARNING:LONG_LINE: line over 80 characters > #451: FILE: drivers/event/opdl/opdl_test.c:393: > + PMD_DRV_LOG(ERR, "%d: error mapping lb qid\n", > __LINE__); > > WARNING:LONG_LINE: line over 80 characters > #505: FILE: drivers/event/opdl/opdl_test.c:447: > + PMD_DRV_LOG(ERR, "%d: deq none zero > !\n", __LINE__); > > total: 0 errors, 4 warnings, 1102 lines checked > >