From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 3E2161B1AB for ; Mon, 8 Jan 2018 12:35:45 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id f140so13578639wmd.2 for ; Mon, 08 Jan 2018 03:35:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wc/+KzZ4bsXDa1+7QNiRz2dCKuS0B875Wsmy7qN7NvE=; b=OmIExhUP9BSCu4pSnEwErZN47A2mxwQrCAa+T4ZzAfDoF3Q6HuRmZ66BOZ7VgDJU+n VzNlMW/ODfKIpuF7lWOmzNnju/ZE+tdjrR1Y610DgZV08VWxqN1rrzuOrMv1Xbawl/SB LGl0WyEZvqvf0XhUptGy8wDomsK54Klb3m6emKmgFOCh4O+LqXW6BMYHHxjeDSrvuprY JrRn3bgZCTIRkRhrig9SjuypFhe/34JaFHf0Cl0tuHJc/+r1mZrnIfxrWreNDkvlQGZS 7ctZrFCUhoc/O/KkjbKHEK+Oljyi4y5Udl/mqa2XzDBJHJQcsTH/k70RZZC/8t7TWU+0 5j1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wc/+KzZ4bsXDa1+7QNiRz2dCKuS0B875Wsmy7qN7NvE=; b=c6htNAhGXuSCauNPcBtJ4FaGG6W/xRLZlEkNnIRKdfhxtNlfAcae+Hhaym9189xWM5 X8YikUUyRt3s1DuqxE/jXG3FRk22zRveSDcl/qCax5qcV4nNkHn5gBrT/XuGLRlDF8p7 VWSCqBzhdojgNJI0VDGFZ9zORhWgJ31TQbgpUSPZN3bMpBsMd4YjWPHuAwrw7E7r3Mhi Clp6xBeqzBlW89759XBt23bF/QBKvHkk7xybmmcFkNwU+TcMD4/9wR6+43UFerY7mxcG 2nPyA+PLq7d2mbqMFgZJii2KemQuHxVOXBE7305TrttdxZs9dr0mGVHnSgXjzYuaoS5O 0h2Q== X-Gm-Message-State: AKGB3mJ9GJSDfLLXFLLoM2PGRPHcOnfZQgAibvcnFQBm2OZ0HW+QBe88 KYaEOzsxIp2akdhkePv+XincwA== X-Google-Smtp-Source: ACJfBou4t+ms2KCAmCcM63wgNxzT4EQ1vQOwcZGQlBZTdT6g/DbuGEzb/rZ6Fh7FXQt/sAMaasm02A== X-Received: by 10.28.10.70 with SMTP id 67mr8446439wmk.12.1515411344832; Mon, 08 Jan 2018 03:35:44 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id b78sm12955669wmi.18.2018.01.08.03.35.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2018 03:35:44 -0800 (PST) Date: Mon, 8 Jan 2018 12:35:32 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: Thomas Monjalon , Jingjing Wu , "dev@dpdk.org" , Neil Horman , Bruce Richardson , Konstantin Ananyev Message-ID: <20180108113532.j5jzqgd42zez7bzx@bidouze.vm.6wind.com> References: <1511870281-15282-1-git-send-email-matan@mellanox.com> <1515318351-4756-1-git-send-email-matan@mellanox.com> <1515318351-4756-6-git-send-email-matan@mellanox.com> <20180108103240.yvtwyvi2lfpeakeu@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 5/6] net/failsafe: use ownership mechanism to own ports X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 11:35:45 -0000 On Mon, Jan 08, 2018 at 11:16:37AM +0000, Matan Azrad wrote: > Hi Gaetan > > From: Gaëtan Rivet, Sent: Monday, January 8, 2018 12:33 PM > > Hi Matan, > > > > Thanks for the patches. A remark however: > > > > On Sun, Jan 07, 2018 at 09:45:50AM +0000, Matan Azrad wrote: > > > Fail-safe PMD sub devices management is based on ethdev port > > mechanism. > > > So, the sub-devices management structures are exposed to other DPDK > > > entities which may use them in parallel to fail-safe PMD. > > > > > > Use the new port ownership mechanism to avoid multiple managments of > > > fail-safe PMD sub-devices. > > > > > > > I think your implementation does not work with several fail-safe instances, > > have you tested this configuration? > > > > Why not? Each instance calls to fs_eth_dev_create and there the unique owner id allocation is called. > So, Any instance should get a unique owner id. > Ah, sure, I forgot about the actual owner-id. No problem then, as you said it should work. Regarding the fail-safe part: Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND