From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id E31C91B010 for ; Mon, 8 Jan 2018 12:39:59 +0100 (CET) Received: by mail-wm0-f43.google.com with SMTP id 9so13487307wme.4 for ; Mon, 08 Jan 2018 03:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=joh7to/Tvp74AanekR8m7Y+KRNXxEgexdSH+1xgyiJI=; b=Q0KgsWyrdrtHkL/TDLvTGAkBuGeUfpQb8FusuYJQbYTSmIFZti9urBKwPyVSaMnuxj FJcUtUmwltzuWNRDJb4VjIArueKLowmjWE9SIMdWLYQrpKcMu9tXZfGMsjy57OE0AOqw ExE2yRNL2N6lc3kVWOrdxPYddu+ggML7iV18nkbO5DLpnD01rgKgwz8Q6oUweNeZFmaE OHeIpvXBZlaZN2larDlT9shCaMsLTpQYa+x6J0nMmHH/d/8Vd2nS4GJlCpyBlODnwcF6 F1KRi3zVO4K1YsuMgRodSFcbbrhVrprbpnIHWDM+L9lf4uLoJA4efAMVDixzwgAwECUZ WQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=joh7to/Tvp74AanekR8m7Y+KRNXxEgexdSH+1xgyiJI=; b=CHS78/qsl+cBVzLtMMRoUupXCs6zXhgvU44s9iFHwI1RaiywyX0QGPDtHiLn3cisG0 vWv2JpJjR0mRWVJysgD5QBqTXjV2cHm3dyOT9SUt6qA9qaY/tnACLlcEI5uuPlfVSwPd 1QT+iJcuzZCbFRFnwVCwbU/RZYND+F+BN+EMyw/S6wwJVl8p3/zPPpmY5z66XM/uUsDV fOlR6ksxQp+IKuUQLqQfEcoipjeEplIBcUrywWMs7CAtuzjJ3+O4yvtNGZEbtT4+pUGa JLe0V0f3Fj9Sv4j/XW8vHx5dGn3cTC1i9yLxiT4IDDBhr3KjP2akjlVSyG02TE5MQBzA Y5kg== X-Gm-Message-State: AKGB3mJftm8rqBVnhD4dOPGF8X1SCN1F7ySU1miqELoxzz/MXy6vonDs +/+sRqrwmnVcYTMK4QX9hAdUTQ== X-Google-Smtp-Source: ACJfBovtgAX44wlSTF9HGMJz+MhJlyMw29yGfGX2xtJLDf2MOBBEuw+XvIowqEAtqu2WTasU6UHd7Q== X-Received: by 10.28.22.67 with SMTP id 64mr8659546wmw.28.1515411599402; Mon, 08 Jan 2018 03:39:59 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e4sm13450976wmi.14.2018.01.08.03.39.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 Jan 2018 03:39:58 -0800 (PST) Date: Mon, 8 Jan 2018 12:39:46 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: Thomas Monjalon , Jingjing Wu , dev@dpdk.org, Neil Horman , Bruce Richardson , Konstantin Ananyev Message-ID: <20180108113946.hcgxvulamjsiepre@bidouze.vm.6wind.com> References: <1511870281-15282-1-git-send-email-matan@mellanox.com> <1515318351-4756-1-git-send-email-matan@mellanox.com> <1515318351-4756-7-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515318351-4756-7-git-send-email-matan@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 11:40:00 -0000 Hi Matan, On Sun, Jan 07, 2018 at 09:45:51AM +0000, Matan Azrad wrote: > Testpmd should not use ethdev ports which are managed by other DPDK > entities. > > Set Testpmd ownership to each port which is not used by other entity and > prevent any usage of ethdev ports which are not owned by Testpmd. > This patch should not be necessary. Ideally, your API evolution should not impact the default case. As such, the default iterator RTE_ETH_FOREACH_DEV should still be used in testpmd. RTE_ETH_FOREACH_DEV should call RTE_ETH_FOREACH_DEV_OWNED_BY, with the default owner (meaning that it would thus iterate on the application-owned set of device). This new API should avoid breaking the current code as much as possible. -- Gaëtan Rivet 6WIND