From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46])
 by dpdk.org (Postfix) with ESMTP id 72B991B1C7
 for <dev@dpdk.org>; Mon,  8 Jan 2018 21:53:41 +0100 (CET)
Received: by mail-pg0-f46.google.com with SMTP id r2so6360644pgq.13
 for <dev@dpdk.org>; Mon, 08 Jan 2018 12:53:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=EEv7PTkTs3zfgD2D9vaLidEPAnaTz4n/ubTGxu1o4g8=;
 b=UaLF0T63xvEMBkF0zwlEGHUdZd73bDv+QGu1yyd6QFqYiVumIFrQtCOpPkzsLfVTJ5
 OZPc6i+D2JBmUOz7wif0vIIIwtxdjvBzUXOqLq75i+j09z97rq0ZHIHXYavK5P+kAMzp
 V7FC2zSKXSM7vKC/TEVC4Qyvghyuhz/ZmRP2SgA1wSTFyGGNMWmthRdwJsJ1DB+nVT1z
 sUsJ8UG8K2no/8XDmtXKmIMfPki4NCnlCriRl0uZ2Yw6m+skGGbsx34x1BkY+t7ycLOf
 42/rMupcMuunaaL96nm7fjtbH1NMTSqd4zXQ2j09l6WcZ7QZ1wfM2bPyxeYYCLQdogCP
 OsHw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=EEv7PTkTs3zfgD2D9vaLidEPAnaTz4n/ubTGxu1o4g8=;
 b=XzuHsLeFvh5lLbKeqgB0rcsPuXE7043SWq8Ak3p4zf/jBHgwkV68tYlfodG6ANXptx
 NSUkP212VzZgwFR/Kn/NPxwsLXoYHIcKMD8uCXnBc6NU39f1JfPhAGCFGY+a0rLHAxys
 VFgcEx8YiQjrJpmg/I3dF2LNIT4sQbK7EM0SLhIQG0dB2MpOuNHbJTnRk2VtjtsJm78X
 hV/h3EBDdtiS2seFR5XlLKSN8S/+5PSrSMK+TLITe6ToLyVXZMzCuuKEdazmEEqVZl7V
 Ot4yOT0pPkU3vdGIZ9ow59ZycsCtzjimNplScMGge9CE31gG3TtxGS7fCXMrxJsCGIF/
 ynbQ==
X-Gm-Message-State: AKGB3mIQFzVLa404dvmoZIqHZA8RsyE7INE7BSBerCyTR0O7M5Wk9Kw5
 9n78eOKw9ErNEoOd7z2tJnw5wQ==
X-Google-Smtp-Source: ACJfBosvmjDT0s4Abyi9xzp5/7VwRbWaL68veeoD0/2LwWlWXLtLvzsTq1x65ik/xKHOjq/Be6w1EA==
X-Received: by 10.159.207.138 with SMTP id z10mr13060040plo.107.1515444820553; 
 Mon, 08 Jan 2018 12:53:40 -0800 (PST)
Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133])
 by smtp.gmail.com with ESMTPSA id y7sm23370703pgr.64.2018.01.08.12.53.39
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 08 Jan 2018 12:53:40 -0800 (PST)
Date: Mon, 8 Jan 2018 12:53:35 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com
Message-ID: <20180108125335.6d0900a5@xeon-e3>
In-Reply-To: <20180108202437.56305-2-ajit.khaparde@broadcom.com>
References: <20180108202437.56305-1-ajit.khaparde@broadcom.com>
 <20180108202437.56305-2-ajit.khaparde@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 01/13] net/bnxt: check return values in
 bnxt_dev_init
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jan 2018 20:53:41 -0000

On Mon,  8 Jan 2018 12:24:25 -0800
Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:

> +	rc = bnxt_hwrm_queue_qportcfg(bp);
> +	if (rc) {
> +		RTE_LOG(ERR, PMD, "hwrm queue qportcfg failed\n");
> +		goto error_free;
> +	}

I noticed that this driver is still using RTE_LOG directly.
The current desired behaviour is for each driver to define its own dynamic
log type (see i40e for an example).