From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id DC4BA1B16F for ; Mon, 8 Jan 2018 18:45:26 +0100 (CET) Received: by mail-pf0-f193.google.com with SMTP id j3so2621434pfh.8 for ; Mon, 08 Jan 2018 09:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xdEkfCIuK6BT4fpL1zpOPTyGD9J2nN3TmX3p03g4WwI=; b=Fqhor1e2mDQOHkfW14lF2I0Nj2S7sQUQaqvdzrqlPeQh5yVlBDw/H3uR7Etn8aqsZu Ubt1kTzBgBaEzk5Uf+0eDHgpmNGqaRntrzIINPJRkqAAagODVKdQVItLiZiUYIo5WH1+ Q0nbpbfJqFrvfib1U7eIfnfwEmiEVCugGATtGSTSSgASSfFJpF5/CPLbAnAmA83mu+Vh pxmHolth6Hbpcm7drW8zJdOgTZVBe6nNzVF6ztQzj2UOL3IdfEKSGlCV+N/f8dk0u1yu xuFOCCrT4OpTo8VQ5MrEfBz2RvXIrbnU8BzPaoFmIqEhlYH6e7+jSF9dZorGOg2VLJob j4KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xdEkfCIuK6BT4fpL1zpOPTyGD9J2nN3TmX3p03g4WwI=; b=EYsNJSEsC0TbDyYE1R3dd3pkCtu9xSrA/rjF2GR0K8y6wivI7ua2qpezqsoejkLKg4 /UM7yrUdaTyXvzJXoQ4ZryNmbFe/87LmWBU9FBVewne+SD/0wCS9r/85v0odPuys6tUJ 6G7Gk843yFSAuZfBcxBmjNNC34HaEPc3IKaXbYAuWYJGvusEPYeQ6Lssr40YKxQM4ld5 JoTfawpVeqLNO7AxfaWmlc/G/iYhUHtCqKLwJc5yydWVvVqZ9b3rsrBAAKBi0zm3JoYD rszUDn4uaKzHa+ixiVHeX5xmIDcjRkvk8PL+lB9xhsddCtAJia0fg5cDGF9E6FmxGT8/ CzXQ== X-Gm-Message-State: AKGB3mIKWcfHYyvHx7tlpG04VB+WmLdcEReC1PS2WlmKoa8wKX2MhWS7 668AqgNOHrt/rBza5Af4+r3/zrp/iUs= X-Google-Smtp-Source: ACJfBou5w02M9R9VSRsW8UpD8WAikunLr8E5DI47L3IkWQAP4NJep17jIdiTGckYHmk8Pm6T1QhUmg== X-Received: by 10.84.150.129 with SMTP id h1mr12963164plh.108.1515433525428; Mon, 08 Jan 2018 09:45:25 -0800 (PST) Received: from xeon-e3.lan (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id j14sm10933142pfh.94.2018.01.08.09.45.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jan 2018 09:45:23 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 8 Jan 2018 09:45:01 -0800 Message-Id: <20180108174514.14688-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180108174514.14688-1-stephen@networkplumber.org> References: <20180108174514.14688-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH v3 02/15] ethdev: add linkstatus get/set helper functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 17:45:27 -0000 Many drivers are all doing copy/paste of the same code to atomically update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 36 ++++++++++++++++++++++++++++++++++++ lib/librte_ether/rte_ethdev.h | 28 ++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index a524af740f4a..6674500bbc4a 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1495,6 +1495,42 @@ rte_eth_link_get_nowait(uint16_t port_id, struct rte_eth_link *eth_link) } } +int +_rte_eth_linkstatus_set(struct rte_eth_dev *dev, + const struct rte_eth_link *new_link) +{ + volatile uint64_t *dev_link + = (volatile uint64_t *)&(dev->data->dev_link); + union { + uint64_t val64; + struct rte_eth_link link; + } orig; + + RTE_BUILD_BUG_ON(sizeof(*new_link) != sizeof(uint64_t)); + + orig.val64 = rte_atomic64_exchange(dev_link, + *(const uint64_t *)new_link); + + return (orig.link.link_status == new_link->link_status) ? -1 : 0; +} + +void +_rte_eth_linkstatus_get(const struct rte_eth_dev *dev, + struct rte_eth_link *link) +{ + volatile uint64_t *src = (uint64_t *)&(dev->data->dev_link); + uint64_t tmp; + + RTE_BUILD_BUG_ON(sizeof(*link) != sizeof(uint64_t)); + + /* can't use rte_atomic64_read because it returns signed int */ + do { + tmp = *src; + } while (!rte_atomic64_cmpset(src, tmp, tmp)); + + memcpy(link, &tmp, sizeof(tmp)); +} + int rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats) { diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index b10e2a92da71..b47402b797c3 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -2218,6 +2218,34 @@ int rte_eth_dev_set_link_down(uint16_t port_id); */ void rte_eth_dev_close(uint16_t port_id); + +/** + * @internal + * Atomically set the link status for the specific device. + * It is for use by DPDK device driver use only. + * User applications should not call it + * + * @param dev + * Pointer to struct rte_eth_dev. + * @param link + * New link status value. + * @return + * -1 if link state has changed, 0 if the same. + */ +int _rte_eth_linkstatus_set(struct rte_eth_dev *dev, + const struct rte_eth_link *link); + +/** + * @internal + * Atomically get the link speed and status. + * @param dev + * Pointer to struct rte_eth_dev. + * @param link + * link status value. + */ +void _rte_eth_linkstatus_get(const struct rte_eth_dev *dev, + struct rte_eth_link *link); + /** * Reset a Ethernet device and keep its port id. * -- 2.15.1