From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by dpdk.org (Postfix) with ESMTP id 130191B040 for ; Mon, 8 Jan 2018 18:45:27 +0100 (CET) Received: by mail-pf0-f194.google.com with SMTP id d23so6457764pfe.9 for ; Mon, 08 Jan 2018 09:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6unyyX8PWxQHPn8Q5+Jy3lGMDf/BZxHkyJhe+mk0Vcc=; b=TUH5B6WFkEDCvzdivPVZstq42KnJ+OG1ykmB2BlxwSkWc8d5zQ141WEg1urYS4xkWX ztn37ZtcEayawfs4k4ykiD5oVBL4Ygmwkg0AGfok0/m7skWNkvQhRPUT6vXC3ybIIOSX 1HzZ7WRmW4hmwhGn9i82SmV4Auc5drIWvkhZNnt1N8fyK0j4AAxcJseQACheWZQB1AWt PEbASL6xEs1CbY0epB5bwhTB44J0OZMwkKU+N8qOll8GbKXHqaCzNoF8iBZwEoaqtyjY b7JZXKiFsIXPnSRv3J+wcsEEWSfkullimiZaYlS8wErZyxyFN3hHM54T1cdmk6T+AKey pbTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6unyyX8PWxQHPn8Q5+Jy3lGMDf/BZxHkyJhe+mk0Vcc=; b=oEI6VdbvN6kyVWEmZqPB7SNyZCZWP9753eR7pUVUmzFH0O0NLrfin2FkVyw24EA74i BHqWFS42svfy5POPqz0WpgWpCGSArw05GeVKE0GgjY1k66nYlo1aPlKgP+v1jZ5Tb1NI 8mOHX0spckpA2gSMb+v6tUpGnEEIWjHM+cwtH9kaZfoEEFPy5xwHtneN3gKMYDw4wFrV a0MwkkoIYz/hPRRhPAoRUpzYS3ajbcaFI4pCjvxcSPEXFEC2Xg+QfAT15QGcXh9eWiUH dBP8rK61PbqCHnaWWSV2yByvo+FYmmxZlyie8VBOhARPmkPZCUTgGKgjwkVDGsvM0UWm hvJw== X-Gm-Message-State: AKGB3mItT3FRQjbNSUj9YWru6Sq98S2Vi/m9rmU+WUwREEXXCi5qcA6o Gc7gzsNDadxDyaeGJXz25QTbe9eRy30= X-Google-Smtp-Source: ACJfBotuce4oRPl4Ge+3b20buGNgZlDbOft8ou+fMHYnlsTyMxyPUAg7gxvO8Zw3lVg6Iwc67f4N9Q== X-Received: by 10.84.211.105 with SMTP id b96mr12683360pli.308.1515433526785; Mon, 08 Jan 2018 09:45:26 -0800 (PST) Received: from xeon-e3.lan (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id j14sm10933142pfh.94.2018.01.08.09.45.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jan 2018 09:45:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Mon, 8 Jan 2018 09:45:02 -0800 Message-Id: <20180108174514.14688-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180108174514.14688-1-stephen@networkplumber.org> References: <20180108174514.14688-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH v3 03/15] net/virtio: use eth_linkstatus_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 17:45:28 -0000 Use the new comon code in ethdev to handle link status update. Signed-off-by: Stephen Hemminger --- drivers/net/virtio/virtio_ethdev.c | 64 +++++++------------------------------- 1 file changed, 11 insertions(+), 53 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 21f2131a9efd..ac46c749aaa4 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -771,46 +770,6 @@ static const struct eth_dev_ops virtio_eth_dev_ops = { .mac_addr_set = virtio_mac_addr_set, }; -static inline int -virtio_dev_atomic_read_link_status(struct rte_eth_dev *dev, - struct rte_eth_link *link) -{ - struct rte_eth_link *dst = link; - struct rte_eth_link *src = &(dev->data->dev_link); - - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, - *(uint64_t *)src) == 0) - return -1; - - return 0; -} - -/** - * Atomically writes the link status information into global - * structure rte_eth_dev. - * - * @param dev - * - Pointer to the structure rte_eth_dev to read from. - * - Pointer to the buffer to be saved with the link status. - * - * @return - * - On success, zero. - * - On failure, negative value. - */ -static inline int -virtio_dev_atomic_write_link_status(struct rte_eth_dev *dev, - struct rte_eth_link *link) -{ - struct rte_eth_link *dst = &(dev->data->dev_link); - struct rte_eth_link *src = link; - - if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, - *(uint64_t *)src) == 0) - return -1; - - return 0; -} - static void virtio_update_stats(struct rte_eth_dev *dev, struct rte_eth_stats *stats) { @@ -1913,8 +1872,10 @@ static void virtio_dev_stop(struct rte_eth_dev *dev) { struct virtio_hw *hw = dev->data->dev_private; - struct rte_eth_link link; struct rte_intr_conf *intr_conf = &dev->data->dev_conf.intr_conf; + struct rte_eth_link link = { + .link_status = ETH_LINK_DOWN, + }; PMD_INIT_LOG(DEBUG, "stop"); @@ -1922,21 +1883,19 @@ virtio_dev_stop(struct rte_eth_dev *dev) virtio_intr_disable(dev); hw->started = 0; - memset(&link, 0, sizeof(link)); - virtio_dev_atomic_write_link_status(dev, &link); + _rte_eth_linkstatus_set(dev, &link); } static int virtio_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complete) { - struct rte_eth_link link, old; - uint16_t status; struct virtio_hw *hw = dev->data->dev_private; - memset(&link, 0, sizeof(link)); - virtio_dev_atomic_read_link_status(dev, &link); - old = link; - link.link_duplex = ETH_LINK_FULL_DUPLEX; - link.link_speed = SPEED_10G; + uint16_t status; + struct rte_eth_link link = { + .link_speed = ETH_SPEED_NUM_10G, + .link_duplex = ETH_LINK_FULL_DUPLEX, + .link_autoneg = ETH_LINK_SPEED_FIXED, + }; if (hw->started == 0) { link.link_status = ETH_LINK_DOWN; @@ -1957,9 +1916,8 @@ virtio_dev_link_update(struct rte_eth_dev *dev, __rte_unused int wait_to_complet } else { link.link_status = ETH_LINK_UP; } - virtio_dev_atomic_write_link_status(dev, &link); - return (old.link_status == link.link_status) ? -1 : 0; + return _rte_eth_linkstatus_set(dev, &link); } static int -- 2.15.1