From: Yuanhan Liu <yliu@fridaylinux.org>
To: "Chen, Junjie J" <junjie.j.chen@intel.com>
Cc: "Wang, Xiao W" <xiao.w.wang@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Bie, Tiwei" <tiwei.bie@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Yao, Lei A" <lei.a.yao@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression
Date: Tue, 9 Jan 2018 10:29:34 +0800 [thread overview]
Message-ID: <20180109022934.GE29540@yliu-mob> (raw)
In-Reply-To: <AA85A5A5E706C44BACB0BEFD5AC08BF6313296E1@SHSMSX101.ccr.corp.intel.com>
On Tue, Jan 09, 2018 at 02:12:02AM +0000, Chen, Junjie J wrote:
> > > + if (vring_need_event(vhost_used_event(vq), new, old)
> >
> > It's a bit weird that you use one from the standard linux header file
> > (vring_need_event), while you define you own one (vhost_used_event).
> > Note that the system header file also has "vring_used_event()" defined.
> The vring_used_event is defined and used for virtio in kernel, kernel defines a vhost_used_event in vhost.c for vhost, so I just use a separated macro for vhost end.
>
> I'd like to define both vhost_need_event and vhost_used_event in vhost.h to remove potential build issue in old linux distribution and also to keep consistent. Is that OK for you?
Yes.
--yliu
next prev parent reply other threads:[~2018-01-09 2:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 11:02 [dpdk-dev] [PATCH v4] " junjie.j.chen
2017-12-23 16:55 ` [dpdk-dev] [PATCH v5] " Junjie Chen
2017-12-26 8:03 ` Wang, Xiao W
2017-12-26 17:43 ` [dpdk-dev] [PATCH v6] " Junjie Chen
2018-01-05 5:25 ` Wang, Xiao W
2018-01-08 14:06 ` Yuanhan Liu
2018-01-09 2:12 ` Chen, Junjie J
2018-01-09 2:29 ` Yuanhan Liu [this message]
2018-01-09 11:03 ` [dpdk-dev] [PATCH v7] " Junjie Chen
2018-01-09 7:34 ` Yao, Lei A
2018-01-09 12:58 ` Yuanhan Liu
2018-01-09 8:56 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109022934.GE29540@yliu-mob \
--to=yliu@fridaylinux.org \
--cc=dev@dpdk.org \
--cc=junjie.j.chen@intel.com \
--cc=lei.a.yao@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).