From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 73B0A1B1A4 for ; Tue, 9 Jan 2018 03:29:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DAEC120C4E; Mon, 8 Jan 2018 21:29:38 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 08 Jan 2018 21:29:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=ZUlqdGn/Anzx6rtYQRz0SclZiFp9Kco2N5rE3hM1hek=; b=lIN/hSZ5 MDbw5mENh1DYQyZamIVmh46JWoGuND+Qp9TNJxNJejbFfuqKecKGWYF8bbSo4EX4 lpnQzOE14YaJrER5VXLpjv0xb9rEoHP85uLB8U+cWFQWmENSasym5pZrJFRR3iVU IEXrU5bmtsHMICwyTol1Ot1fD+pYH+/KmM4bCi2qnoIbE9LpFJyON5DnLRWENFfK XlLrNAEpZNBVlJVy9jQggAYMDXCMGH37B5DHelJyfyQFqjGXFHk1CSYM862R5YTw +XCNi3vWYTbO5bgzWZC2X1KXbVqz5QyKBe3r7TbNXMPgUs3tDnUxFppq0NK7Q5TN EYa7JUjs3htrAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=ZUlqdGn/Anzx6rtYQRz0SclZiFp9K co2N5rE3hM1hek=; b=H0FUlXjGnmyrydiKPZTaSMSYQiDY2QxYV8FoXcE34dRRj FnJkxMUyvo8oOtyc2knrLOPtXeIjOmYuyjDREHWlDeMz8FIR+IWZtXGlUMW4s3Ud l8Mr2rHhIKWOUtEiSuI/Z/u1YxfSqWmUNR7UT85hgKKwvtToalKHZRxuqMdUbIQN 1kYDlKg7nOOICOBRV8PXvDWFrMWPLY7SCvC7cD3ICjxkO6Qw7V07JGUwEtwKGAKR /cjVOns0CvjWlHixSUFz8XuMZ0uyUn7j/kGLC4LU9QC8oMQqWkeEMYCHh5Gtb0LF 2DXaBvQ3CNayLSndx/BRhousNcsbi4yVEsw657Ejg== X-ME-Sender: Received: from yliu-mob (unknown [115.150.10.63]) by mail.messagingengine.com (Postfix) with ESMTPA id C359024741; Mon, 8 Jan 2018 21:29:37 -0500 (EST) Date: Tue, 9 Jan 2018 10:29:34 +0800 From: Yuanhan Liu To: "Chen, Junjie J" Cc: "Wang, Xiao W" , "maxime.coquelin@redhat.com" , "Bie, Tiwei" , "dev@dpdk.org" , "Yao, Lei A" Message-ID: <20180109022934.GE29540@yliu-mob> References: <1514048153-82959-1-git-send-email-junjie.j.chen@intel.com> <1514310190-140916-1-git-send-email-junjie.j.chen@intel.com> <20180108140659.GA29540@yliu-mob> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v6] vhost: support virtqueue interrupt/notification suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 02:29:39 -0000 On Tue, Jan 09, 2018 at 02:12:02AM +0000, Chen, Junjie J wrote: > > > + if (vring_need_event(vhost_used_event(vq), new, old) > > > > It's a bit weird that you use one from the standard linux header file > > (vring_need_event), while you define you own one (vhost_used_event). > > Note that the system header file also has "vring_used_event()" defined. > The vring_used_event is defined and used for virtio in kernel, kernel defines a vhost_used_event in vhost.c for vhost, so I just use a separated macro for vhost end. > > I'd like to define both vhost_need_event and vhost_used_event in vhost.h to remove potential build issue in old linux distribution and also to keep consistent. Is that OK for you? Yes. --yliu