From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id B6BB51B1B8 for ; Tue, 9 Jan 2018 19:58:13 +0100 (CET) Received: by mail-pg0-f68.google.com with SMTP id f14so6025779pga.10 for ; Tue, 09 Jan 2018 10:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C4gU2otgt1IsYxMM3T7wf6CGwKZhcbsfyTl4C9yMmeA=; b=WNPS6FYWQXy8cTRBjkIrPT3dna3UJ4/8mdy9K1UHaHXRCrcnanzSd9Zl/WW4R9FXl8 VySDg6k10KfOBOmnQCBMcsSNINpubWC0Nt9EVsD20zpu8El18H+VvK4ZHHkY4hlg9Zah 2WMZ+9m9+Sp1/VjU2oUGsJzJWgP8hwjBSVEgMUiv4YijYay+5ccP2lPUIOYwagPvxrAN KtFdH00VjUXiocn+vC9S/3100Skkx+7C3k4ZI2Zv2dvaU5JwS5ZCIJG9sjNVO+L5V/W/ Wxbqca3i4TkTDErk165BrMwFr4rajZQp5jKlmWdS6YanFEBdN0cuN2Bckd97LnaaOmgn ra5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C4gU2otgt1IsYxMM3T7wf6CGwKZhcbsfyTl4C9yMmeA=; b=KfO1rl9JaXRpaHyVPKRYlR4px0inMJvBPaOnO3aZRnXjW+8j79w4LpHO3l/VCPoUfN KjtIWEbHWcbXleUXKyPtBQ85uyDEt0ByxvYAb8cMLHWFmR2aT5aEkWNX+QpN0AwjsADX BpZfmi6nrvd7csl9Sq/VghYe90gyFJ9+DLqUQYHge7KYXXhXTFvj72x2RCnmdB2p2/uM mF+aFfh1br2OoCSOVLnCmzdkyaJyHGEzt3lxzbh9TudYehrdxOaZHvgQURnJXEXAz4iX R5SMiWTfb2EdB103ptSLc92VkrZSaLFd9E0a6mpyrbh+jcs1gS4Uup7M3q+W+pri6bxk VaeA== X-Gm-Message-State: AKGB3mKjZxfU5SpKer2aK1vPXZqbQGrNYhEHDFuDQfMYvB1tZHGGS9Wm oNhlUtd4AFjkpDFxnwb10+nsuQ== X-Google-Smtp-Source: ACJfBouF23QyfRyTKYM9Sa+L0L+Ckniv815GcGfhpwrUPbwLKFki6tVTUfUzKYzBOmKkgIaOw7Bnuw== X-Received: by 10.99.110.78 with SMTP id j75mr11924094pgc.371.1515524292912; Tue, 09 Jan 2018 10:58:12 -0800 (PST) Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133]) by smtp.gmail.com with ESMTPSA id m63sm31003233pfj.80.2018.01.09.10.58.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jan 2018 10:58:12 -0800 (PST) Date: Tue, 9 Jan 2018 10:58:11 -0800 From: Stephen Hemminger To: Ferruh Yigit Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, declan.doherty@intel.com, Boris Pismenny , Aviad Yehezkel , Radu Nicolau Message-ID: <20180109105811.2995412e@xeon-e3> In-Reply-To: <20180109162317.18183-6-ferruh.yigit@intel.com> References: <20171201022957.64329-1-ferruh.yigit@intel.com> <20180109162317.18183-1-ferruh.yigit@intel.com> <20180109162317.18183-6-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 6/6] ethdev: return named opaque type instead of void pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 18:58:14 -0000 On Tue, 9 Jan 2018 16:23:17 +0000 Ferruh Yigit wrote: > "struct rte_eth_rxtx_callback" is defined as internal data structure and > used as named opaque type. > > So the functions that are adding callbacks can return objects in this > type instead of void pointer. > > Signed-off-by: Ferruh Yigit My comment was "yes I agree pointer should have opaque type" Acked-by: Stephen Hemminger