From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gaetan.rivet@6wind.com> Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 356CB2904 for <dev@dpdk.org>; Tue, 9 Jan 2018 13:42:17 +0100 (CET) Received: by mail-wr0-f170.google.com with SMTP id w107so13965374wrb.9 for <dev@dpdk.org>; Tue, 09 Jan 2018 04:42:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Nk8BqeTkixNJ4kfnZH9pTOCDXemT76AwqV7ALYveXjM=; b=FcOOXZbeCKCOUZLNShcOGRiDAZc1W+nH9VnH9Mq+Dhxx6R/iXFzej65YiuE22xBRyg Y/mWmR1LRDSnUkivBwKxVTYu3ijQ/tvcoGo36X/BGqMxtqtlG/qnchkIz79eTS9ragpa xFobkZc2dlRjWxMXvPv5uaqeX3l0CFQjEyfT8t7DA6dirvIV6XncCAUcuLKkzJ8gvDee 3Xxa3sg1rUV9qZtsLUPWP4JghikRiUsIblP1u6hLLotIbD/ZQJ7CQicbzJZ2TeMlmU3z z7PlcIyVAbbYWXz8UtTgYjdzLn8Xkoq9yF4gTJs0vUhhqsHtbxwtYd2RVPhxtYY1iDJt WvrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Nk8BqeTkixNJ4kfnZH9pTOCDXemT76AwqV7ALYveXjM=; b=llsvLoIi3cqVaYk2aFmCUK1A9vNYR51Y6ZvGptWetyFtFN3x2HvqEqxootqNSrOOIg F0gURpMNhfg7KMTKcIvPTiqzRXsJ5h0J2vPu+6nP7G3PDiq0DJtTnSj3R196Dj+C/6f1 oQRG2kZh1wRo4w/z2A3ilzgnRglibmE4U4CiPhEyEC0DaDn9onZuhlslfV03XIMlUY7l gRNkJ6sRBtUdganblQiMNhkLfVf77+j+lay1/OyyOgL9yDpWrjfG9+/vQukkJGbhXBHD x/UFylfk+gsJzxd3xtrnxl877L7fxt69c3F2RvJtp6J3H8841W0wxWI3G6mQW+XzA4t9 yG4Q== X-Gm-Message-State: AKGB3mL9mJiW/Pbsd7ntaqui+t6QW7NtVUcwZK5uPX8ypYFOGFRCYjcj 0yj/wAmB1iK5o7JmHZ/jYX5JpA== X-Google-Smtp-Source: ACJfBotnf93TXXXMdNcFQitth1MSY2WYrfh76e9ZjYBvBQlu39gvMNbP5jo7pJfBca5FzrzMf6j2Fg== X-Received: by 10.223.181.2 with SMTP id a2mr14067985wrd.90.1515501737492; Tue, 09 Jan 2018 04:42:17 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k25sm24508206wrk.11.2018.01.09.04.42.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jan 2018 04:42:16 -0800 (PST) Date: Tue, 9 Jan 2018 13:42:04 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com> To: "Guo, Jia" <jia.guo@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Mordechay Haimovsky <motih@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com> Message-ID: <20180109124204.xltndt76khsrgmpe@bidouze.vm.6wind.com> References: <1509567405-27439-3-git-send-email-jia.guo@intel.com> <2803089.mJXnisXhBj@xps> <01BA8470C017D6468C8290E4B9C5E1E83B2D13F4@shsmsx102.ccr.corp.intel.com> <3539603.0DoXzmkF5E@xps> <01BA8470C017D6468C8290E4B9C5E1E83B2D1493@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <01BA8470C017D6468C8290E4B9C5E1E83B2D1493@shsmsx102.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 09 Jan 2018 12:42:18 -0000 Hi Jeff, On Tue, Jan 09, 2018 at 12:08:52PM +0000, Guo, Jia wrote: > Your comments about split it totally make sense ,no doubt that, but my question is that if split api with the funcational , so the function part should be set null implement or stake. Any other good idea or tip for that. > Please avoid top-posting on the mailing list, it is confusing when reading a thread intertwined with inner-posted mails. Regarding your issue, it is fine to propose a first skeleton API with bare implementations, then progressively use your new functions where relevant. It is only necessary to ensure compilation is always possible between each patch. The API itself need not be usable, as long as the patch order remains coherent and meaningful for review. Otherwise, sorry about not doing a review earlier, I didn't think I knew enough about uevent to provide useful comments. However after a quick reading I may be able to provide a few remarks. I will wait for your split before doing so. > Best regards, > Jeff Guo > > > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Tuesday, January 9, 2018 7:45 PM > To: Guo, Jia <jia.guo@intel.com> > Cc: Mordechay Haimovsky <motih@mellanox.com>; dev@dpdk.org; stephen@networkplumber.org; Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; gaetan.rivet@6wind.com; Ananyev, Konstantin <konstantin.ananyev@intel.com>; shreyansh.jain@nxp.com; Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com> > Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug > > 09/01/2018 12:39, Guo, Jia: > > So, how can separate the patch into more small patch, use stake or null implement in function. I think we should consider if it is a economic way now, if I could explain more detail in code for you all not very familiar the background? I have sent v8, please check, thanks all. > > The v8 is not split enough. > Please try to address all my comments. -- Gaëtan Rivet 6WIND