From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CD7191B1D4 for ; Tue, 9 Jan 2018 14:40:42 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7C6F020AF2; Tue, 9 Jan 2018 08:40:42 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 09 Jan 2018 08:40:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=asipfrWYlKtzh+qcV6zIwnsq6gxSvchJwbZeBrL9L84=; b=SH4OonXi 34g9Ugvh8GW04kKVl/9BrsDNb0Tac4dd6RjoyhJgwkdMNhmub12/vL5m0wQtmyAa G8NCvUBWCYsyva8FDGN/dj4Prs+qFimxSPNad15aG2ws7pPtfB6GGWUgCBOkk0QU IJky5VvsNJcmA+b4cZ23MsyZcfX6k1i6Dh8OMAUCILzP9IuW5NfITOFUuDwj3pwz oFG3DVv6nUY1dxeDbDAT2FJJ7o415hokkUyV8gimfqLzBqCUZcdbjSDbV2d8yTxo jjVGrD6ZxlxUhrWxTT+TQ7zgVAEJQDU/t6YU8s3jS3ragfJPufusu/Svgz+0bPn7 WUoiV+tOfCfIqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=asipfrWYlKtzh+qcV6zIwnsq6gxSv chJwbZeBrL9L84=; b=XHlwNgx+r6YjHi7BMpDjPRxpjOAkeejGSaHZBc+wC8Vv1 22leiwgrjZl9F+XF/5VsOnexPvj4Lwl9cnvMp5h4OfGgMoRAF523EJYF7slsP/25 qR0rPNQVkmJKcS/mN8PBZjO5PHv2iXPqMjHEvdruSvGG7w9H0ofGuwlOGXNCOdXQ GCbA0pCW0eG4W9Jmt1bYCgYbWGvQW8+ptjBQIFRg+9fK9VdSXzL5okKVUhGa5pwc xvfeD1acH/8PY/xoxyNuTDUEgzA/drzm9nw/ntGWWQyyHOScOJ0BwkPF4UDcN33J u1lKVkKPCaTI0mfQdz1TJYgJqGSxsMBQWhtSQtBOQ== X-ME-Sender: Received: from yliu-mob (unknown [115.150.10.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 21C94246D0; Tue, 9 Jan 2018 08:40:40 -0500 (EST) Date: Tue, 9 Jan 2018 21:40:37 +0800 From: Yuanhan Liu To: Tonghao Zhang Cc: dev@dpdk.org Message-ID: <20180109134037.GO29540@yliu-mob> References: <1515161439-4792-1-git-send-email-xiangxia.m.yue@gmail.com> <1515161439-4792-5-git-send-email-xiangxia.m.yue@gmail.com> <20180109131243.GJ29540@yliu-mob> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180109131243.GJ29540@yliu-mob> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 13:40:43 -0000 On Tue, Jan 09, 2018 at 09:12:43PM +0800, Yuanhan Liu wrote: > On Fri, Jan 05, 2018 at 06:10:39AM -0800, Tonghao Zhang wrote: > > This patch adds the name for vhost-user reconnect thread. > > It can help us to know whether the thread is running. > > > > Signed-off-by: Tonghao Zhang > > --- > > lib/librte_vhost/socket.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > > index d44a0f1..c2e34e0 100644 > > --- a/lib/librte_vhost/socket.c > > +++ b/lib/librte_vhost/socket.c > > @@ -433,6 +433,7 @@ struct vhost_user_reconnect_list { > > vhost_user_reconnect_init(void) > > { > > int ret; > > + char thread_name[RTE_MAX_THREAD_NAME_LEN]; > > > > ret = pthread_mutex_init(&reconn_list.mutex, NULL); > > if (ret < 0) { > > @@ -449,6 +450,13 @@ struct vhost_user_reconnect_list { > > RTE_LOG(ERR, VHOST_CONFIG, > > "failed to destroy reconnect mutex"); > > } > > + } else { > > + snprintf(thread_name, RTE_MAX_THREAD_NAME_LEN, > > + "vhost-reconn"); > > + > > + if (rte_thread_setname(reconn_tid, thread_name)) > > + RTE_LOG(DEBUG, VHOST_CONFIG, > > + "Failed to set thread name for vhost-user reconnect"); > > Applied to dpdk-next-virtio, with the intendation fixed. Note that I have just applied this patch only. The rest of this patchset belongs to the ixgbe PMD driver, which need another maintainer for review. That also means, it's better if you could send them sperately next time when they are not related. More specifically, in this case, one patch for vhost-user, another patchset for all the rest ixgbe changes. --yliu