From: Bruce Richardson <bruce.richardson@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: bluca@debian.org, harry.van.haaren@intel.com,
jerin.jacob@caviumnetworks.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/4] event/octeontx: add octeontx event device to meson build
Date: Tue, 9 Jan 2018 17:34:00 +0000 [thread overview]
Message-ID: <20180109173400.GB6508@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20171231000203.4510-3-pbhagavatula@caviumnetworks.com>
On Sun, Dec 31, 2017 at 05:32:02AM +0530, Pavan Nikhilesh wrote:
> Add Cavium octeontx to meson build and change order of drivers built
> from event->mempool->net to mempool->net->event to resolve dependency.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> drivers/event/meson.build | 2 +-
> drivers/event/octeontx/meson.build | 5 +++++
> ...octeontx_ssovf_version.map => rte_pmd_octeontx_event_version.map} | 0
> drivers/meson.build | 2 +-
> 4 files changed, 7 insertions(+), 2 deletions(-)
> create mode 100644 drivers/event/octeontx/meson.build
> rename drivers/event/octeontx/{rte_pmd_octeontx_ssovf_version.map => rte_pmd_octeontx_event_version.map} (100%)
>
> diff --git a/drivers/event/meson.build b/drivers/event/meson.build
> index 437d80bfd..d7bc48545 100644
> --- a/drivers/event/meson.build
> +++ b/drivers/event/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -drivers = ['skeleton', 'sw']
> +drivers = ['skeleton', 'sw', 'octeontx']
> std_deps = ['eventdev', 'kvargs']
> config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD'
> driver_name_fmt = 'rte_pmd_@0@_event'
> diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build
> new file mode 100644
> index 000000000..fa46a67b5
> --- /dev/null
> +++ b/drivers/event/octeontx/meson.build
> @@ -0,0 +1,5 @@
> +sources = files('ssovf_evdev.c',
> + 'ssovf_worker.c'
> +)
> +
> +deps += ['mempool_octeontx', 'bus_vdev', 'pmd_octeontx']
> diff --git a/drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map b/drivers/event/octeontx/rte_pmd_octeontx_event_version.map
> similarity index 100%
> rename from drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map
> rename to drivers/event/octeontx/rte_pmd_octeontx_event_version.map
> diff --git a/drivers/meson.build b/drivers/meson.build
> index f5009aa2e..52d7176a3 100644
> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2017 Intel Corporation
>
> -driver_classes = ['bus', 'crypto', 'event', 'mempool', 'net']
> +driver_classes = ['bus', 'crypto', 'mempool', 'net', 'event']
This change is ok with me, but I think you need to add an explicit
comment in the file - not just in the comment message - as to why the
order is not alphabetical.
In fact, it might be good to split out each type on it's own line with a
comment, since bus should almost certainly go first, then probably
mempool - since we might have crypto drivers in future that depend on
it, and then finally the other types.
>
> foreach class:driver_classes
> drivers = []
> --
> 2.15.1
>
next prev parent reply other threads:[~2018-01-09 17:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 0:02 [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver " Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-09 17:29 ` Bruce Richardson
2018-01-11 12:42 ` Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 3/4] event/octeontx: add octeontx event device " Pavan Nikhilesh
2018-01-09 17:34 ` Bruce Richardson [this message]
2018-01-11 13:15 ` Pavan Nikhilesh
2017-12-31 0:02 ` [dpdk-dev] [PATCH 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-09 17:35 ` [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
2018-01-11 13:38 ` Pavan Nikhilesh
2018-01-11 13:44 ` Pavan Nikhilesh
2018-01-09 17:41 ` Bruce Richardson
2018-01-11 14:13 ` Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 3/4] event/octeontx: add octeontx event device " Pavan Nikhilesh
2018-01-14 13:28 ` [dpdk-dev] [PATCH v2 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 1/4] drivers/mempool: add octeontx mempool driver " Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-19 17:16 ` Bruce Richardson
2018-01-19 17:29 ` Pavan Nikhilesh
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 3/4] event: add octeontx event device " Pavan Nikhilesh
2018-01-19 17:19 ` Bruce Richardson
2018-01-19 13:12 ` [dpdk-dev] [PATCH v3 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-19 17:26 ` Bruce Richardson
2018-01-19 16:48 ` [dpdk-dev] [PATCH v3 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 " Pavan Nikhilesh
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 2/4] drivers/net: add drivers for Cavium NICs " Pavan Nikhilesh
2018-01-22 14:35 ` Bruce Richardson
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 3/4] event: add octeontx event device " Pavan Nikhilesh
2018-01-19 18:15 ` [dpdk-dev] [PATCH v4 4/4] app/test-eventdev: add test-eventdev " Pavan Nikhilesh
2018-01-22 14:37 ` [dpdk-dev] [PATCH v4 1/4] drivers/mempool: add octeontx mempool driver " Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109173400.GB6508@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).