From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D50742904 for ; Tue, 9 Jan 2018 18:34:07 +0100 (CET) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 09:34:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,336,1511856000"; d="scan'208";a="191977640" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by orsmga005.jf.intel.com with SMTP; 09 Jan 2018 09:34:01 -0800 Received: by (sSMTP sendmail emulation); Tue, 09 Jan 2018 17:34:00 +0000 Date: Tue, 9 Jan 2018 17:34:00 +0000 From: Bruce Richardson To: Pavan Nikhilesh Cc: bluca@debian.org, harry.van.haaren@intel.com, jerin.jacob@caviumnetworks.com, dev@dpdk.org Message-ID: <20180109173400.GB6508@bricha3-MOBL3.ger.corp.intel.com> References: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com> <20171231000203.4510-3-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171231000203.4510-3-pbhagavatula@caviumnetworks.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 3/4] event/octeontx: add octeontx event device to meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 17:34:08 -0000 On Sun, Dec 31, 2017 at 05:32:02AM +0530, Pavan Nikhilesh wrote: > Add Cavium octeontx to meson build and change order of drivers built > from event->mempool->net to mempool->net->event to resolve dependency. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/event/meson.build | 2 +- > drivers/event/octeontx/meson.build | 5 +++++ > ...octeontx_ssovf_version.map => rte_pmd_octeontx_event_version.map} | 0 > drivers/meson.build | 2 +- > 4 files changed, 7 insertions(+), 2 deletions(-) > create mode 100644 drivers/event/octeontx/meson.build > rename drivers/event/octeontx/{rte_pmd_octeontx_ssovf_version.map => rte_pmd_octeontx_event_version.map} (100%) > > diff --git a/drivers/event/meson.build b/drivers/event/meson.build > index 437d80bfd..d7bc48545 100644 > --- a/drivers/event/meson.build > +++ b/drivers/event/meson.build > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > -drivers = ['skeleton', 'sw'] > +drivers = ['skeleton', 'sw', 'octeontx'] > std_deps = ['eventdev', 'kvargs'] > config_flag_fmt = 'RTE_LIBRTE_@0@_EVENTDEV_PMD' > driver_name_fmt = 'rte_pmd_@0@_event' > diff --git a/drivers/event/octeontx/meson.build b/drivers/event/octeontx/meson.build > new file mode 100644 > index 000000000..fa46a67b5 > --- /dev/null > +++ b/drivers/event/octeontx/meson.build > @@ -0,0 +1,5 @@ > +sources = files('ssovf_evdev.c', > + 'ssovf_worker.c' > +) > + > +deps += ['mempool_octeontx', 'bus_vdev', 'pmd_octeontx'] > diff --git a/drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map b/drivers/event/octeontx/rte_pmd_octeontx_event_version.map > similarity index 100% > rename from drivers/event/octeontx/rte_pmd_octeontx_ssovf_version.map > rename to drivers/event/octeontx/rte_pmd_octeontx_event_version.map > diff --git a/drivers/meson.build b/drivers/meson.build > index f5009aa2e..52d7176a3 100644 > --- a/drivers/meson.build > +++ b/drivers/meson.build > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright(c) 2017 Intel Corporation > > -driver_classes = ['bus', 'crypto', 'event', 'mempool', 'net'] > +driver_classes = ['bus', 'crypto', 'mempool', 'net', 'event'] This change is ok with me, but I think you need to add an explicit comment in the file - not just in the comment message - as to why the order is not alphabetical. In fact, it might be good to split out each type on it's own line with a comment, since bus should almost certainly go first, then probably mempool - since we might have crypto drivers in future that depend on it, and then finally the other types. > > foreach class:driver_classes > drivers = [] > -- > 2.15.1 >