From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0861D1B1BB for ; Tue, 9 Jan 2018 18:41:27 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 09:41:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,336,1511856000"; d="scan'208";a="191980352" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by orsmga005.jf.intel.com with SMTP; 09 Jan 2018 09:41:24 -0800 Received: by (sSMTP sendmail emulation); Tue, 09 Jan 2018 17:41:23 +0000 Date: Tue, 9 Jan 2018 17:41:23 +0000 From: Bruce Richardson To: Pavan Nikhilesh Cc: bluca@debian.org, harry.van.haaren@intel.com, jerin.jacob@caviumnetworks.com, dev@dpdk.org Message-ID: <20180109174123.GD6508@bricha3-MOBL3.ger.corp.intel.com> References: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171231000203.4510-1-pbhagavatula@caviumnetworks.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver to meson build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 17:41:28 -0000 On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote: > Add octeontx hardware mempool driver to meson build. > > Signed-off-by: Pavan Nikhilesh > --- On the set as a whole, it looks good to me, just the few minor nits pointed out in other emails. Can you do a V2 with those fixed? Also, I notice that you are missing License tags on the new files created, those should probably be added too in V2. Thanks, /Bruce