From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65])
 by dpdk.org (Postfix) with ESMTP id 4AB8E1B1D9
 for <dev@dpdk.org>; Wed, 10 Jan 2018 18:17:37 +0100 (CET)
Received: by mail-pg0-f65.google.com with SMTP id q67so11307857pga.9
 for <dev@dpdk.org>; Wed, 10 Jan 2018 09:17:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=QpSJVCWlvTl/E/G6cE45UwJU1NFzC9jHvis181bdXuE=;
 b=l911IwRQHGtWG/Zm5zLTZwkVVg7oT3sLvy6pRlkuUoPvjTvJHtFwBOlcgZFfEp82jz
 TQFlS0qpdwzl8Ec/27lGuivcm1tyUoYxIttMm9GC6RA6WFdwhqJfhMOT3laQqcM0kIZV
 hkBVgt3fePlEsG11idTsMNPVb+Dzwqn0XyFBUcak84vT6Ac7RSgl+VKUqZeqAd32pkOG
 hSgtqiCyZWY8YQ5LZRo8R07MD05KjO2DzZSWnUd6yHXj66Ac0p7TKHGbRnbm8TYKZsxb
 3My7kr4QUj0Gl8pjsbmQMe4rk9wjTTzO9JBIrfd1row8JVt4g5fHwsl4Y6KzzcKwrqRq
 mO5Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=QpSJVCWlvTl/E/G6cE45UwJU1NFzC9jHvis181bdXuE=;
 b=gHeLWibfuhbHAAHCweWKkBHeRYl9OJaHZJXZC/+NlJ6soOyB+woLVQZFc0wpWW4gFB
 44ypGuVi6sHK+fxxrq7rd98IRHvPu5FT9DNbM0Anj1JSHaYlNnxG/gRPRXsBrWnscDJQ
 ELKsVF1n9f3Kb4kL3orngsBHp3KiPFQ04/7sYFI0Ufp438Zm3oIC8YoF5gFhfpBZn4LP
 gnNUQVgqUCx1VhmxEM4vs1DnMTBB4C/filpmoGFxA4pwgCpFkpjs0vHRwQxHSmB7/rG+
 a1IY+fYWqdY4Fhgg/T8JjIC+Uoo1ByQGtWUjtTIHRVzGQGkdu4r/0DoP6uhiSJzFyGPG
 AdRA==
X-Gm-Message-State: AKGB3mJODm+W9oEVU4qrjufgXRy4f3k20MebT7Un7lna6tCZjXqzgiKL
 NVHtmbKnviSu0VLcXbpY5/f+/w==
X-Google-Smtp-Source: ACJfBosHZvnU551IPSPi8xwqgtRCEdEDppXqXP26HK9+1jBCC4ZGg65fghn45WwyoovIqbUzio8/Hw==
X-Received: by 10.99.183.7 with SMTP id t7mr15849173pgf.111.1515604656424;
 Wed, 10 Jan 2018 09:17:36 -0800 (PST)
Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133])
 by smtp.gmail.com with ESMTPSA id e9sm31010872pgc.15.2018.01.10.09.17.36
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 10 Jan 2018 09:17:36 -0800 (PST)
Date: Wed, 10 Jan 2018 09:17:33 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: dev@dpdk.org, Jingjing Wu <jingjing.wu@intel.com>
Message-ID: <20180110091733.229a39ad@xeon-e3>
In-Reply-To: <1515564961-79227-3-git-send-email-wenzhuo.lu@intel.com>
References: <1515388414-16214-1-git-send-email-wenzhuo.lu@intel.com>
 <1515564961-79227-1-git-send-email-wenzhuo.lu@intel.com>
 <1515564961-79227-3-git-send-email-wenzhuo.lu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v6 02/14] net/avf: initialization of avf PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Jan 2018 17:17:37 -0000

On Wed, 10 Jan 2018 14:15:49 +0800
Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:

> +/* spinlock func for base code */
> +void
> +avf_init_spinlock_d(struct avf_spinlock *sp)
> +{
> +	rte_spinlock_init(&sp->spinlock);
> +}
> +
> +void
> +avf_acquire_spinlock_d(struct avf_spinlock *sp)
> +{
> +	rte_spinlock_lock(&sp->spinlock);
> +}
> +
> +void
> +avf_release_spinlock_d(struct avf_spinlock *sp)
> +{
> +	rte_spinlock_unlock(&sp->spinlock);
> +}
> +
> +void
> +avf_destroy_spinlock_d(__rte_unused struct avf_spinlock *sp)
> +{
> +}

You might want to inline these (in a header file) if in critical path.