From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A56081B20D for ; Wed, 10 Jan 2018 11:23:46 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 02:23:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,339,1511856000"; d="scan'208";a="192325841" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77]) by orsmga005.jf.intel.com with SMTP; 10 Jan 2018 02:23:42 -0800 Received: by (sSMTP sendmail emulation); Wed, 10 Jan 2018 10:23:42 +0000 Date: Wed, 10 Jan 2018 10:23:41 +0000 From: Bruce Richardson To: Andrew Rybchenko Cc: Ferruh Yigit , dev@dpdk.org, Hemant Agrawal Message-ID: <20180110102341.GC6388@bricha3-MOBL3.ger.corp.intel.com> References: <1515418535-16575-1-git-send-email-arybchenko@solarflare.com> <8ed3ce78-9bcd-0fa5-0715-4141d9d8550f@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ed3ce78-9bcd-0fa5-0715-4141d9d8550f@solarflare.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.1 (2017-09-22) Subject: Re: [dpdk-dev] [PATCH 1/2] net/sfc/base: change license to BSD-3-Clause X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 10:23:47 -0000 On Tue, Jan 09, 2018 at 10:59:40PM +0300, Andrew Rybchenko wrote: > On 01/09/2018 10:38 PM, Ferruh Yigit wrote: > > On 1/8/2018 1:35 PM, Andrew Rybchenko wrote: > > > Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause. > > > Bump copyright year. > > > > > <...> > > > > > @@ -1,28 +1,8 @@ > > > + SPDX-License-Identifier: BSD-3-Clause > > > - Copyright (c) 2006-2016 Solarflare Communications Inc. > > > + Copyright (c) 2006-2018 Solarflare Communications Inc. > > > All rights reserved. > > Defined syntax has no empty line between SPDX and Copyright line, is that line > > intentionally left? > > Yes. I've seen examples, but have not found exact requirement to have > no empty line. We have file with 2 copyright holders and it looks strange > in this case without empty line. > As far as I know, the format for headers is fully spec'ed, except that it is optional to have blank line after the SPDX tag. Either is allowed, and it's not likely to have major scripting implications. I think most of us prefer to not have the line, but it's not prohibited. /Bruce