[dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure

[dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure

[Zhiyong Yang]

When binding X710 NIC (i40e driver) to DPDK, vhost sample startups
failure.
The sample requires that MAX_QUEUES should be defined no less than 320.
So, the patch redefines MAX_QUEUES 320 to fix the issue.

Cc: stable@dpdk.org
Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---
 examples/vhost/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 89a61f0e5..487cc530e 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -57,7 +57,7 @@
 #include "main.h"
 
 #ifndef MAX_QUEUES
-#define MAX_QUEUES 128
+#define MAX_QUEUES 320
 #endif
 
 /* the maximum number of external ports supported */
-- 
2.13.3

Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure

[Yuanhan Liu]

On Thu, Jan 04, 2018 at 02:33:32PM +0800, Zhiyong Yang wrote:
> When binding X710 NIC (i40e driver) to DPDK, vhost sample startups
> failure.
> The sample requires that MAX_QUEUES should be defined no less than 320.
> So, the patch redefines MAX_QUEUES 320 to fix the issue.

It just makes the issue disappear. It doesn't really fix the issue.
And I belive we have tried to fix this kind of issues in this way
many times. (just check the git history). As you known, none of them
really worked. You just added one more try, which is very likely
will be broken again when Intel has one more new NIC.

The error comes from:

        if (dev_info.max_rx_queues > MAX_QUEUES) {
                rte_exit(EXIT_FAILURE,
                        "please define MAX_QUEUES no less than %u in %s\n",
                        dev_info.max_rx_queues, __FILE__);
        }

I think such check is overkill and we don't really need that. Could
you just remove such check and do some validations on few difference
nics?

Thanks.

	--yliu

Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES to resolve startup failure

[Yang, Zhiyong]

Yuanhan,

> -----Original Message-----
> From: Yuanhan Liu [mailto:yliu@fridaylinux.org]
> Sent: Tuesday, January 9, 2018 9:24 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/vhost: fix extend MAX_QUEUES
> to resolve startup failure
> 
> On Thu, Jan 04, 2018 at 02:33:32PM +0800, Zhiyong Yang wrote:
> > When binding X710 NIC (i40e driver) to DPDK, vhost sample startups
> > failure.
> > The sample requires that MAX_QUEUES should be defined no less than 320.
> > So, the patch redefines MAX_QUEUES 320 to fix the issue.
> 
> It just makes the issue disappear. It doesn't really fix the issue.
> And I belive we have tried to fix this kind of issues in this way many times.
> (just check the git history). As you known, none of them really worked. You
> just added one more try, which is very likely will be broken again when Intel
> has one more new NIC.
> 
> The error comes from:
> 
>         if (dev_info.max_rx_queues > MAX_QUEUES) {
>                 rte_exit(EXIT_FAILURE,
>                         "please define MAX_QUEUES no less than %u in %s\n",
>                         dev_info.max_rx_queues, __FILE__);
>         }
> 
> I think such check is overkill and we don't really need that. Could you just
> remove such check and do some validations on few difference nics?
> 

Agreed, Such check doesn't help anything, Let me send V2 to remove it if nothing  can be affected.

Thanks
Zhiyong

> Thanks.
> 
> 	--yliu

[dpdk-dev] [PATCH v2] examples/vhost: fix remove dev_info.max_rx_queues checking to solve startup failure

[Zhiyong Yang]

For vhost sample, the operation if (dev_info.max_rx_queues >
MAX_QUEUES) in the function port_init causes startup failure
when using X710(i40e driver). X710 requires that MAX_QUEUES
should be defined no less than 320, however it is defined as
128 currently.

Such checking is overkill and Removal don't affect any
functionality (have already validated ixgbe and i40e).

The removal can avoid similar issue when introduing new physical
NIC.

Fixes: 8bd6c395a568("examples/vhost: increase maximum queue number")
Cc: stable@dpdk.org

Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
---

Changes in V2:
1. Remove the checking instead of redefine macro "MAX_QUEUES"

 examples/vhost/main.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 10a7f5d32..1f532fe3b 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -279,12 +279,6 @@ port_init(uint16_t port)
 	/* The max pool number from dev_info will be used to validate the pool number specified in cmd line */
 	rte_eth_dev_info_get (port, &dev_info);
 
-	if (dev_info.max_rx_queues > MAX_QUEUES) {
-		rte_exit(EXIT_FAILURE,
-			"please define MAX_QUEUES no less than %u in %s\n",
-			dev_info.max_rx_queues, __FILE__);
-	}
-
 	rxconf = &dev_info.default_rxconf;
 	txconf = &dev_info.default_txconf;
 	rxconf->rx_drop_en = 1;
-- 
2.13.3

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix remove dev_info.max_rx_queues checking to solve startup failure

[Yuanhan Liu]

On Wed, Jan 10, 2018 at 02:01:01PM +0800, Zhiyong Yang wrote:
> For vhost sample, the operation if (dev_info.max_rx_queues >
> MAX_QUEUES) in the function port_init causes startup failure
> when using X710(i40e driver). X710 requires that MAX_QUEUES
> should be defined no less than 320, however it is defined as
> 128 currently.
> 
> Such checking is overkill and Removal don't affect any
> functionality (have already validated ixgbe and i40e).
> 
> The removal can avoid similar issue when introduing new physical
> NIC.
> 
> Fixes: 8bd6c395a568("examples/vhost: increase maximum queue number")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu