From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: Gage Eads <gage.eads@intel.com>,
harry.van.haaren@intel.com, santosh.shukla@caviumnetworks.com,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] event/sw: remove stale IQ references when reconfigured
Date: Thu, 11 Jan 2018 00:30:07 +0530 [thread overview]
Message-ID: <20180110190006.GA32568@jerin> (raw)
In-Reply-To: <20180110102615.42jh4hkprgombzki@Pavan-LT>
-----Original Message-----
> Date: Wed, 10 Jan 2018 15:56:16 +0530
> From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> To: Gage Eads <gage.eads@intel.com>, jerin.jacob@caviumnetworks.com,
> harry.van.haaren@intel.com, santosh.shukla@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: Re: [PATCH] event/sw: remove stale IQ references when reconfigured
> User-Agent: NeoMutt/20170609 (1.8.3)
>
> On Tue, Jan 09, 2018 at 10:19:35AM -0600, Gage Eads wrote:
> > This commit fixes a bug in which, when the sw PMD is reconfigured, it would
> > leave stale IQ chunk pointers in each queue's IQ structure. Now, the PMD
> > initializes all IQs at eventdev start time and releases all IQ chunk
> > pointers at eventdev stop time (which has the consequence that any events
> > in a queue when the eventdev is stopped will be lost). This approach should
> > be resilient to any reconfiguration done between the stop and start, such
> > as adding or removing queues.
> >
> > This commit also fixes two potential issues in iq_chunk.h. iq_init()
> > now initializes the IQ's count field to 0, and iq_dequeue_burst() sets
> > iq->head to the appropriate next pointer.
> >
> > Fixes: 5b5e476e59a4 ("event/sw: use dynamically-sized IQs")
> > Signed-off-by: Gage Eads <gage.eads@intel.com>
> Sw eventdev works well alongside Rx adapter now.
>
> Cheers,
> Pavan.
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Applied to dpdk-next-eventdev/master. Thanks.
prev parent reply other threads:[~2018-01-10 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 16:19 Gage Eads
2018-01-09 17:29 ` Van Haaren, Harry
2018-01-10 10:26 ` Pavan Nikhilesh
2018-01-10 19:00 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110190006.GA32568@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).