From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0046.outbound.protection.outlook.com [104.47.32.46]) by dpdk.org (Postfix) with ESMTP id 342FE1B24A for ; Wed, 10 Jan 2018 20:00:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VJy39yoOKgoQuBVIEa0A+cKUVcRLxkF4TRZ6nig6ktw=; b=ZY4JvgPlpb7mcytIBxpjUZIzCikPW+yfQZu+W13hczZS9Jv99iwOeJxfN750KhU49JJYbmbfDN5hE2T2R4By07+umqGAl3p7cGEJ1xGUlna9jFAugO7CXwIDcMFow1WxjsgPPy5wIBJzhc6ZTewmq45KFN/F/nuHxD9F4H6zQVo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.61.92.144) by CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 19:00:26 +0000 Date: Thu, 11 Jan 2018 00:30:07 +0530 From: Jerin Jacob To: Pavan Nikhilesh Cc: Gage Eads , harry.van.haaren@intel.com, santosh.shukla@caviumnetworks.com, dev@dpdk.org Message-ID: <20180110190006.GA32568@jerin> References: <1515514775-10859-1-git-send-email-gage.eads@intel.com> <20180110102615.42jh4hkprgombzki@Pavan-LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180110102615.42jh4hkprgombzki@Pavan-LT> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [171.61.92.144] X-ClientProxiedBy: BM1PR01CA0079.INDPRD01.PROD.OUTLOOK.COM (10.174.208.147) To CY1PR07MB2522.namprd07.prod.outlook.com (10.167.16.13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4755b26c-1476-47f0-4da1-08d5585c6a19 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CY1PR07MB2522; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 3:Dj7f03RJD3cQcIa+FMabe3sFlAfGFStsDw4jzYhjGJ00xk1yibBLG+Sd6gZM+8hpfL87ICDeECxXRJCxuuqNbiQ3tQbJh5WuoWNbOedppXPAt2SgSb7gdK+Z++eeZPyNom54WJPn7vgTp0qE5ryHlcqGRQ1GYfswFm0B+HvaxJTd02TN9ssyJr+Ilz2mm/WuUzxJIdOaFmX9A5SZ2oMJeq8f6z67xF4hfxCp+lWi3rWfutl3AG5NJhV6MDP/PYtE; 25:7AWLQe/L7tXlfLcu8oh61o1if8DCEVMnlF0K7khefDKTIpzGD3/lF2qg56mEOimsQEtTReLy2gLca12HISaPeYrGm7m07wawRr0drpEivZm1V+yt9OgrTaUNN9lYXVOkKZ26n9tP03IVMfov8ZlcCzyKPIx7/xXrK1hT1AvQ5AYmB44CfwxY9oxJ2KiZcHFMexBmQq6o6TMyWGqNqgoMknHO6LGtVdtdvb8oJv0L7Pg5N2Z1y++PULIUhI+GoCjA5fI5LJ1Sj7u+bdWTj0OSdqpEIOfT19xNQBvn3TUkiarb7hceKe/bsSh/tpX2af/7DNs5WDjuNIDPxk/zOWpi2w==; 31:tUiVkdqUjIIJkhZIcyTUS1KKCC37lQQ5cpxZkpeAjtVWf1NTAYgGQtnWulMUbQoHXmdXUp1odIu+zioJmN4FjccUA3K5vkvlF657eXhW6lJk7KmlhCmNdqreUay67E1TcLPqXiYzym7MCs+Ailk4LL4tjrBKL5IUk2WOJsINrmakqM4EHj/OwFbEmm/4mMUV09ejKWWvMIYCjKU3nFJJjRWLlIoNaYR2lpFG0j6MIto= X-MS-TrafficTypeDiagnostic: CY1PR07MB2522: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 20:mPu9oNlJN7Zex/Ck427bypFyIpJqRUu4exPymevHxa1h1iWCsVIcn/RFjdJL6pJewaMJ9Zv8hNfzESTNXpSwFrCPi+famQDnvhEF//SzAd+tn2VGl//x2sTLJsaNrWu0ng0CH6XqIpOheFUBcKHEyBHpUikFQ86udNaPtHtnSKF/HtRIV15DtQxhrQs676ihveKeW7rf/PSsPfhWsQW+5+zhYxzL8tUhHJVk9Dz6v01fG3jckb5txKuKdgmd7RJ+BbFnbkJd2t1SrMjw6Y2BYRCmMMpUcYIaudgRJpusLfxYvVo4YVYKBlXRLWQg2/mVhGHK4mO8z/RG4PAkxxzxoSoTRWyoSm99Nb7eX4YBAZe4V4F0fukeJT35XyMEcOQHVigVBcIOSpdPc6KahgRopvuspIZnBlg+96tdiHWVSbNgLAegG+fhxsBqqOyK/HF70zfhug/zeFTPAvNAyfoNuVCVt8fpERl/Mb32rowgbzXL7TzFMDXlqkaKUb38p5zgPe+QYKsXxvncm3khm2nJsb8EnqQIQ7m2WR7nCvhagnDB+eqmpTBz97SnYsHF5Vsm5EEElM+apGMrWGpvLboIGy9XvHr8dY4pSZiIyCfxfQA=; 4:TfP3aPGdHY7zhzNajoj4L00oCrg+o/QXI/rYTVI6I5H6JTwBzY8yuZpT+Jhb0b68MweBPo5wDU2joxL3h8m2jTS7s5rcpgurnm33mivBlIwVe19jUJjPa777NhP703joqhCX5chq0eW1rVnAEUFq+Ymy1TDLsaFmI4cgBfwRuJcPX/UhUTX304QUHleoidJ2o0+5hqGHMZIrJI3J60BMAvm4hVJXz8KLPTbKSTKtc9KVCisofLZEc8YWbEN1k5X0/XbrqmMl/XmoDjqcX5UdEHXrGsUjKCMSfYRdx9QHYKnBjNU/056OVvZy9zof8N8m X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(93006095)(10201501046)(3002001)(3231023)(944501075)(6041268)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:CY1PR07MB2522; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR07MB2522; X-Forefront-PRVS: 0548586081 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(396003)(39380400002)(39860400002)(346002)(376002)(13464003)(189003)(199004)(24454002)(9686003)(305945005)(42882006)(47776003)(2950100002)(52116002)(16586007)(7736002)(6666003)(50466002)(33896004)(6636002)(72206003)(76176011)(16526018)(6496006)(33656002)(5660300001)(55016002)(386003)(58126008)(97736004)(53936002)(25786009)(33716001)(4326008)(68736007)(478600001)(316002)(106356001)(2906002)(23726003)(8676002)(6246003)(229853002)(6862004)(83506002)(6116002)(81166006)(81156014)(3846002)(105586002)(1076002)(8936002)(66066001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2522; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2522; 23:ezhxxSE0D2l8dDZc+eljK+AqGdP9ghha+K3f+YvxB?= =?us-ascii?Q?iE+27n9nQ7HgX3YbL+nlZUPYiggzsV52sP0/kPh1gviJ8ZTiY2tp4eK7Fwji?= =?us-ascii?Q?wMmF9YyE5S65MAFsvSa637/aF+MAsfSSOdwG7mWAiyBkqWGAs02w7gkmZWnc?= =?us-ascii?Q?Y6ItVTuBuXenEURzcnh2TZlirbND2EZp0wk7wr5XBd146nkRRbzW4R4QWGp0?= =?us-ascii?Q?6EoXcBKEckXvNChPA0sUd2EksA6KyN14ZkTtb2sW0iKTNBqTMl2O3fyWD1ZJ?= =?us-ascii?Q?0P5ZyV+7iiz2hjCQI/GfPHH/9dhVzoNflzA4+2xPQ41p0ef4gIbPuOKMIAJA?= =?us-ascii?Q?SGBWc8/2i3aOY8Wu1+Wm+Rmjovn2ZBVaPLzu2Ajj2dlRZdXK8agRQj0R8hyD?= =?us-ascii?Q?R8gTxcnznWlFOmNvlItvsLFMoZUBYOS1NawHOtZ9e/A6fmkWGg0stsyQ1gqf?= =?us-ascii?Q?jF/3aQ+CzgkaR/Y+6Ile81OlEMHedNFgdqCh9EJN68wXcoF+gxgjN12AyW9F?= =?us-ascii?Q?C93ixy3F1rcyDZD/cjxsT46LtGCr4VKj9svS8jBfDJxbOieKQSqE3dLV//BT?= =?us-ascii?Q?yHzSwlEPZmm+BTHgZVBESgjknucDKwMdrgPRO8WxID1W0Ux1jlTlcb6/OHdt?= =?us-ascii?Q?XHmxG52ZbroWBbQ75VnNB2Wl8nmeH1mkchYG/RS6TTMdPclFS7O1o2VG/5VR?= =?us-ascii?Q?2A6NaO1w4oISOfMkxzwnscJNXzOMZtYYu9+xoqep92ipeQYd3mrx5B3lHPPX?= =?us-ascii?Q?NYQQHCw71PSrkJgEy+0GLjFeaY0oYXvJKmxnogi5TWBs8yHbnDetcZh7x4Fa?= =?us-ascii?Q?tgs8Ehomdr3BSIyQALOaEDT6MYTI+CqSp/vIRmhoyW6WMPSr8BwpVuqnJ8AU?= =?us-ascii?Q?dpWInVCRmWk/qhxW3e5FlHU/MlrRQlBF3Igyygsk1esgoJNwEFXBXpRaZf2C?= =?us-ascii?Q?L7ezq7nlMsFlgzU+7yP3ijsOSYXrcivq5DT2pf2PbEXW8U6F8YqUfDoGYPaQ?= =?us-ascii?Q?l1pTba/X8/0lfD2PXB8JjdNfJenjBWNceodj/EwWW0wQyqbm6M3ZOvloMPsC?= =?us-ascii?Q?hikoMJVVExKjKQqBjaYT4yxHR57yD+nAmFxriKLfisl+QgLrXJ+3f7PcUpic?= =?us-ascii?Q?WRNL8BrFDO/LipXuZghjencJh0HNOGVFYMimHUKksSvRLPI/K4L6lS3Hcw6F?= =?us-ascii?Q?0r+S9k+nzNIztXQRrSTiTg7QSktkJaWcYEBtm1A1j7BBHHd3NPC4Rrevddpz?= =?us-ascii?Q?QvwMuQkEh5wBl1//OdP6EW25QPzgbjtSIwJqOOBuiYzjD4wdBJZgZYE7scPP?= =?us-ascii?B?UT09?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2522; 6:PjnAso2ouUAoFusB6kcan2uX/Mq+gKcAv+1D+byv0Zn0/VlFRP68QyBu7DcOSJqSvfcIo96ULsNzRbhiP5VV7Q3LdM1ZK8ucqMoYBJgXlSZvfPShfknIl6Q3yu0+bGovTN0RQueyaqNw4nYMHtQBOch9Df0Bdf6Qea0A5LMOzQslG5kwvj3NuqutwXQyuu4dRxEZCiEZUs8SXNOZjS6Kd0ioNBtaEiVKGfIrohKMAC+EiZIWgn1kT7HeW5rn99Ot2H/NN7VQhQGHNPo3GuupnRg4svwYXsA3PK2ztj0GmHSNGU26jQRJXdFfWZTVB0m+S0Izq3Zs3lHWfxgEqmgU/c/3R2a2gGdVJGgmYSV1obU=; 5:vIgJcKLhyasfe1IKE9TIpSUHFCjf1BIIhNVpUE39hPvVt7qb1m0IQ3bM5lc2fq9Lx6PBUDCdHO2/lC6YHMplbDgCpOQHERZUpYI/NwnzjtGQTFTmXa/vpZZVoOd/qhB43g9dndvks00AuVR3VI2adJ7yjna3JwF60FN1QB62GUw=; 24:qhLYX/uhf4nDe/YCwRvL9UaBehzj2sWJSrmWEC7yLGSsCBLct2pvm1aa2+opGdB86otqm8OmFuwKyj2S4jWK+C/foZfO+gLC1QLSNa+uma8=; 7:PzGxtnCrQQIF66q5UQp5MqvK6Q4qM/L0F031CExda6tp9cfIVPq/5KFeTrnSaRBjLTIEbAigvI+UAgf9FsWrsoYDmZGg8cjfbBi6K6Qj/OUB8p38R34blVSsi8hJZloai1npIvRbBifiqpby6UgCgWtY22X2qcT5r8t8P1s6GQePOuitnqd/ydCKHZyWZ7KpVjo6Ia86N/G00hMTK8J2DHOP0gutru0rGeDStDLakqsaxTfiyjBpTpGU5G8eUmra SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 19:00:26.0728 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4755b26c-1476-47f0-4da1-08d5585c6a19 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2522 Subject: Re: [dpdk-dev] [PATCH] event/sw: remove stale IQ references when reconfigured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 19:00:30 -0000 -----Original Message----- > Date: Wed, 10 Jan 2018 15:56:16 +0530 > From: Pavan Nikhilesh > To: Gage Eads , jerin.jacob@caviumnetworks.com, > harry.van.haaren@intel.com, santosh.shukla@caviumnetworks.com > Cc: dev@dpdk.org > Subject: Re: [PATCH] event/sw: remove stale IQ references when reconfigured > User-Agent: NeoMutt/20170609 (1.8.3) > > On Tue, Jan 09, 2018 at 10:19:35AM -0600, Gage Eads wrote: > > This commit fixes a bug in which, when the sw PMD is reconfigured, it would > > leave stale IQ chunk pointers in each queue's IQ structure. Now, the PMD > > initializes all IQs at eventdev start time and releases all IQ chunk > > pointers at eventdev stop time (which has the consequence that any events > > in a queue when the eventdev is stopped will be lost). This approach should > > be resilient to any reconfiguration done between the stop and start, such > > as adding or removing queues. > > > > This commit also fixes two potential issues in iq_chunk.h. iq_init() > > now initializes the IQ's count field to 0, and iq_dequeue_burst() sets > > iq->head to the appropriate next pointer. > > > > Fixes: 5b5e476e59a4 ("event/sw: use dynamically-sized IQs") > > Signed-off-by: Gage Eads > Sw eventdev works well alongside Rx adapter now. > > Cheers, > Pavan. > > Acked-by: Pavan Nikhilesh Applied to dpdk-next-eventdev/master. Thanks.