From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0065.outbound.protection.outlook.com [104.47.38.65]) by dpdk.org (Postfix) with ESMTP id 5FA3B1B1C7 for ; Wed, 10 Jan 2018 20:17:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=06qMpxW1DxSWkKfBbcn1JfedpH3gB8OQs3RkX3/cgXw=; b=jaczYNBcL+TQirx0tsFVPTcyvtlK0ULEszJUichGbyko0BlwfGc4RZoHBUiU28sqv+jYHi/UA4PFNSV0M2bbCEggITxXaUcyaCQKtUFH/BQLUm7p1hoz3I9fuv2AWB+kR5JmYyF4ikKIveLZSwxC3UU2NIjIZP7ZXro6AlyuJNY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.61.92.144) by CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Wed, 10 Jan 2018 19:17:18 +0000 Date: Thu, 11 Jan 2018 00:46:59 +0530 From: Jerin Jacob To: Pavan Nikhilesh Bhagavatula Cc: "Ananyev, Konstantin" , "santosh.shukla@caviumnetworks.com" , "Richardson, Bruce" , "Van Haaren, Harry" , "Eads, Gage" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Ma, Liang J" , dev@dpdk.org, thomas@monjalon.net Message-ID: <20180110191658.GB28342@jerin> References: <20171212192713.17620-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-1-pbhagavatula@caviumnetworks.com> <20171214150138.25667-2-pbhagavatula@caviumnetworks.com> <2601191342CEEE43887BDE71AB9772585FAC9A88@irsmsx105.ger.corp.intel.com> <20171215090445.huivudbztoxknb3j@Pavan-LT> <2601191342CEEE43887BDE71AB9772585FAC9DFF@irsmsx105.ger.corp.intel.com> <20171215113241.donmary6yesyssle@Pavan-LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171215113241.donmary6yesyssle@Pavan-LT> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [171.61.92.144] X-ClientProxiedBy: BM1PR0101CA0009.INDPRD01.PROD.OUTLOOK.COM (10.174.220.19) To CY1PR07MB2521.namprd07.prod.outlook.com (10.167.16.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 865b6d9a-91ea-4ce6-ca5e-08d5585ec6cc X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 3:+kJUX+33eckucby8B5+ubDGyVupQQIgPOxd4mwkpjPgiSvfL5254TeEunuv6jOKWkl7lW3KwU/iUYPOFeqQcmAGRW0qKLdQykz1EN0zmQzkj7ka1mBbQ2D4VUE+bLfWzEak9TslymFqy0/iyx5lCICOZgN4eQYqhc4S2w9bUbqMHJc8fcRN0xxSlxZoVvQC2FRuZHizlC1ce0JdY8n0rp/PbcqJzXKrQhw5iwtboArpYDU4ZkBEBV+eg8wKYe2xR; 25:Yw3XdrZWmS8jjAAiBx2yeUj27ayMPfdctY8aVPNt5CI1sbT6DKUENdAWBh01m9JwwzQEQS4011SGzh6PPV/JVAA/veF9jnNV0xG7duRSN0zL5PouJLdJnr3+vBtb8t2yUzeOvtjbV7ANsxbaLu2nCl6XEDG+5pMmhoEqxHxZCg1bd/EjZdb09ev3fEiZAatx4MZ34lUEpv7o++67KhhQmHioMN472ZPFkulc376JDXRApNiGvJcPKWMB7P9SRxPX8uwLyoT0NNn/fcNF7g/LtKcKXJG1/Lundyigs1E92JogECR53OR95jJQsXWbQRbleyYdEHaDNAysMoDK9A9fDg==; 31:i77YBjfwC7afS96JiqL+JagoitovmoC259m5AtpZodAOtZutppGuMhYiDzZTSf/3N7NUZZQ1+l7VzoO+AnFEkV40QlDFsUyVSJyfDMFC+xnoHnxDJI82RToee4nAb+qO1E4bWG0NaU2AvucS65Jus7smLzKOP7IXp0ED/+XqPdTqrAw2bMukkrQg/DzEzm+TT5VuB+cZhTncRIKg76h9O/sWM8DX6Z8veeQkebMYJp0= X-MS-TrafficTypeDiagnostic: CY1PR07MB2521: X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 20:lpKp1D+WcuIsGPMRzfez1AQbY4sB7IQQDcWXF1AeI4EmryLs/SDLOAIfiCMQRG41D7S3tqkIRqmp2jGIyY9ZmpawqZplxD6t5vUjP4kg5oWtvWwBHZ2b9POGStBfL14eS7jIDD7K0kfnUr2A0zIQDLW0HqwfrW2+/DfeLxxuJLUSHooLnH8puI33Zgwskt5cSqqgMODZxnNdl2GFCpQtcVQdPJa5wLGq/UTCLGNU+VmDErJRZwhdKMXcV4IvoaZmsMe5sQjclZQm0Ph71c4XtSy7V+VuYLzG6mLczYtWmtBwlLJe4aK5WEk9qP4cr5amnjA0MqT0kjZq5p3Y4Vv9NTJ2pnfrwWBfVpTSLW2AK1eDDTZDJkMUE5Y+h0hmQhmjnxzi/7tzy5cUyPGwD8H0jWOg9uMsqRRHcz/FHvni+VJjqey+JlhPewvwRRwOSK3JaXTwBtgK7zhp4Vfpq36wjVjIQPY6oqwZ7o+3lE2f86Ja27k+Wlx8IQ3DSuU/2lGk0XsEezIwsCJW+JoMSsOXt7W0kyzI6zIHiUhZKd97p2Zn7Tkl09/fJZYrkyiXTQXqoIwW+DuO6P+bEIWp5uu7ZRXkg20s74reIRNpvtvr1kY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(944501075)(3002001)(93006095)(10201501046)(6041268)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:CY1PR07MB2521; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR07MB2521; X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 4:CykKzKQ1PJBzVL1nspwzLPgs3ljc2+xSG5VzrzmdFZucWPU7ePK/AG72/Fokr5HeFgGUplQXm4byr7VrFXzUOeoVnpIVsm9LMJv1zdjU9nDjz/wpdZSZwk+7urEfr566AoNTBTaX+cnn5QiNAC2Np7pgRJptyDaNlka9YFiQc7MoE2hxzs7epN/O+DcUFu1BwP7XLR5qhWLfJwexptXWiPUvZp9IERlLohEVr/gh1vCW37GqlcU+LUAbbZfl6JLfbxLHK1LD5Th0H8wYhNrZRarpRFEyqNfK8fX4TNfZmB9mXS9GxxUwWXScj339HA0isy7EohxWAcNj7XJd4PntxTKgPjobMdmFkRxBdwQrVqg= X-Forefront-PRVS: 0548586081 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(396003)(39380400002)(366004)(346002)(24454002)(189003)(199004)(13464003)(6862004)(966005)(58126008)(229853002)(81156014)(54906003)(316002)(81166006)(72206003)(8936002)(8676002)(4326008)(5660300001)(2906002)(68736007)(3846002)(33716001)(23726003)(16526018)(6116002)(16586007)(97736004)(6306002)(53936002)(1076002)(305945005)(76176011)(66066001)(83506002)(106356001)(33656002)(53376002)(55016002)(52116002)(7736002)(386003)(478600001)(59450400001)(50466002)(33896004)(6246003)(2950100002)(47776003)(6636002)(93886005)(105586002)(6496006)(42882006)(8656006)(25786009)(9686003)(53546011)(6666003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR07MB2521; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR07MB2521; 23:cioI8V75sJ1NijX4EP3fWjcFmgLPJM9+cUXu7fO7f?= =?us-ascii?Q?U0HxphITBl5/vVgG9ZnhdNosem2okDrwxbHFZVMyJCoSd7TV2rXVP6TT/4aV?= =?us-ascii?Q?Ll1U6JOvejTOxwrrWvG6+col3psQH0Kp5rgLtPW4NJRGVXisgls7nJIFr160?= =?us-ascii?Q?nEavFn6np+rSayYnlyUaaNLuWHpg0nt35UyV9gbXDuMoCogDC1bu0nnmOnGI?= =?us-ascii?Q?sQloiLook2q87JmkoSXUziLko4R82Ngl95CrKs41o8d/Nnn8jd3NGY5lQfRU?= =?us-ascii?Q?dSLYPInbvcPbil2rGlFbvOsILU3a9WqOSeMsC+CFsly0V3q1FLsCMyG1/bIy?= =?us-ascii?Q?1Evn1Rdn9WvB37THC+yk3dRAgauIscREscXi8vj+GX1/2L+sJbckjEJaAzqy?= =?us-ascii?Q?Mi4ZOlDrM7qSp1GND2iHLwpFuzezrLhFLa/hn8dyfolCqxHgvaUlJQhKdygd?= =?us-ascii?Q?oXUvdJLhLi/ybcV1nANwIFCwz516xvAvCecb2GfUZODIeAMMmjLz2u7etGvG?= =?us-ascii?Q?huJ2puAhywB/+nXiQO6j23yEAxpfYXGlaEfi2pSk/yY0pNXHUstlvG3ZGcWj?= =?us-ascii?Q?2x+UIQRgr8FWrXy7E92hpY77iDoT+a8uutwX3YsQJlBiqkWClNWzAcLipbtW?= =?us-ascii?Q?YvjRnDsdWFn+darG2FwfLto+P7i/0grQwWcQZaJ13q3WP8Mzj/bbgpT6S07d?= =?us-ascii?Q?VfQX3c1Qlgdvsb6S565YrYfZEiHNUGScmxWU6EWX9QsdyB/dk/0XZxOr5zSM?= =?us-ascii?Q?pkB4/nkYVdvsGCJO32tWzKwm6mURDcRq0rCcU+jG+kLA+TdQUFad1nzLejQY?= =?us-ascii?Q?dFS6VFzZO6AIsDqYPEF/Mxzkf9WND0Quz4pu8n9qY58csnfHEkmvvfDpcsEG?= =?us-ascii?Q?ebZ12xLOrgvzERG0YwWeMS64IG0AigRVfTK34BWunwTynOTA9CKv9XevquM3?= =?us-ascii?Q?aqffrWNR7p7JeDLiRpAdPwQLYJQklCcpYa+E7eRRFDI+WV+J/3rT8v07PQYO?= =?us-ascii?Q?AXOpTleuSy6WnTR8YJucHwuoYD8Yp6UTAYXqhBe4aqxH9Dd+XJxMtaDzaJ6o?= =?us-ascii?Q?Lc75bAQ+HW8sjGQB9lazNyuRLwquO/AfCSRCGmBoReyIys0NFu5Uettg1xiF?= =?us-ascii?Q?r9lhbDl4dofsWZ4kx02kFOTCKTi8+Usn07HFt6LJi1JxjyYULMAzwHN3ozh8?= =?us-ascii?Q?ToLvCqEJ2rzGpGR7YqxlVIXk/IGwZRqonYDMC+nghCZxHGVFyGilzi0nknpO?= =?us-ascii?Q?FK6cxXdbAybsUTswJjUGgWQQeFPqgoSQxXwlMnbMtw/MfP/XvDXD1czArQJ9?= =?us-ascii?Q?m8zDrvRWKW+X37d/SAno6/jljZCs6EsC7LMX5A7sluPngtksilqTqGtYfyHe?= =?us-ascii?Q?BKZIZQZQa5oA41N2dLA/sXdEvkDQrhq8AKJBmf0R2Je545EjbXdbU1zbKqXJ?= =?us-ascii?Q?8CnpWKa2d6GwlQ9obP36CM9+5QqY40=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR07MB2521; 6:8KVkZOT23vfk4Nx3RCvUxqZnM4j5Qr3EFLjnu2LPxknu3dSnW9WqVqeJ/j/3bGnD0OgItupBAV7DfxvqdBAom0OZmWFkLI2pGYasxyQgkEN4GHdiBLaw4rQrP3Ewxwg+MsPNE7EJODx3Cw4w7qDmHfnePhnWQYeNUwbdLcgl7N95hClGFKPnLgDUpqxjXAk0IyZX9a9Fm8qrCxhht5HfXfi/NO55qj4LM3pF0octFYisKppMcIxSOcqvg96vzTMmhsqkEoJZdoDCxMA/Hnc6aOAV6ImxaxiI/z64BX1TcLnfRRrAN1kxGzqZdyr+ZwhQHd92SSm1wNLMsE9ap9JrmEa2ieLtpapzyBCdAx64C1w=; 5:cQazJq2Km3jD21oZ0aexd7Rw6eAsHtetvIJD6kF/+/H7rWtdrEfdqge4X9s8HWN0ou17sTQXvzYXe7aA1XSoCIDsRjvD/tOObK0KsWqmtB7ADZ/uUT0FR+EggQfxpg+ym6/amBXnef3i/XRt8ZCvUH1uvrbEl2shq2tUB9jUHoQ=; 24:UJYnJk/cKfLGPzHEZ59GZy0Yb6+kNGDIjTCt8oo1e11bmz/4i2jjg5XLNkm/hcfpvHzQZUOnUxa91g9XHH6zbGccuUvvRhniukhmGVMBNvo=; 7:ICeGM66LIbYu5Tak7z8Xk3m+3Y5EJhjh6VyH982t9Uqxex8iLstHaImEz3HiN5vis7azbXItRPsSO0FE/yoyte3t7apJclnGWuE1fB1qCuSePnZHFHZyv9FWg0NOJa4WBLD1hId8LBItIlxJmyuLm5uttSBUmI3NArh2jaVd1IZ2iZum/nmH4G1UXn4yJZZEzCL9XTv7iYXmMN7InVfAJx2SGR+CO3YY+mryFf/1PNnIk9MjJfH0LcXTWqc5q5CP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2018 19:17:18.8272 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 865b6d9a-91ea-4ce6-ca5e-08d5585ec6cc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2521 Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 19:17:26 -0000 -----Original Message----- > Date: Fri, 15 Dec 2017 17:02:42 +0530 > From: Pavan Nikhilesh Bhagavatula > To: "Ananyev, Konstantin" , > "jerin.jacob@caviumnetworks.com" , > "santosh.shukla@caviumnetworks.com" , > "Richardson, Bruce" , "Van Haaren, Harry" > , "Eads, Gage" , > "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" > , "Ma, Liang J" > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros > User-Agent: NeoMutt/20170609 (1.8.3) > > On Fri, Dec 15, 2017 at 10:58:10AM +0000, Ananyev, Konstantin wrote: > > > > > > > -----Original Message----- > > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com] > > > Sent: Friday, December 15, 2017 9:05 AM > > > To: Ananyev, Konstantin ; jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; > > > Richardson, Bruce ; Van Haaren, Harry ; Eads, Gage ; > > > hemant.agrawal@nxp.com; nipun.gupta@nxp.com; Ma, Liang J > > > Cc: dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros > > > > > > On Thu, Dec 14, 2017 at 06:43:24PM +0000, Ananyev, Konstantin wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavan Nikhilesh > > > > > Sent: Thursday, December 14, 2017 3:01 PM > > > > > To: jerin.jacob@caviumnetworks.com; santosh.shukla@caviumnetworks.com; Richardson, Bruce ; Van > > > > > Haaren, Harry ; Eads, Gage ; hemant.agrawal@nxp.com; nipun.gupta@nxp.com; > > > > > Ma, Liang J > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > > > > Subject: [dpdk-dev] [PATCH v2 01/11] eal: add common test assert macros > > > > > > > > > > Adding common test assertion macros for unit testing. > > > > > > > > Wonder what's wrong with existing RTE_ASSERT() and RTE_VERIFY()? > > > > Konstantin > > > > > > The existing RTE_ASSERT/VERIFY use rte_panic(). > > > > Yes, and wouldn't you expect that behavior from assert() call? > > We need to print out the number of successful/failure tests so, we need the > test to proceed even if an assert fails. > In case of `event_octeontx` we have added a new devargs 'selftest' that can be > used to test the driver from any given application. > > > Seriously where do you plan to use it outside auto test framework? > > We are moving pmd specific tests to respective pmd folder to reduce > clutter in auto test area (event devices for now) [1]. So, we need to access > the asserts from driver location instead of using CFLAGS to directly include > test.h for all the drivers it would be better to have it in eal/common as > rte_test. > > [1] http://dpdk.org/ml/archives/dev/2017-December/083740.html Cc: thomas@monjalon.net Any objection to this patch and/or taking this patch through next-eventdev tree?