From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Pavan.Bhagavatula@cavium.com>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0046.outbound.protection.outlook.com [104.47.33.46])
 by dpdk.org (Postfix) with ESMTP id 3CA5A728B
 for <dev@dpdk.org>; Thu, 11 Jan 2018 12:38:50 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=WXZwOUuXKlx/6ZIuMkzbjz0lVXYcdDu2fGExg7xSAbY=;
 b=edHl2+AvL3O0MAgLqdYOLM7swYpfybDU+04Y9jsV38EZ4yA7eu3vva93/xJkmsihx4VYk2lyja6a7L2mpJ5cVwMzNu/luc+C0N8GfD4EoncMVImlN4YjMYO+FftTqDyguEGq33LOZvWNpK16apzgq1lDLffQWWQla9laTq2w6FA=
Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Pavan.Bhagavatula@cavium.com; 
Received: from Pavan-LT (111.93.218.67) by
 MWHPR07MB3472.namprd07.prod.outlook.com (10.164.192.23) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id
 15.20.386.5; Thu, 11 Jan 2018 11:38:44 +0000
Date: Thu, 11 Jan 2018 17:08:37 +0530
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
 jerin.jacob@caviumnetworks.com, nipun.gupta@nxp.com, hemant.agrawal@nxp.com
Cc: dev@dpdk.org
Message-ID: <20180111113836.pbfssjbfy3vemf7c@Pavan-LT>
References: <1512158458-22661-1-git-send-email-erik.g.carrillo@intel.com>
 <1515630074-29020-1-git-send-email-erik.g.carrillo@intel.com>
 <1515630074-29020-13-git-send-email-erik.g.carrillo@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1515630074-29020-13-git-send-email-erik.g.carrillo@intel.com>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Originating-IP: [111.93.218.67]
X-ClientProxiedBy: MWHPR20CA0040.namprd20.prod.outlook.com (10.172.102.154) To
 MWHPR07MB3472.namprd07.prod.outlook.com (10.164.192.23)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 0d7028fd-1d9b-4934-5535-08d558e7dfd8
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020);
 SRVR:MWHPR07MB3472; 
X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3472;
 3:fO5VgrcV9C0mHtnxL/1DaMuIYhYOuBFEyygLB9IeOUXc70YRvF1Qb2EF4zlLA7lWpHDldcfnEonV8MNv++oHDlWCLzL76cZ8jCI7Ttos7cIhZifFJ3qTWqrbQg9efkHQJpZgczs+Ct9GhrMaq37wvNsdR2fzTfgOFQH8WGROduodFLqKZqvpO4PU+5JU2IdulRL8dD7Uumm3KocLn7xRUGaepuno0aJbnBAhLSccZvXognglir8HybcHd74XxpYL;
 25:rqkL7wUOFepWiiNUQWJ+RCZxGL3qHnzIjWvOmhHO5chkcuZ7SsnYNA1+IKUqty3aGAMtrHUNeUXAWin3nmgO26qlzGw44mTowK5Wr0mscPTQy27Wx+CGFhsfxElIH8vrWOybhse+ba0PTNsM8vByib8qVxHIiTja7d8gs4Izl7TaV3nP/67dbRzC5/NRmbUm7raPZQM5H5cKl33TBtP4VEMlxfYSRVFFx/sFHbcgd79J+00MaFQAldrL4eWZJbwI0JOcnTGeLyZ7fKXKkLGzcXJXPhPeRjUDWBpDkZX4bhh/NLFgG9kyHi7z0F5K2IKWSUCCOMr/gZLr5Hr5f5LZ4w==;
 31:c9YCBnS+2lTMA4qQyE7zvd/9ZjV0ykliwyuUNKkHsVEA5SXJyv4uPfoUVdi3G1N008GgriwrPtDwd9mzFXYoWj4wT8XFMDTHnf5pQD1Cun59P4HUXxbo23L6Fl+B6xPaJhI0A1wSMZgQ1V75aU3bGE+fd8ig4xqOwdERvn03eiKnL7ra8b+ui7oKyBPC1kVAQC3hxeTOaeCxhJ0ldBaiDoAoriXvjLgQf6m0oodFQIU=
X-MS-TrafficTypeDiagnostic: MWHPR07MB3472:
X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3472;
 20:u7SFVNGNTKiyM/KzNARqHo6Ti5DeCrrNVFrUzJp7qa0Ob01Z+e3ooHbrHjTDcmxqq0hqrERI/Hpr03zPwLIvNIgSaOrMGqfhUk3WRyczpdl/c/VXgTS7CTOaCzBYpLpXj/8aBgwV05DRODarM2EdUbmze/hZ53eOKglSBzKMJi3LVfbPrEMqS4uIakltfW/DHsxNxgObdqQTwFzvra39/CUid0kk90GnJLkX4ZlqYXqBO9Sh1iOQ4rzpUYnAjWNrPrW2ag/PKnCjuVrMR66s5eXw1w7Imp5DzncBNRyDjTEzJC76J5UMWFNvBbeKjt9roS/VR8LIkit9SPrwVbLwOqAWexfOG3kGcDQWehv4vaWWmCRUoVJCQXReveNKgLXpVEBo14IE6gB846tS5/T3rLDqGrIukwdw9eTwMCbwUg33UqqIyQurGpSioGGVGQRNZvzl+CtOEGHDU2RsY1ykSoyFvD1Q/j1VzPN0iGx69kidoAWi7Vy0S9RzKgC/8P2GK7uIawrqdnRWSx5+Ca/oSSMheTi1q/N4JHYCVj/jBdukjlonr/eruPCJ8+mBSWNE+pPT3Rl0pCx1Z6iHIgYRqFKpp6p53bbsl2DES6+SVXc=;
 4:IFkN0N8L39/7I/Zjl12mKa71Mk2dBifPWMMjPvfxklI+JtmDuXv2MGy2zqzxGW2aKBlGSpl/VLiTXrKLEfjdgwUOxUgYF3smd+6tmwdVLxJqeBbNeLZuRmLovsphrSRe4DaHCOvLXY5I9+h2fXoc69VEctz3J+r8cwNhTTGhkbAfAyyhUXqYohnw8vTgWFvd2Qe1M+SCSOJeqmYv7XqCLBx2bV6GjXADtIYVZRuUQq5SRU7Q3LvegjFeMg91csFd2NwL2SIXaQZJZj/iokUJhYzvkO+7GKuApMNL6f7AlWYloOLH7Od6XJfIkdjG4udc
X-Microsoft-Antispam-PRVS: <MWHPR07MB3472BBC597192A539764420F80160@MWHPR07MB3472.namprd07.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(228905959029699);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
 RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(93006095)(10201501046)(3231023)(944501075)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011);
 SRVR:MWHPR07MB3472; BCL:0; PCL:0; RULEID:(100000803101)(100110400095);
 SRVR:MWHPR07MB3472; 
X-Forefront-PRVS: 0549E6FD50
X-Forefront-Antispam-Report: SFV:NSPM;
 SFS:(10009020)(346002)(376002)(366004)(39380400002)(39850400004)(396003)(189003)(199004)(24454002)(229853002)(76176011)(5009440100003)(25786009)(52116002)(1076002)(4326008)(8676002)(3846002)(23726003)(6496006)(97736004)(6116002)(81156014)(6246003)(50466002)(33896004)(83506002)(81166006)(2906002)(8936002)(8656006)(16586007)(305945005)(42882006)(58126008)(316002)(2950100002)(106356001)(5660300001)(47776003)(66066001)(7736002)(68736007)(33716001)(105586002)(9686003)(72206003)(478600001)(55016002)(386003)(59450400001)(53936002)(6666003)(16526018)(107986001)(42262002);
 DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3472; H:Pavan-LT; FPR:; SPF:None;
 PTR:InfoNoRecords; MX:1; A:1; LANG:en; 
Received-SPF: None (protection.outlook.com: cavium.com does not designate
 permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHPR07MB3472;
 23:pZc3t3RRkDBLEe+dXbrnbzMyzJ2P+TRShSxfwl1/W?=
 =?us-ascii?Q?7Ve8IeYm+wezZVdDhcTPHHyMXz6KEsn5CG713p5cHrc+yaSPpa4VCza4Ldqb?=
 =?us-ascii?Q?d0E9L6p5cM71uatzOwP1G238nBq2NeT8ZIf5iy85adL9DeZ9PMi8PekBMyFz?=
 =?us-ascii?Q?SmnjclYexyfGJKEDjt2APszF+k8Wod+81rmWKb+tGhhCt/os4NFEOw+PF4NJ?=
 =?us-ascii?Q?dZ9EhtrFwSH3CZX9ko5setRNYf2XOaOt0I3C9p1lzNMTJvvvPQi/b9a96w5y?=
 =?us-ascii?Q?4SH78lsWdT7RinIjcwdRqVWitMV6k0wQqOMQRp6qQELuRReE9vWiSgJFhX3+?=
 =?us-ascii?Q?tYU87ImoV5iDqTWONv18c5n2Z2tBF6EGKfH2TgcrH1ajWNXHEQThrvMqhwIz?=
 =?us-ascii?Q?DVcFCafdo1/3fcFN8YoGDLVNol4rJutu8wIiw33S7pIu3k8Kjxbe+igdxNe/?=
 =?us-ascii?Q?Kj5HV5t64jBbvGQR7tnGkgqFEUXCEhjet8SD4ZO/MVwmHsG8JOcxCY/AtZr4?=
 =?us-ascii?Q?IrJ6tmDqUmN/PZvux6ehPo+S9L8RkO+sy+cToe+jcqOBY7U9krWpvPN1dAsv?=
 =?us-ascii?Q?xYJ74wwsFhPph3Zie0zIRD3kEmLrwZpPUJKNnOu4AnfWdPO7fbGQDzfLCX/j?=
 =?us-ascii?Q?uPaRZtYV3Rx/1zSjmuumlL4XdS90iPnTnugARqP2z053FqrAfWOoxIQL4RC5?=
 =?us-ascii?Q?m5Mttb355+9B2z+Kr8FeSEt8JbgZGbCaiAhK3ENsG8nZEwdTwwKZFNsp2Jxr?=
 =?us-ascii?Q?GzfrBKMOXtcdjw2Bj6u4jV3t0iV5T7dkJ9x4fA3Z0Il3VrsvsJTTBY/Wb90T?=
 =?us-ascii?Q?vQHjGj4sOWXewCSJ/BcnAAEJ1d1WueYxYrHHsah3xXJT/H6DAmT10vnanOFs?=
 =?us-ascii?Q?67PPCWkDuZ3tALmlofe+99u36aVlZijvqYovYUTWTMTwji7TcnE8QiTTF4xz?=
 =?us-ascii?Q?HTMClPZBdRYfe/DioXHFvkH4DhY8uxZfEs0S8AG246AlJ0L2KfJgkG2nsPlw?=
 =?us-ascii?Q?E2al2AV/tDzxlHBhxfDTXyqHDeyZtHvKsT04YqRrN/k1ZmdJCfcd5fSOLEmN?=
 =?us-ascii?Q?DiOky2LKeAlicNi2eVawgBJpW6j9pSFrpI1ysXompq9s5L1MnwKlnJSDPRxY?=
 =?us-ascii?Q?dJyJd6H+1M7v87T1Z27nQCJkH3P+eSJ4K8UGDViNe9x0+swFuilXdHFXyBC5?=
 =?us-ascii?Q?ncT0H4mXaY8qa5Gjot23qOS8tY1qOi/fBHKrr9MwTs85iNiROescLuuL6Q0Z?=
 =?us-ascii?Q?jqHiN7T6I6h09ex6Q4V0YvTzXXZKfH4vQFQT4E1LyRRTVe7ChdBFhEp2Xydq?=
 =?us-ascii?B?Zz09?=
X-Microsoft-Exchange-Diagnostics: 1; MWHPR07MB3472;
 6:8pdNPJveWP5c88AUP1eFq09hm5u6gGOEhj+2i1WW0tENLXY21DFrIWdxqEdFt57ibC1fE1nJQKSlaUgoO+8K6DpLaH4kury4603L3QbyKZ1iFF5jpl8e9o3zRZZzBflnaaTapTBNWhaVfN4xYSnvE7wlzANPmNWQPLOBLuEJt826q26zsKu/qC7cJ8YCbzI9xp/44Vh1TlmTvfQPrM0mU2KMsmMslH3L+MBqyMjOPA74YaqFHST0fOA+1+rdrZGxIeeqn/JshKCtK3W/I5ND1UOLtyPBDeqZhTaRVS3tg037+uqgcxFIK8O7Ug0VRtKc3AWIRtm8jsd9AV4CVHqXSa/E0p4cn2dtxFj8bPjcJw8=;
 5:6PgjbMRu1MxTRn8iqZ7uwGkAI5/IW36kh03VxgJpgtHNm1SqLb8s9gpvuwfJKiEiCOluUpLklexdg0NdbLag03IfC/ct89b+rhbKhI0rV0/LOxLMK//pMcL8bumZVyQGOiYaaLQNELugldOFTafCkyOkpjBMa3g+1O77XMCxkKs=;
 24:4kM9GlABgCMeVrS1xHSRpY8YyglrFE8PuytxfovxUMR3Yu1zG8N5yMz8M8JTcoy4BaY0JIbj5w80JtaoB2elfi3697sBeOpIj1MzPgL764w=;
 7:WmjDsNdTqZ1WCE90nvHhcSC780QhFRIr5BF7aiXkH1kNxYl9ksY3w1Y0IlEQWKHHPoSL+Hrrxpk/mmjwnCBJIl9m7nWcK69fN/rd10CzsGicFETJPuVgvP6urcOi4z7/pP2FaOilUrBfrjHmRTelnhEkcvHrcABNmZeGhTFQXws5Y6o+K+GGzdeploj4q491p802bZ192U+uKvkgFnAyIRYmL80mDpJLp3BGFiOf1P8tewwweJm2SSOQi3QAC5hU
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-OriginatorOrg: caviumnetworks.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2018 11:38:44.1635 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d7028fd-1d9b-4934-5535-08d558e7dfd8
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3472
Subject: Re: [dpdk-dev] [PATCH v6 12/23] eventtimer: add event timer
 arm/cancel function definitions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jan 2018 11:38:50 -0000

On Wed, Jan 10, 2018 at 06:21:03PM -0600, Erik Gabriel Carrillo wrote:
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
>  lib/Makefile                                  |   2 +-
>  lib/librte_eventdev/Makefile                  |   2 +-
>  lib/librte_eventdev/rte_event_timer_adapter.c | 155 +++++++++++++++++++++++---
>  mk/rte.app.mk                                 |   2 +-
>  4 files changed, 141 insertions(+), 20 deletions(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 4c53f8c..c2bee80 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -29,7 +29,7 @@ DEPDIRS-librte_security := librte_eal librte_mempool librte_ring librte_mbuf
>  DEPDIRS-librte_security += librte_ether
>  DEPDIRS-librte_security += librte_cryptodev
>  DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += librte_eventdev
> -DEPDIRS-librte_eventdev := librte_eal librte_ring librte_ether librte_hash librte_mempool
> +DEPDIRS-librte_eventdev := librte_eal librte_ring librte_ether librte_hash librte_mempool librte_timer
>  DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
>  DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ether
>  DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
> diff --git a/lib/librte_eventdev/Makefile b/lib/librte_eventdev/Makefile
> index e68f888..6e95528 100644
> --- a/lib/librte_eventdev/Makefile
> +++ b/lib/librte_eventdev/Makefile
> @@ -13,7 +13,7 @@ LIBABIVER := 3
>  # build flags
>  CFLAGS += -O3
>  CFLAGS += $(WERROR_FLAGS)
> -LDLIBS += -lrte_eal -lrte_ring -lrte_ethdev -lrte_hash -lrte_mempool
> +LDLIBS += -lrte_eal -lrte_ring -lrte_ethdev -lrte_hash -lrte_mempool -lrte_timer
>
>  # library source files
>  SRCS-y += rte_eventdev.c
> diff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c
> index a4c8012..38e52cb 100644
> --- a/lib/librte_eventdev/rte_event_timer_adapter.c
> +++ b/lib/librte_eventdev/rte_event_timer_adapter.c
> @@ -609,16 +609,91 @@ sw_event_timer_adapter_stop(const struct rte_event_timer_adapter *adapter)
>  	return rte_service_component_runstate_set(sw_data->service_id, 0);
>  }
>
> +static __rte_always_inline void
> +swap(struct rte_event_timer **evtims, int i, int j)
> +{
> +	struct rte_event_timer *tmp;
> +
> +	tmp = evtims[i];
> +	evtims[i] = evtims[j];
> +	evtims[j] = tmp;
> +}
> +
> +static __rte_always_inline int
> +__sw_event_timer_arm_burst(const struct rte_event_timer_adapter *adapter,
> +			   struct rte_event_timer **evtims,
> +			   uint16_t nb_evtims)
> +{
> +	int i, n, mark, nb_fails = 0;
> +	int fails[nb_evtims];
> +	struct rte_event_timer_adapter_sw_data *sw_data;
> +	struct msg *msgs[nb_evtims];
> +	struct rte_timer *tims[nb_evtims];
> +
> +	sw_data = adapter->data->adapter_priv;
> +
> +	n = rte_mempool_get_bulk(sw_data->msg_pool, (void **)msgs, nb_evtims);
> +	if (n < 0) {
> +		rte_errno = ENOMEM;
> +		return 0;
> +	}
> +
> +	n = rte_mempool_get_bulk(sw_data->tim_pool, (void **)tims, nb_evtims);
> +	if (n < 0) {
> +		rte_errno = ENOMEM;

Need to free msg objs that were dequeued prior (Although this has a very low
chance of happening.)
As mentioned before consider having a single pool.

> +		return 0;
> +	}
> +
> +	for (i = 0; i < nb_evtims; i++) {
> +		rte_timer_init(tims[i]);
> +		evtims[i]->impl_opaque[0] = (uintptr_t)tims[i];
> +		evtims[i]->impl_opaque[1] = (uintptr_t)adapter;
> +
> +		msgs[i]->evtim = evtims[i];
> +		msgs[i]->type = MSG_TYPE_ARM;
> +	}
> +
> +	n = rte_ring_enqueue_burst(sw_data->msg_ring, (void **)msgs, nb_evtims,
> +				   NULL);
> +	if (n < nb_evtims) {
> +		rte_mempool_put_bulk(sw_data->msg_pool, (void **)&msgs[n],
> +				     nb_evtims - n);
> +		rte_mempool_put_bulk(sw_data->tim_pool, (void **)&tims[n],
> +				     nb_evtims - n);
> +	}
> +
> +	for (i = 0; i < n; i++) {
> +		/* Wait until state is updated */
> +		while (evtims[i]->state == RTE_EVENT_TIMER_NOT_ARMED ||
> +		       evtims[i]->state == RTE_EVENT_TIMER_CANCELED)
> +			;
> +
> +		/* Note any failures */
> +		if (evtims[i]->state != RTE_EVENT_TIMER_ARMED) {
> +			fails[nb_fails++] = i;
> +			rte_errno = EINVAL;
> +		}
> +
> +		/* TODO: handle the case of consecutive arm requests;  the
> +		 * second request can erroneously see success from the first
> +		 */
> +	}
> +
> +	/* Move the failures to the end of the array */
> +	for (i = 0, mark = n - 1; i < nb_fails; i++, mark--)
> +		swap(evtims, fails[i], mark);
> +
> +	n = mark + 1;
> +
> +	return n;
> +}
> +
>  static int
>  sw_event_timer_arm_burst(const struct rte_event_timer_adapter *adapter,
>  			 struct rte_event_timer **evtims,
>  			 uint16_t nb_evtims)
>  {
> -	RTE_SET_USED(adapter);
> -	RTE_SET_USED(evtims);
> -	RTE_SET_USED(nb_evtims);
> -
> -	return 0;
> +	return __sw_event_timer_arm_burst(adapter, evtims, nb_evtims);
>  }
>
>  static int
> @@ -626,25 +701,71 @@ sw_event_timer_cancel_burst(const struct rte_event_timer_adapter *adapter,
>  			    struct rte_event_timer **evtims,
>  			    uint16_t nb_evtims)
>  {
> -	RTE_SET_USED(adapter);
> -	RTE_SET_USED(evtims);
> -	RTE_SET_USED(nb_evtims);
> +	int i, n, mark, nb_fails = 0;
> +	int fails[nb_evtims];
> +	struct msg *msg, *msgs[nb_evtims];
> +	struct rte_event_timer_adapter_sw_data *sw_data;
>
> -	return 0;
> +#ifdef RTE_LIBRTE_EVENTDEV_DEBUG
> +	/* TODO: verify that service is running to avoid hanging if in block
> +	 * mode
> +	 */
> +#endif
> +
> +	sw_data = adapter->data->adapter_priv;
> +
> +	n = rte_mempool_get_bulk(sw_data->msg_pool, (void **)msgs, nb_evtims);
> +	if (n < 0) {
> +		rte_errno = ENOMEM;
> +		return 0;
> +	}
> +
> +	/* Set up the messages */
> +	for (i = 0; i < nb_evtims; i++) {
> +		msg = msgs[i];
> +		msg->type = MSG_TYPE_CANCEL;
> +		msg->evtim = evtims[i];
> +	}
> +
> +	n = rte_ring_enqueue_burst(sw_data->msg_ring, (void **)msgs, nb_evtims,
> +				   NULL);
> +	if (n < nb_evtims)
> +		rte_mempool_put_bulk(sw_data->msg_pool, (void **)&msgs[n],
> +				     nb_evtims - n);
> +
> +	for (i = 0; i < n; i++) {
> +		/* Wait until state is updated */
> +		while (evtims[i]->state == RTE_EVENT_TIMER_ARMED)
> +			;
> +
> +		/* Note any failures */
> +		if (evtims[i]->state != RTE_EVENT_TIMER_CANCELED) {
> +			fails[nb_fails++] = i;
> +			rte_errno = EINVAL;
> +		}
> +	}
> +
> +	/* Move the failures to the end of the array */
> +	for (i = 0, mark = n - 1; i < nb_fails; i++, mark--)
> +		swap(evtims, fails[i], mark);
> +
> +	n = mark + 1;
> +
> +	return n;
>  }
>
>  static int
>  sw_event_timer_arm_tmo_tick_burst(const struct rte_event_timer_adapter *adapter,
> -				  struct rte_event_timer **tims,
> -				  uint64_t timeout_tick,
> -				  uint16_t nb_tims)
> +				  struct rte_event_timer **evtims,
> +				  uint64_t timeout_ticks,
> +				  uint16_t nb_evtims)
>  {
> -	RTE_SET_USED(adapter);
> -	RTE_SET_USED(tims);
> -	RTE_SET_USED(timeout_tick);
> -	RTE_SET_USED(nb_tims);
> +	int i;
>
> -	return 0;
> +	for (i = 0; i < nb_evtims; i++)
> +		evtims[i]->timeout_ticks = timeout_ticks;
> +
> +	return __sw_event_timer_arm_burst(adapter, evtims, nb_evtims);
>  }
>
>  const struct rte_event_timer_adapter_ops sw_event_adapter_timer_ops = {
> diff --git a/mk/rte.app.mk b/mk/rte.app.mk
> index 6a6a745..3dd95f5 100644
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -80,7 +80,6 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_BITRATE)        += -lrte_bitratestats
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_LATENCY_STATS)  += -lrte_latencystats
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER)          += -lrte_power
>
> -_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_EFD)            += -lrte_efd
>
>  _LDLIBS-y += --whole-archive
> @@ -96,6 +95,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_ETHER)          += -lrte_ethdev
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_CRYPTODEV)      += -lrte_cryptodev
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_SECURITY)       += -lrte_security
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV)       += -lrte_eventdev
> +_LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER)          += -lrte_timer
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL)        += -lrte_mempool
>  _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -lrte_mempool_ring
>  _LDLIBS-$(CONFIG_RTE_LIBRTE_RING)           += -lrte_ring
> --
> 2.6.4
>