Re: [dpdk-dev] [PATCH 1/4] drivers/mempool: add octeontx mempool driver to meson build

[Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>]

On Tue, Jan 09, 2018 at 05:35:28PM +0000, Bruce Richardson wrote:
> On Sun, Dec 31, 2017 at 05:32:00AM +0530, Pavan Nikhilesh wrote:
> > Add octeontx hardware mempool driver to meson build.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
> >  drivers/mempool/meson.build          | 2 +-
> >  drivers/mempool/octeontx/meson.build | 8 ++++++++
> >  2 files changed, 9 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/mempool/octeontx/meson.build
> >
> > diff --git a/drivers/mempool/meson.build b/drivers/mempool/meson.build
> > index a47b1d9b1..599185609 100644
> > --- a/drivers/mempool/meson.build
> > +++ b/drivers/mempool/meson.build
> > @@ -1,7 +1,7 @@
> >  # SPDX-License-Identifier: BSD-3-Clause
> >  # Copyright(c) 2017 Intel Corporation
> >
> > -drivers = ['ring', 'stack']
> > +drivers = ['ring', 'stack', 'octeontx']
> >  std_deps = ['mempool']
> >  config_flag_fmt = 'RTE_LIBRTE_@0@_MEMPOOL'
> >  driver_name_fmt = 'rte_mempool_@0@'
> > diff --git a/drivers/mempool/octeontx/meson.build b/drivers/mempool/octeontx/meson.build
> > new file mode 100644
> > index 000000000..57ddf58b7
> > --- /dev/null
> > +++ b/drivers/mempool/octeontx/meson.build
> > @@ -0,0 +1,8 @@
> > +sources = files('octeontx_ssovf.c',
> > +		'octeontx_mbox.c',
> > +		'octeontx_fpavf.c',
> > +		'rte_mempool_octeontx.c'
> > +)
> > +deps += ['mbuf', 'bus_pci']
> > +
> > +mempool_octeontx_dir = include_directories('.')
>
> Is this variable used in later patches, I don't see it on a quick scan?
> Normally we just use the dependency objects to manage paths to include
> directories, and we don't need to explicitly have include variables.

I was using this in 'drivers/net/octeontx/base' while experimenting will remove
in v2.

>
> /Bruce