From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Matej Vido <vido@cesnet.cz>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v4 13/15] net/szedata: use _rte_eth_linkstatus_set
Date: Thu, 11 Jan 2018 17:06:56 +0000 [thread overview]
Message-ID: <20180111170658.2809-13-ferruh.yigit@intel.com> (raw)
In-Reply-To: <20180111170658.2809-1-ferruh.yigit@intel.com>
From: Stephen Hemminger <stephen@networkplumber.org>
Yet another driver which was not returing correct value on
link change.
Since this driver can't be built on x86 could not even
do a compile test.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/szedata2/rte_eth_szedata2.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/net/szedata2/rte_eth_szedata2.c b/drivers/net/szedata2/rte_eth_szedata2.c
index 45aebed33..b0fdf30f8 100644
--- a/drivers/net/szedata2/rte_eth_szedata2.c
+++ b/drivers/net/szedata2/rte_eth_szedata2.c
@@ -50,7 +50,6 @@
#include <rte_memcpy.h>
#include <rte_kvargs.h>
#include <rte_dev.h>
-#include <rte_atomic.h>
#include "rte_eth_szedata2.h"
#include "szedata2_iobuf.h"
@@ -1173,14 +1172,15 @@ static int
eth_link_update(struct rte_eth_dev *dev,
int wait_to_complete __rte_unused)
{
- struct rte_eth_link link;
- struct rte_eth_link *link_ptr = &link;
- struct rte_eth_link *dev_link = &dev->data->dev_link;
struct pmd_internals *internals = (struct pmd_internals *)
dev->data->dev_private;
const volatile struct szedata2_ibuf *ibuf;
uint32_t i;
bool link_is_up = false;
+ struct rte_eth_link link = {
+ .link_duplex = ETH_LINK_FULL_DUPLEX,
+ .link_autoneg = ETH_LINK_FIXED,
+ };
switch (get_link_speed(internals)) {
case SZEDATA2_LINK_SPEED_10G:
@@ -1197,9 +1197,6 @@ eth_link_update(struct rte_eth_dev *dev,
break;
}
- /* szedata2 uses only full duplex */
- link.link_duplex = ETH_LINK_FULL_DUPLEX;
-
for (i = 0; i < szedata2_ibuf_count; i++) {
ibuf = ibuf_ptr_by_index(internals->pci_rsc, i);
/*
@@ -1212,14 +1209,9 @@ eth_link_update(struct rte_eth_dev *dev,
}
}
- link.link_status = (link_is_up) ? ETH_LINK_UP : ETH_LINK_DOWN;
-
- link.link_autoneg = ETH_LINK_FIXED;
+ link.link_status = link_is_up ? ETH_LINK_UP : ETH_LINK_DOWN;
- rte_atomic64_cmpset((uint64_t *)dev_link, *(uint64_t *)dev_link,
- *(uint64_t *)link_ptr);
-
- return 0;
+ return _rte_eth_linkstatus_set(dev, &link);
}
static int
--
2.14.3
next prev parent reply other threads:[~2018-01-11 17:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 17:44 [dpdk-dev] [PATCH v3 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-11 17:01 ` Ferruh Yigit
2018-01-25 23:24 ` Stephen Hemminger
2018-03-08 22:12 ` Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-09 10:30 ` Andrew Rybchenko
2018-01-09 16:29 ` Stephen Hemminger
2018-01-11 17:01 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-11 17:02 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-11 17:02 ` Ferruh Yigit
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 05/15] net/dpaa2: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 09/15] net/sfc: use new " Stephen Hemminger
2018-01-09 10:35 ` Andrew Rybchenko
2018-01-09 16:27 ` Stephen Hemminger
2018-01-09 19:29 ` Andrew Rybchenko
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 10/15] net/i40e: use " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 11/15] net/liquidio: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 12/15] net/thunderx: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 13/15] net/szedata: " Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-08 17:45 ` [dpdk-dev] [PATCH v3 15/15] net/enic: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 01/15] eal: introduce atomic exchange operation Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 02/15] ethdev: add linkstatus get/set helper functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 03/15] net/virtio: use eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 04/15] net/vmxnet3: use rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 05/15] net/dpaa2: " Ferruh Yigit
2018-01-16 9:44 ` Shreyansh Jain
2018-01-16 9:57 ` Shreyansh Jain
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 06/15] net/nfp: use rte_eth_linkstatus functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 07/15] net/e1000: use rte_eth_linkstatus helpers Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 08/15] net/ixgbe: use rte_eth_linkstatus functions Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 09/15] net/sfc: use new " Ferruh Yigit
2018-01-12 7:45 ` Andrew Rybchenko
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 10/15] net/i40e: use " Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 11/15] net/liquidio: use _rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 12/15] net/thunderx: " Ferruh Yigit
2018-01-11 17:06 ` Ferruh Yigit [this message]
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 14/15] net/octeontx: use rte_eth_linkstatus_set Ferruh Yigit
2018-01-11 17:06 ` [dpdk-dev] [PATCH v4 15/15] net/enic: use _rte_eth_linkstatus_set Ferruh Yigit
2018-01-12 14:05 ` Hyong Youb Kim
2018-01-16 18:25 [dpdk-dev] [PATCH v4 00/15] common ethdev linkstatus functions Stephen Hemminger
2018-01-16 18:25 ` [dpdk-dev] [PATCH v4 13/15] net/szedata: use _rte_eth_linkstatus_set Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111170658.2809-13-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=stephen@networkplumber.org \
--cc=vido@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).