From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id C0F3A44BE for ; Fri, 12 Jan 2018 11:38:47 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id v123so1692479wmd.5 for ; Fri, 12 Jan 2018 02:38:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LQKFTn6MK83Ti5AbrGUdxSvVU+G7H2wXF83vSx4/ioU=; b=nDrPEBvMa2NpfDFVn/dNjlSG3akEWRklNXjY/CUKDbddmfKnQ/VWFm+UVIekjiiBQo OY3Y8iPIpiHyqdSa4EE2CAivf6GLbBiuq5jMWn6T1/40DCahp5Tmn9xIorel4t21UccB MwZbqQ6QNHZKZ9TjKvufBBgMK2K7aud4BGEcQsPWUsdMQpdCpReU4ZGYA94DFps/EuWo Mt1dVMtgHyyFjqFA2c8rDQp1tvSOzLzpQB32DqwqlQgwle9q3WPYJXeP3Sj8hkOtGtQQ bMRzWACaPzZ1rVWWQdlsXA2QSfIqQqZ0PZm5gE82NDNMAKVOsDjdKV+/SIDDccurhR7Q RYcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=LQKFTn6MK83Ti5AbrGUdxSvVU+G7H2wXF83vSx4/ioU=; b=YIUbHVxjJxtVEPMcK7o4ZYwog/MftJQC5JoxRxiYhe3i/Q9wfAzwjFJRYoUmsxgTe0 qL438lzEsiyhDQK8uiTI6uq/FjQ89gAtlScx5GpOITw6p2wjbq9akNRSFClpJiIa3e3j sU5rhKwOuMzJFmmmJqLgW4iGjNgX1wWzOZOO5ZiGTqQkMerrpZsXPZca9oQK+fEqUUaF lG3QVN9cpZN4fyR2aYbPnhzY1sFk2fA455C5EH0Xy+W/GTEJ5DEJrS+rb+uCnglxz2BX 2aR/ROIOfZshPxAKRTB+krcb3nl3CElqFpxE0j0aqUgtngMxmU90Zfcg0F8y/xs+joUc zs7w== X-Gm-Message-State: AKwxytfYgjnCsOuG2JNJlOf7vRmZlQ2TFmMXZ0oqwIiABYAAQRQ4kqxv j8BoHOLdJGrvG+5dyuSezVGk3Q== X-Google-Smtp-Source: ACJfBos/I2G6X+sXU6OQanl0Rx4cuzzB6p3skyEMAkZq7UJtFgwD1bLq/VpLnzAYAMYbj9Mrged6DA== X-Received: by 10.80.212.154 with SMTP id s26mr987664edi.268.1515753527344; Fri, 12 Jan 2018 02:38:47 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z1sm13428333edz.17.2018.01.12.02.38.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 12 Jan 2018 02:38:46 -0800 (PST) Date: Fri, 12 Jan 2018 11:38:34 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: george.dit@gmail.com Cc: dev@dpdk.org Message-ID: <20180112103834.br6bq5z3sm7o2tkz@bidouze.vm.6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] Move flow parsing from test-pmd to librte_cmdline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 10:38:47 -0000 Hi George, On Fri, Jan 12, 2018 at 10:21:41AM +0100, george.dit@gmail.com wrote: > Dear DPDK developers, > > In an attempt to integrate the Flow API into a third party application and > allow the e.g., insertion/deletion of NIC classification rules from that > application, I noticed that flow command parsing as per the most recent > DPDK versions (i.e., 17.08 or 17.11) might benefit from some useful > modifications. > > Specifically, librte_cmdline provides libraries for parsing a flow command > into tokens, but then the library for e.g., creating/deleting a flow rule > for a DPDK NIC resides in test-pmd (app/test-pmd/cmdline_flow.c). > > My proposal is to move the app/test-pmd/cmdline_flow.c library into > librte_cmdline, thus facilitate flow parsing for third party DPDK > applications. > I have a working prototype for both DPDK 17.08 and 17.11. This prototype > extends librte_cmdline with 2 additional files (cmdline_flow.h and .c) and > removes this functionality from test-pmd. > The benefit is that the functions in cmdline_flow.h can now be re-used by > any DPDK applications, which was not the case before. > > Do you think that the DPDK community will benefit from my patch? If so, I > am happy to send you the patch for review and get your feedback to further > improve it. > In case I missed some other way to achieve my goal (without the need to > patch DPDK), please let me know. > > Best regards, My opinion would that it might be interesting to have parsing helpers available for complex APIs such as this one, ready to be dropped into applications. There were contentions not too long ago about the status of rte_cmdline, but in any case I think it could be interesting to have your input on this. So don't hesitate to send it. Cheers, -- Gaëtan Rivet 6WIND