From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bgl-iport-1.cisco.com (bgl-iport-1.cisco.com [72.163.197.25]) by dpdk.org (Postfix) with ESMTP id 63323325F for ; Fri, 12 Jan 2018 15:05:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=988; q=dns/txt; s=iport; t=1515765906; x=1516975506; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fCNpK8uF6O6cFLC6rEu+Su9upewPnz9Ys5r1G6gU+Ro=; b=jFuu3jp5WLeD10Hrmz+Qv/TnnLu1eJ8rd/OqoFrfkLd1JlKY+Dy1gT+m hOjYtR0NeIeCsoHMB9Qs95tOnpNb51m4ZFxlhb8h+6iAS/NQnaby1ip35 OrRmrbiCWKWpboE3xi5kDmNMFx+19NzYqphriXIbaTcg8Z2R65jEJwfXo U=; X-IronPort-AV: E=Sophos;i="5.46,349,1511827200"; d="scan'208";a="81761650" Received: from vla196-nat.cisco.com (HELO bgl-core-3.cisco.com) ([72.163.197.24]) by bgl-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jan 2018 14:05:05 +0000 Received: from HYONKIM-FTCPE.cisco.com (tky-vpn-client-231-199.cisco.com [10.70.231.199]) by bgl-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id w0CE51A8019529 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 12 Jan 2018 14:05:03 GMT Date: Fri, 12 Jan 2018 23:05:00 +0900 From: Hyong Youb Kim To: Ferruh Yigit Cc: Bruce Richardson , Konstantin Ananyev , John Daley , dev@dpdk.org, Stephen Hemminger Message-ID: <20180112140459.GA3292@HYONKIM-FTCPE.cisco.com> References: <20180108174514.14688-1-stephen@networkplumber.org> <20180111170658.2809-1-ferruh.yigit@intel.com> <20180111170658.2809-15-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180111170658.2809-15-ferruh.yigit@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Mailman-Approved-At: Sun, 14 Jan 2018 18:15:03 +0100 Subject: Re: [dpdk-dev] [PATCH v4 15/15] net/enic: use _rte_eth_linkstatus_set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 14:05:06 -0000 On Thu, Jan 11, 2018 at 05:06:58PM +0000, Ferruh Yigit wrote: > From: Stephen Hemminger > > This driver was not doing atomic update of link status information. > And the return value was different than others. > The hardware also does not do autonegotiation (at least on Linux). > > Signed-off-by: Stephen Hemminger > --- Here is an ack, in case you need it. Please feel free to add it to v4 if you make it (i.e. dropping the leading _). Acked-by: Hyong Youb Kim FWIW, the NIC hardware (Cisco VIC) does autonegotiate. But, the link settings (autoneg/fixed/10/25/40) are controlled by a management entity (e.g. UCS manager). The drivers including the netdev enic driver cannot change them and currently do not know if the current speed has been autonegotiated or fixed by admin. So, they simply report the current link speed as fixed. I know, it is a little unconventional. -Hyong