From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0056.outbound.protection.outlook.com [104.47.40.56]) by dpdk.org (Postfix) with ESMTP id EFF0A3772 for ; Sat, 13 Jan 2018 06:06:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=krj5GJpxziHWJDfhNUdjVOiT1LPICYUves4Dwq+VM+w=; b=KwnKmcpexF7IAVn2Q/uB/RVNPN/8mqNWWSdTW0KmtQhXxv+K83i7nfsbPKQFDWrzRc0LmXCN01I6aodLo6Uul264Awc/UC+Wkoj+V7GbaDOENUTeWuW1CREhc0S/u1vRDj/sCjwfJmNHBjYA7NgL8PBbiJ497OFQY82DS/+04Vk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from Pavan-LT (103.16.71.47) by DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.386.5; Sat, 13 Jan 2018 05:06:54 +0000 Date: Sat, 13 Jan 2018 10:36:33 +0530 From: Pavan Nikhilesh To: Erik Gabriel Carrillo , rsanford@akamai.com Cc: dev@dpdk.org Message-ID: <20180113050632.cexa2hlfnscoq2im@Pavan-LT> References: <1515792665-6890-1-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515792665-6890-1-git-send-email-erik.g.carrillo@intel.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Originating-IP: [103.16.71.47] X-ClientProxiedBy: SG2PR04CA0144.apcprd04.prod.outlook.com (10.170.139.28) To DM5PR07MB3465.namprd07.prod.outlook.com (10.164.153.20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 12e91ab5-a105-4309-866c-08d55a4377ea X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020092)(4652020)(4534122)(4602075)(4627218)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DM5PR07MB3465; X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 3:xWzCxN1h10sAV2oqwy+eDe7UHt8UFLuOMW1VH9orRAuOydK+S6eN8bhbOkUqFxjAu5SfmDJ3GOaSH1xx7QCFEEltiTV7icE32OUBCY6ofI9EDIZ0Rw9PIjyWzVwc2FqeTrejQekr/s4BWbFt6u6g5c8RfRzgEYI037OpX41U1jvCTBVKtyWN60Cm5gMjx+3RFsltxQgPoi2GUKG+mHYNim6SzKpdMdV4lPH92NEAeG/7x3qssLSnnlsWT0nbghO/; 25:RWu2YCOU+kUFYW/7c9sFE0X+Kxbg2Apqs0zaFqYcLDu8HeadhWd3uZtYCuQ09V/X7AQ3qBfUJqwc4+i2Opj6BPFuO5+cpq6HStOKTzv18aDLRs7moSh3y+YvccIjDb1nk6mSKSPmdwuPZUjwcW3e/WoRkC7aIX8b9Jla3mU0b65JXdTfQPLCiEX5CgXuDjJnGusFG4XU5jo99zB09Of7qy6QaTMNA9MTXW919WRKg2VteXD1Pmdp25BL0S1+khXwN/emtbuZPPjtbv76yW7G3vKqBFgmwF2aYkFM4XiU4JKxz/DYBdJizqZMciiK6ZiVNioU+mELWlJBOgbMZevB+g==; 31:ndK6+6osj/WnlvomYNaZiKynjF7AN4Peq6j4y7oQywZGZcD4QGQt7cnJwT2Cym+fMfA2qfRmz/gGwOlqpVHH3zYw0C/nTmvvkn3jAZHX+fYIybAYvxWHZsIdSD8ecNwLnFBwxkYn0yT70+sIPK5Zf+r8qEZ38GXj5Ib1ewnSqh0OAufu+kjgnsf6Hce6kGGHK55oIXPhsUvmaq+rZSI4D3gffxAj3DavNY7ufNL36vo= X-MS-TrafficTypeDiagnostic: DM5PR07MB3465: X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 20:A9FbIOZMmMa0N8OOTh6X9/vKhH+5x7eYJfctF0bVcxlUdfLgrgpXx7tI+m2kpVryGztjiaq56FahYJxoOz2N7Q5L9EsMcSrKx72rdv5+P4IvUxoouOHNbkYKWJ9vAj9sVcQwJeJZ5EWBaklL/ePkSz8K3ZauazqGXv/mIfcd6HNq9ENf7KdYKv81PJ0dlhUMeA26FePxgJYJ5oWDP6q8GZ518PfU294N26s7YlWxCN05f1T46yhjBQvk/0I38jHxdCOr2uY7IkI6ruM/YBBTcIsYKWnZfK4uH/lYSL1vjU5ZjWNW3eDY2q/4/6GqtdITakKmTUMWSwj/5jO0CkGvEYLkqu6GdBkmfpLe+GVQMgZdINEGjOVrOBeXolksbA2pP7sC1OmXowbxAm4xPWXuuDgSLuTcCDG4dCwlOJPFvduXRNNNC40ck9oeM/h78Pj/LehIQIGgq/NRSzyMOsP/lr744/qsklUkGtqdHo1EAfXDf+g/K8gRqB2bbNPpqRpxd9Q1HDYtoZIA2duHTgfkoAeCloon9F7gXc3lcvc+LkjljSGWDesN8x+pP/DKyzJZn+J6dIUXA8FSL/QNlm+PArvevb9CGXGXxGiWQ+ysTZk=; 4:9K/abWdNaiDHgmG9oldlrsMBP2E+Ho2+sHxJumus26huSxOxbum9/FaChpq/uyI+fVYC0RWI/JLF6V4eBNFqpX98wvA7yuaEEdaXKGk16EnaO9qWX1CvmD9CDNwIyW44Otfv3D3BiWtaHWfoBu70xrpwS5qG6cE107+F5JajrzPhIfl6PgOtRdcLAx2kJvlTGIIHpSYpHLPWs+HTbg5uZPTlLV8gIGEAxfmMMTVEv75wYJp2fZ/mRRpSavUVaefWZuQmYTScloaqUABdsXNjw1d4Yp3NwFezUHzNYW7ieAKPpeMoE4YYWosut8/Iih7y X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501151)(10201501046)(93006095)(6041268)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:DM5PR07MB3465; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:DM5PR07MB3465; X-Forefront-PRVS: 05514B7026 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(39380400002)(376002)(39860400002)(24454002)(199004)(189003)(83506002)(7736002)(97736004)(23726003)(68736007)(5660300001)(6116002)(3846002)(6246003)(42882006)(305945005)(2906002)(25786009)(8936002)(33716001)(478600001)(72206003)(81166006)(55016002)(59450400001)(16526018)(52116002)(9686003)(316002)(6666003)(1076002)(16586007)(81156014)(386003)(8676002)(6496006)(53936002)(76176011)(106356001)(47776003)(58126008)(66066001)(50466002)(4326008)(33896004)(229853002)(105586002)(2950100002)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR07MB3465; H:Pavan-LT; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM5PR07MB3465; 23:PERZK/eQOErX93mgi2x7AW4pKe3KM6n9ZIZG0CI8t?= =?us-ascii?Q?36cxQ/bGVVO5ZsksEvYa0Xoy85mu5x2tvzAboiRkzbHJROig8s2dDyXEZwC1?= =?us-ascii?Q?rHGKxqM02KDCRrtNRzMT9n0fE7hoe/tPTjsG2Hmg9sarDu6LmB2axZRqyaIZ?= =?us-ascii?Q?CpdW+xXazUhyObQlKKxs+hGxqEg6YLWnYZ+0JyR/WefrU3EFMf9T6kA9LloD?= =?us-ascii?Q?7GGrgyMv6rT9+yOQn7r/Rx3g0W48sKV1RapCQuUunGc454NarQGT9EY3ScYd?= =?us-ascii?Q?lG6/b/kDE97aMs6ctMviQmudjzhLFxP7IkqvvymLbG07mgT/9pA5h4Vki8A+?= =?us-ascii?Q?72QB2EbxfRaI3QCjlUVhgKnzlyek35tuarf7FGSBT0uxeeyv51cEPFqMH2rF?= =?us-ascii?Q?lsTbypIgugpzcq5Glx/P/sSJICqN36GiwjEO6WRQY8gKTSePeeJDsgrhLFPP?= =?us-ascii?Q?dhgBB8WJaCStRZchJOi5qyUX4+A6GcxUUfiE2VZuyxpqxJG7tPET8dRrx0g8?= =?us-ascii?Q?STTl5cSsaasjXNrGONx+OtQEc1bf500qiFOq02J/QR5ua6b+MqqV02diATz9?= =?us-ascii?Q?+2//rC4z6TfTtM8+U/Hlc20dKSGxW0g3t3M5elqOgWKRmaJUItKEJ0eqEmKe?= =?us-ascii?Q?tOxv1cdUT2UuCe+WLw9EEkao4PsOdVnQhMpZZVvoQhlM28lIBGcSMFWyiwS4?= =?us-ascii?Q?xoiUn2ZyBcRRIRj4PwDQflqZfvwZQGRwO0xChP1pANPgkOaQmOjERFNV8as6?= =?us-ascii?Q?71y2bPHOaTYBYFyUZFMbAucs9GsCt5FWG5KDbmQswQQBqUkDtcvvh2sa8pSS?= =?us-ascii?Q?mUsWJjfJ86sTUkfaDV/UZ9yAatq0iooLjBenDJLmkHs4Stwmol6DrToluMkg?= =?us-ascii?Q?ZPL3GZGOVL/pMYP9pplBgfvZ/xdqIMtIO98flH696+Mf2vcIQ7q54+iqBt8Y?= =?us-ascii?Q?B4R17rGslUAdXFkJG428YGAOXArLYgA0rDXuBHZsr/V1CO8N/a01mfeBnlYy?= =?us-ascii?Q?aI7SdEambAzCzDeHg2wyW2hgNEqBeP3xAFQHz2rkQU/o4J7z1DGSGn7unyZc?= =?us-ascii?Q?Un/pPWTSa+kgDTyqXeTvqFU1+qmc3+03rzxaW6s9E0FUigP4V2fn3vfUCZxD?= =?us-ascii?Q?AgDwBajLE/QFKp7BQ8YrR+WchOHG+pD1D/hI5Tol3qNGxxMDEzq0B5vdekHf?= =?us-ascii?Q?+PPnC3q/122j8VJhqfPvuXMpuA65iWzO0phFJO51xr3MrD0dA/OWsBfBJXMb?= =?us-ascii?Q?AyJUUqkGRvUyCF347c=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR07MB3465; 6:gDokbS3X+trK9rny7+udwpZK59TIbwst7M14QPIlRaLSn2IwPWAT1x84tiSimgoaeR2cJH3dEKS0E8yBEOaaLFU35itcvwJ/jJo9VmI5evQktCnZW1hV4LWwNVtEpAkunO5nAkneXbpCeEMmJ/HAdUtWmmD5Dk/0T8aqW6UaD6ZvGYUD6P9+sNpQPSspQRS6KfVFrDWYZwqZ2Rkv38bV7gN71rcbjdkoFKvqyB3+MTlgQR9YgVr2Q1QtgDavfrU31rg22MB0ZRUngAgDjUBVtA+GjwtV5Myqf81HFTa+/YKhPH6n9h9jiBVHbde2JggQVXkEwq1nkCXp4KsjCPFDkfSZEhwx2Aksf9M+BrKOOvg=; 5:r/wqNoy8isQYgWz7ymqB2C8ArSbJBb1zRLuSA0Hto8m91d+BPuVh+/pXM7nIXMFmI1V6XiNCI78LJiJVcav9AOW2Ju9fFwJlUSLzIpSQgPRwbNi2WrfjibfazKBOsQ8SRJgXkHdHxtqDiZ/ynPNefD4nBxgOPVHk1n5OVPL/7v8=; 24:ZDHiQAbxcSAyglu70XvgP35XjJvsaj5/03SpYnT6pzpj9M9OKfZveG6MZ6if4IXG7I1U8iL8M/6D4apitfYFoC4JtVXU6+ccRrUHhqjbnUU=; 7:ZPDH+KNeVw9kFCyJtriONcDKY6WzMM2GH6VZdJqi8wc6gy72h20K9Kw1jWyqL0Q9JsctqT+EctacITp9zt9I8ICb2nr6C6pWLxhhjjz9ui2R/7d4hD+tnggVz8BJJ3W6U5CiyG3/2v0zoeY4XI+Fk9ANWF9LLOmBJsaG2RQm2nmG+HrNQjCY09mkpCF15BkUkzRMNcSAy4XNPIOfSCKjB7cXEXwRy1qs8W+Iii31M8wGpbpW1gROgV8W1gqTM233 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2018 05:06:54.7397 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 12e91ab5-a105-4309-866c-08d55a4377ea X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3465 Subject: Re: [dpdk-dev] [PATCH 1/1] timer: fix reset on service cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Jan 2018 05:06:59 -0000 On Fri, Jan 12, 2018 at 03:31:05PM -0600, Erik Gabriel Carrillo wrote: > The return value of rte_lcore_has_role is misinterpreted in the timer > reset function. The return values of rte_lcore_has_role will be changed > in a future DPDK release, but this commit fixes this call site until > that happens. > > Fixes: 351f463456f8 ("timer: allow reset on service cores") > Cc: stable@dpdk.org > > Signed-off-by: Erik Gabriel Carrillo > --- > lib/librte_timer/rte_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c > index 604ecab..4bbcd06 100644 > --- a/lib/librte_timer/rte_timer.c > +++ b/lib/librte_timer/rte_timer.c > @@ -403,7 +403,7 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks, > > if (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) && > !(rte_lcore_is_enabled(tim_lcore) || > - rte_lcore_has_role(tim_lcore, ROLE_SERVICE)))) > + rte_lcore_has_role(tim_lcore, ROLE_SERVICE) == 0))) > return -1; > > if (type == PERIODICAL) > -- > 2.6.4 > Acked-by: Pavan Nikhilesh