From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0074.outbound.protection.outlook.com [104.47.41.74]) by dpdk.org (Postfix) with ESMTP id D3F51322C for ; Mon, 15 Jan 2018 13:31:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=zaAPulo+N8qcXPkcVrTxd2h/auongVEACLCKB/emUR0=; b=BY5fIWswelyRlEeRByVbQDgTjuKPbandfo3qK94epGTuWD0QZ6q3zkrsv9/+YVS4Cr0v35UUoL9qb+ZU2kzxSpTaz0HyTuAIzPbpT0f7EHx+DjADQtOHSAxHjlLXye7MQ9ytCqQojyaMyQzk8LFCrwPOKwcP13pM+4rdHWS/vEw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.202.243) by BN3PR07MB2516.namprd07.prod.outlook.com (10.167.4.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 12:31:51 +0000 Date: Mon, 15 Jan 2018 18:01:33 +0530 From: Jerin Jacob To: Hemant Agrawal Cc: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com Message-ID: <20180115123132.GB833@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-5-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515996674-26338-5-git-send-email-hemant.agrawal@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [106.200.202.243] X-ClientProxiedBy: PN1PR0101CA0035.INDPRD01.PROD.OUTLOOK.COM (10.174.150.21) To BN3PR07MB2516.namprd07.prod.outlook.com (10.167.4.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc0a347e-1fd8-4dfa-7558-08d55c13f57a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:BN3PR07MB2516; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2516; 3:HpEu9zStg0FUXYaj0/sRJeBix0HSBrUqlAqZLXGzU79+XtdywGa2ra4Z65zqJ9Jw+Y0Yan0XvO/H/DtSzxmMYAjmzUnVnGHKH4ayl7ASLHY6bIJFacIPc1UjBr485bc9slLvqrwiAKyxm3W4YkE+j79+fhmgtSl/hRRzIb2CbEvrrIWxxzhyB+Ngd+bR3lZsGhq04JXeO1zHYDp9+vU0JCglfnyXdX/mkEGFacZBbBVSaLA5gb0zmSIW+o1Iq5//; 25:QJJx0YE19TqaKJK9tMAnyANXO7c+661S8bIE5saE/yljIsbbY0n9dvFRi1irUC//aa7J2IfrquqcIHgp+N6fFqGjJjZ2VO86msudqSddX/rNh7uknUMZKCitQrQIniSI8iS1sNU35v6eUCiJrcN/daBrPZJxby0u0XnhpJpLBRyArjaVymDLl6CNkwOWt7ss8sjTt2ArKievXE+rV++b8ubwe5PocMjhr7oAF6FhTRX2NdBG7dPqKDNNlLZDWOipfBOyqQo6XwXjzmuSyOeWkPMpZj1uF+PxRjZ0UODoU8AZ2u9wO35qsRt+FlvYEt1TeFsb9nYztqP8h/bdEzz1Rw==; 31:SPNskkefHJD4uVrM+NTW85+WWsSL/x0YZYgP+f9JkShucEmd8ILmMlipHHyoDol0DrtikBuEpVmy+Fw4X9EEq7bdko6XLji7Nuio55SxK9Tx49sMOX8PUSxS51nG32C7X33pvMY8Rhg9+dWb/8N9LOMub8/YF9u07QPcbEsSl/i5pyrXBAuQxmNUixocwMUMsvlroDfeievBhAG80q84WPZgNFLnldAxWfy4pBsiqzg= X-MS-TrafficTypeDiagnostic: BN3PR07MB2516: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2516; 20:gRZ5nkAJmt1Rl8lefoJVDnwAZCyWkXKnTh0iVbpqrE7MgMLsv+p57IPlBquBa6fj0mDVqHmZ18IW5fiF2g8otZ/SkGecAjExWSsNKNvU6UOXJCWMeLytJejtFPbmBTiF1oUcpor3fXJDi7gocZbACobHZkHDSSUihwPwRlm8Botu22pTOdhXJOgfwINl9rQe0cF+kW29OdPBw4Tq6t8L79YFcGAQ/n626VJrTNVMkSIAh/5rPRAEx0AQ323ca7GJutHSfE8uD83Zy4h3NNKAILOT71yW0tnpLJxezDEWhXZZjGav7mIGLrz2+s9exebJKZZmeJfMVVrsD4tj2lujKDvgIFswcfZvfT/c94iG/A0JwRGL0hHaGdhaI0GZyWjqSvEhwQXC6smOH76/nDkq8RDfTEPrWdX9FDN5edbmtkx6e0Wdl5LWHX02zu5LGuDukfm15QSeZq1aESW7vaWITv2TQtHIkaT70nTyWsBksNch1gMruZsvRj4gOoJILJB05EesjzsilRrdiY4NQ+/gU8StdS4XvKQMLzuEIX/FkIcbrGXRzOyIeTM9cblcG5AtQKUnYGrRM1PKXLsY3WegXq0ooheWwMzQujWK7WP4FyM=; 4:xU+mtwyP/heki+4ayT2MKwqir1TKiOFKTlm/7qPk+u0wNBJgZa12CfrufSzFXuzftoqJ5NRf6+7C7vkHE35TJUIJykyM/Tt5JBgqHVq+HJVXozvuiIsToOEdWovZVF6PCoo1MzvB1NxMgqSBzvu0wyIN0quRdWBB6YdrvLpaQW3wlcTlUYyj17Zx7S/ZXz2AtvIU/RZOSmi4HIbBx4+dODqh5Vo1Hdbo2agPgUBEMlO7J5sZd4gufqhwjQvT+bh78KYA/F1e8z9zpVaWIvuRZ5nuSZrtBQuyxzTgs3nghWbDpexWL0gcdpQc0Ut8GqBd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(10201501046)(3231023)(944501161)(3002001)(93006095)(6041268)(20161123562045)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BN3PR07MB2516; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN3PR07MB2516; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39850400004)(376002)(346002)(366004)(396003)(189003)(199004)(13464003)(5009440100003)(2906002)(106356001)(105586002)(50466002)(1076002)(25786009)(66066001)(6116002)(3846002)(4326008)(47776003)(97736004)(23726003)(316002)(81156014)(81166006)(8936002)(6496006)(53936002)(6666003)(7736002)(8676002)(42882006)(2950100002)(6246003)(16526018)(107886003)(83506002)(8656006)(68736007)(305945005)(72206003)(5660300001)(386003)(76176011)(33716001)(478600001)(33656002)(9686003)(52116002)(6916009)(58126008)(33896004)(229853002)(16586007)(55016002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2516; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2516; 23:Kq1mLffa7gm1x4gjS+54iKKF6mU14KUzWvhscK2Td?= =?us-ascii?Q?u1PTTEkXYfzP7aM323FZjXo/3bBnkjHIpfs45+1cpdAGai/6U7tjcw9axeuW?= =?us-ascii?Q?WZ8qjZviN1dKj0uxXJNssg2xtNCzzL/0piVnz6KysIOC7HINVnvXV1aJJBqc?= =?us-ascii?Q?H9gBSmawDfTi95NIdXFd0PaPKrDYSorCO+dRLnTsdiPCnQCL1FJoBddNKlsH?= =?us-ascii?Q?mu56XgSvENkF7UPIm1Q2Oekt9p2bUUiZpmpal7obJZhy5S5b8NGTVrLww4I8?= =?us-ascii?Q?sFGbweUN5Rp0G+Okze1XsdCD15eIPQPE6Eh6f+zj6GvaYTFyXTbKsNAq7yg0?= =?us-ascii?Q?iMVLjpzIEkQWOhu2Xl/fRKuYopnSdMUBkiJZkfRAMXqWfc0JdXKKbOhNphFx?= =?us-ascii?Q?SMzof4TdyeMAsvj7/zUSpler9gutjhcJH7S0QFKddBtmTSDQdZCc/LjYa/6r?= =?us-ascii?Q?N1uJCWzafKVQLlEMEXpg17i/Ugd2PGC+ryjlNa3cj5epkkODhHh7SfNwHFup?= =?us-ascii?Q?nceX6wj8IA4qLPIpEuNS2Kagxqnf8o23x4jcvQvCYlu0znGV+JFfAi5v2YUa?= =?us-ascii?Q?VaacLvC7WlmK6Xtx/aNCIW7ScNhMRh2jrt2S/S+f9Bx97Tra93txQs/tibBi?= =?us-ascii?Q?xM6zvROVwlJBleye2oNdxZqIlNqmebTpXiiZi2PYhEl1RfmcsMzBJ/MH6IJ4?= =?us-ascii?Q?ZKnHVh4LUe8sS0rfMvqP2ZYSrNCOz+VLLRa7fhfABohDw4UASlIbuWujAVsI?= =?us-ascii?Q?iG6SHmLAj3MT0naPA+613Vl44hfgYPw/kRwJjQKqDXv5XN1pvIM5WwiXyHK0?= =?us-ascii?Q?MFcpn/8N0QowKj8fmaPcafIcZ0ks41Wo+c/hLwqf42jBM9iZJAWyZs9hpXcB?= =?us-ascii?Q?11pk+G56HtEFgB3tcw3uNYpjRoHjHH78rhc+eOcKAIi2TvXRu4m8qeQNfFw7?= =?us-ascii?Q?ieLVFSKIJmioKtyxkO7Bv62hbQLtbL9ATYGAu2vZ7IW1GBBGDaUcB7UXNb5Y?= =?us-ascii?Q?ARYyFpzDjKRBi+JeuztsjMfLNLS5QyNLkXh8VlWpJX0DbwHkqwyZ/o64fMtu?= =?us-ascii?Q?dmjwSZ7LXKdPYFjfKnoddOGWKAsDqaiIo6d/XYNVhvnOivZZkZhmVBOVM70M?= =?us-ascii?Q?kdYD0dnk3psZrC90ADvUKex5/D9MRVQUU8Cx4Qjgkmpsw8lmsrAhKiYGsVhV?= =?us-ascii?Q?giOSJzG6ynDPnzntNi/yIq3quUhGfRQWtrx4Szgnki3MigKvkI2hwQ0EwoOo?= =?us-ascii?Q?q/OvnRrWMQYdyTb4GBuF2snBSNnh0Tn5cMF3osotA71M+M2pjo1gJylfuzzi?= =?us-ascii?Q?UfxK4MQrjsRiFGIzHHd75s=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2516; 6:4ZLeJFasovk1U7uxJwzI6jfgkv6es37j4yHC02NEukrLlwY/Q8zCyBQyx4RBkNvXjteKA26PgEjFtZtaiOid9gCQt3y+Iw5WT2IHXjI0dkPAoyatve97M8/MZHpyYLXplNvRHOr3jib+9vE4wKBg4hNzbadBRMRzjCHgo/oRYpPn7DYv65jap2yTIuXYj+C7+iuVxG5TPLhyh3Zl3JOhNFrKH/x4BZKIAkfqpfNkqAiIqVaLUUyDfszJF864/KSvfNClxhDcxMffNwQu4724Y7FsTBm6CZD3CJAtcQdgfHwENDcA9msCkzdHGawILUS6QZKWOIQJymhcCDsjPMMqrSImTjZx0Zo+Q3lDdPEEJKU=; 5:mnl1KDC65V94qSQM4eWbV+SQyk1fOSek/zL+JBwG4oCqPJDHEXhLTHdeUM934h96Wa/S4dnsc6HCpVWo6DESnNu5w505yZXrbw++lcReTAWb7j1M2gSvLQs1wTgGYVsQ5QIVEpAsA8TIMWbG+/iS567WRmBtu9pFOM3RdQuCUb8=; 24:9lvgCJlVcYLWAQqDllZgugFd8U2jPnhJ2FwXXx7hSzMb44+gqed0Z+ky45BU1c/kmsjaPyuSZ19rToOASNdYY2Bfx6az5slJVmmGrDF8lF8=; 7:q7vvGVDKjp3mmI5pcmhPkLNOKjZwgWG1KAo6enZM8zOHR/+ctIwd3+0lIkw+fQFvqsOlrJ2bVXurieCpgAsmHDL30pEKXzNwDk9keUcUn+/4DqpcTOp2PbMbfPk0mER/Ub1ggRbHAhjhXWqnQ0iUC0C+HBbQlE7jKv/S/tj2GkRqhxiJ0uciyzIo1B4ksW2HzaLyCSpTAHRqc4vy0JT6ysfrlIosBmlIgXO8KUF+vdEZAdSU7pjcZArgJXyqmSpE SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 12:31:51.6776 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc0a347e-1fd8-4dfa-7558-08d55c13f57a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2516 Subject: Re: [dpdk-dev] [PATCH v2 4/5] mbuf: pktmbuf pool create helper for specific mempool ops X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 12:31:55 -0000 -----Original Message----- > Date: Mon, 15 Jan 2018 11:41:13 +0530 > From: Hemant Agrawal > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com, > santosh.shukla@caviumnetworks.com > Subject: [PATCH v2 4/5] mbuf: pktmbuf pool create helper for specific > mempool ops > X-Mailer: git-send-email 2.7.4 > > Introduce a new helper for pktmbuf pool, which will allow > the application to optionally specify the mempool ops name > as well. > > Signed-off-by: Hemant Agrawal > --- > lib/librte_mbuf/rte_mbuf.c | 23 ++++++++++++++------ > lib/librte_mbuf/rte_mbuf.h | 42 ++++++++++++++++++++++++++++++++++++ > lib/librte_mbuf/rte_mbuf_version.map | 1 + > 3 files changed, 60 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > index fd3b6f5..482676c 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -186,15 +186,15 @@ rte_mbuf_best_mempool_ops(void) > return RTE_MBUF_DEFAULT_MEMPOOL_OPS; > } > > -/* helper to create a mbuf pool */ > +/* helper to create a mbuf pool with given mempool ops*/ > struct rte_mempool * > -rte_pktmbuf_pool_create(const char *name, unsigned n, > - unsigned cache_size, uint16_t priv_size, uint16_t data_room_size, > - int socket_id) > +rte_pktmbuf_pool_create_specific(const char *name, unsigned int n, No strong opinion on name. I think, rte_pktmbuf_pool_create_by_op() may be a better name than rte_pktmbuf_pool_create_specific() > + unsigned int cache_size, uint16_t priv_size, uint16_t data_room_size, > + int socket_id, const char *ops_name)