From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0054.outbound.protection.outlook.com [104.47.41.54]) by dpdk.org (Postfix) with ESMTP id 7F5D23250 for ; Mon, 15 Jan 2018 15:38:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7gJo5/TDvcCMCU4q7SA5GqydHuDIhPprSpSq0VaNewA=; b=NHqompYIc0J/1Hj+h+NDsCghX/aNHRKNbPQI9QQjW+BRzZxujupTdupJ8034CxJqQvqRwFiezowxEP93hSCRrElM/n+P4hIz/KSmQhAbOuV3OuGsxlK3NWOx2dF+C9oGIhJ/B1tYUgZIg8LQJnnBfkWyacqm8RrnPeV3gtZLK5w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.202.243) by SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 14:38:53 +0000 Date: Mon, 15 Jan 2018 20:07:50 +0530 From: Jerin Jacob To: Hemant Agrawal Cc: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com Message-ID: <20180115143748.GA27863@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-4-git-send-email-hemant.agrawal@nxp.com> <20180115114127.GA29114@jerin> <0eba08d8-543e-49d8-5dd8-e53afa5e5fc8@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0eba08d8-543e-49d8-5dd8-e53afa5e5fc8@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [106.200.202.243] X-ClientProxiedBy: PN1PR0101CA0062.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:d::24) To SN2PR07MB2527.namprd07.prod.outlook.com (2603:10b6:804:6::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05f4e54f-83c2-4e8f-ff71-08d55c25b462 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:SN2PR07MB2527; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 3:h7hPcYmXK4XECyeC/mkvuq5kaZGmWNJM0JLNSPMqHtcqBdAyDeXXOK947DlQG1jEVS37D99KBDLl7rr7UbO8eR9EKb8RFa73Dw1VOknJxjWrmd59euNcx3jj39Z5oXUiuD3hBIIVU59MyjFpxM+08gVXDwLG87BpCNThhZeV9YiCMoiWIkjR/xOSSO9VZJ04VA0vg18ksAAp6gIFVrBOSuJhD5snQSuSDMJ9bQQX0olUbUua2wd0DXsSRhZbO1Jg; 25:aY1dVVNCQZbT71F4upWG1azOOnf3M0NZfa1bW7wrBHNvUtzHo0hWIEb0ZPNB6WQALaOtJlAs3qYsaN264cfBqYLQqC2IVvhLlqrKizjx5C4afSOypCQLU1CXqIDRyAKhfFskHn2lqlxS4YYJColdcIXntNDn3UdosOkRa9COBcgaSmy6Brq/OLnbfqLAurL9mN6k9Xi3HCAPlTQKNW0gV9p4PTO/Pxs2pr2dO9njACoSpIJ2yq8IPmgnW2Z5Zm2yesMtGy8iY63Y6yklaNzKxnD2X7pzVJGKmIAGyxqRoSJOR8N99g4i2pgpUfRX7wTVBM5ujoDcfuBszmFmY6jzYA==; 31:WNjkCjv8pz5gSaUqJKrB5JE+lhO0joHimFQoiyN6vHGSzaZpl9Gz50no+WU0p1uYM56WVbD69QX2x4ZK2NCFfEoovX07obO4UPJSZJqzAmPlzGveYl2N0JWhNvwO9Cpb95A8V5eDYPrtTvEKT4znK5RmbyRWLsAvAn+zdtaAPUuNZbnjjRl/0ReYTYwun0ZWsOYnzoZEJ4w6R3Z+p4zwN+mCcAVfkT6zLmwvTUwYl94= X-MS-TrafficTypeDiagnostic: SN2PR07MB2527: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 20:TsfO6op0F8638wjpmDipRdlLz/LLY6weRAQfBGLDoEwAgI0BsA767VE4/9w0BwELOtbIqt/bPEPHGNvE4kJNtj1NWWLyepahxsS4/Rg1xfjwEqWb3yp+5tmQPWiW0snfc/jZwDgr4OQSndguh6B836jzxbDOv5CJTrH230H1XRiyUeYWJV6cz/OdUT/Gi3E4GCMndE2ZakvMEbAHibY9L81WUcKrC2K8/umzX8jF36ihM0FARuDhQsD+W2oY4juwbdymlLqcxj5hw3LCAZkYwlC2CCfRvihMALU5EQJMVastE79dq/rHrMC7OryHy02OTXKnauZW9yMcZyTPZykoNJ5Uh+dESBGbwRDTtJ6tXp6/EHApDoFfE7r1AWJmGZQm3M+a953aAUVgDIc8xcHebkPChDdJGbFz1uqzBrRvLKiwbIjcOBBhBTsV2HlnoTRpVHyf3d8F0Zgg9TBieTUAHNxIwAqSAQVDyGCPPz1laZZ2r5M1+irD/+fFHJ+6XvmpriVe8JKs8kqQ4DiFnGK3SHzrSqBeL3SVIX/oo2ZJee2tX+KH0ZRW1SmnQfEpLATbDo5SiiEyvPRL81/T7sx1I6WRtRr8jV0y8DTzbiBbBck=; 4:HKhN9b0OSvYPFL8FLR99YEgmG0/6jvXKmJSHUN5A2w17yU7LSvvEcgHGrDz4TCO/7pryF4NxdeEnafK8vIfriJJgdoiX9NVR0E2Leg6U94ocSSRJ2gOp1/gmo3tRRtVlkgDQ/zLw4DdVB6Op4BuVWskS3zlPbtXhWTp9SbvW4WqeNyqiNim5XRLptp/X3QMVAybu66XiaeVpc5fg9Ql4djYIn8PNBlRGiJFsIqkyZg6TZvN4IX1sA1K5OFsZo5fceRRs4EngVsqmHUlkX9j0LnKoXQqWBxi/OyaNdyGY4K/yc+x/FVbHvTGt/aEFafXC X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501161)(3002001)(10201501046)(93006095)(6041268)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:SN2PR07MB2527; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN2PR07MB2527; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39850400004)(39380400002)(396003)(24454002)(189003)(199004)(13464003)(53546011)(386003)(53936002)(33896004)(76176011)(4326008)(229853002)(5660300001)(25786009)(9686003)(97736004)(55016002)(6916009)(93886005)(47776003)(42882006)(1076002)(6116002)(6246003)(2950100002)(50466002)(8656006)(83506002)(58126008)(23726003)(16586007)(107886003)(5009440100003)(3846002)(106356001)(316002)(16526018)(81166006)(8936002)(305945005)(2906002)(7736002)(72206003)(52116002)(8676002)(6496006)(33716001)(81156014)(33656002)(478600001)(68736007)(66066001)(105586002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2527; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2527; 23:CeioUK9foXZgg7ZucwbjxJbUs9DB7q+uWc9D+l1wu?= =?us-ascii?Q?DZNlMNulrL4tpkRGcWRj372VzUKe4/MBdcx7bLUjJxoKIlcdaTNPgd5/IZx8?= =?us-ascii?Q?kzdoAcXxa49maChJnyJL/sG6e3ZVwj4Ik5M8lHLxbL2nDttp8skwbucBjAIK?= =?us-ascii?Q?ZlpQqj2lEfDoU7DcmmuJH8z7lPfYWkmItoCE0uTfHlCw3hiO8JP8ziNH9rA3?= =?us-ascii?Q?Jz6cXzgbkYA3fsZ7OQNzYKkoZMpurgvacBtQ8sePVf+Uf3ckcgCKC6WjOhgN?= =?us-ascii?Q?Eniojw96kuDlzJDrHeVWIGjsg1vu8SXEZUTXLvLB1germZ7xQisiNu0IUMWg?= =?us-ascii?Q?h3llxxuSl8P4EaNKlRMdtJXf5VEbBl1Ns7yiv8b/bEwPlnJlux3BDnr+jO04?= =?us-ascii?Q?pTWhndFmrCmdJ0gEhM/4jbc+3FJu0MNjzS+jYGLWRSxdsXLVpxJ7FsPKqQa7?= =?us-ascii?Q?5dV110px3N5eurw3OWKOZjp8aLFkVoOtsiTAdwqj3P2C2sHyIHa41lvSHs87?= =?us-ascii?Q?jOo0MEn7ETWkTIW3Cp6vUOE0CVMcHrIWO/dO4n1R2blSlff+WtUMty0dnkKe?= =?us-ascii?Q?hNlM5uVuOi0ojqW9W5dwOIoRLDVY+p9ExuGBPjMDOe7lZ72TXNm5s3HBqqbF?= =?us-ascii?Q?3UiOCbopU0U0um4GK+JIiVoab/xd8qng079JOWX0f1Y7qq1kBN7Psh5DSdzH?= =?us-ascii?Q?LJcejD85qswLYff2DVYnlscnmGRF9OWBdz6vHX8CWgaMThw7QlUh4uih9IV8?= =?us-ascii?Q?dAZnTdkjjPopmaoC0mLA0svyTzH2+blIdOsp7bXuUBrCD46Q/REefDbdSUDj?= =?us-ascii?Q?p5D8WI1SyYQ7fsfPDUAC8xVd0EMfXV6KrNgFI97Smonq4Gk0m8AUaFBRsJZ0?= =?us-ascii?Q?q/2n1QvuTZQz/0LrabARNk9hjwwnzaK1WXlSyljuPCBudccJhD+Z2dWKfh5K?= =?us-ascii?Q?7gLm995HtymO1pOLgZo59ZaC7SBCDhwZjnIQ6K++/V3HwwaBRIaUkiFkXjxr?= =?us-ascii?Q?itfzECb9rG0KcoESTl922n5bCTpiZeHdIC5Q/TpTxZYgdgMFdu+IgPNALL5x?= =?us-ascii?Q?PJWLFtX8MEM1lOewfkQmbsrSMRpNphbuzrFFQiOWCq9Yb4rwarlE/9VmNmx4?= =?us-ascii?Q?ClwIIAJzx3L72J64NN1fPn/WSPr6R3M1yUSETHtSjropVIn65MqJHX7ILMpM?= =?us-ascii?Q?/V8XImsTbATnFgmGMd6oPrgfmouq3nWmAnOE//DUdMfKrnfAr5MVa7vXy0vr?= =?us-ascii?Q?moVY5U0CiLPqzCWtF84zWjM00GK9PuAKtctQ7pEeEtfhHAQipHj2gUD9cyCK?= =?us-ascii?Q?LhP0hlV/9p8WOnnwA4bsVnjhJ7DcaGRStUi3E+/ySeCP05GJ/2Q5C9ka/eYA?= =?us-ascii?Q?lazGQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2527; 6:dOTZ3q0/3LFfGnAnnWCyoxMwx13MMXlw/t3C0K7tu14IZSiqd8QFMadlltq74UtiiCQCwj0gKlBIXdjhQPlkipnZSvr03APj/arkiSn355Hx8B2tL2kKdtvEPApZCPmI0QExpg0+jRFDu2PBZp07jp4f6htUEwBSTDwXBk6aj1vV5sOLhkEiZ6e2KuTqGbp7WXTbjAzaocudytaB9i42rUFz3zUzMMvt6may9jKfNQ3zSxm5enwyK2j/mzKQdieTE/ZRnZkDaqqvkx3R0fKUZVlws5oNCDsTxnlZCv6QHJFzOS5xj8ohONI2RnPkw69kMb8LCb83fTOMlCWLL7Hwr1ZqkXT6BuSCNW9CYFVdIh8=; 5:sNOevitIVnNcPO8iXhF89OETDrAdR0FqMvPLOxEWirWl4C1vF1glAxhbI9/6zpkEWjH6rYhF4YOfBLWcJ41gkpV01d6Q9qAZj/DtrYBh4J8JStybH+FxQgje7ATtZzcO9ZNfqDOQm76l2mVDZX2yehvSve1ST8ponz3GvSeVSzc=; 24:oLr/+ETZwcbltf2b7gGsvcEyoZXKUnFV/8wRmXD700vlpMes1f05R5uE4DTkgsIGnfEI6H7kJ0zyJLdWx7DvWBNOReIyKeHfZvuxuOFiDUI=; 7:H4i10WbckAGRAZir1kH/m0mg9yu0ORY99590Z7j/xq1fGI1oBubx3su2O4jBgZ4fdNHY9ENdylW1ViN9zL3sy21S/40reJr1vG+f2KACfIPtAkZBs63izKCMCZWeSCHDKBBCggEEGCDiQGC0EQRgnP42+i1Ad3g1rrr6RCy+4p46N+qmlvqDql07IyPulEFfxGsTPbLb5S40Z4kFPGrFjLgW8W06kAHMVLjTOcP2WMOOrg4JZm2ZBpPGKj58w9z5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 14:38:53.4756 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05f4e54f-83c2-4e8f-ff71-08d55c25b462 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2527 Subject: Re: [dpdk-dev] [PATCH v2 3/5] mbuf: support register mempool Hw ops name APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 14:38:57 -0000 -----Original Message----- > Date: Mon, 15 Jan 2018 19:54:36 +0530 > From: Hemant Agrawal > To: Jerin Jacob > CC: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com > Subject: Re: [PATCH v2 3/5] mbuf: support register mempool Hw ops name APIs > User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 > Thunderbird/45.8.0 > > On 1/15/2018 5:11 PM, Jerin Jacob wrote: > > > > > > +int > > > +rte_mbuf_register_platform_mempool_ops(const char *ops_name) > > > +{ > > > > Should we also check the following? > > > > if (internal_config.plat_mbuf_pool_ops_name != NULL && > > strncmp(internal_config.plat_mbuf_pool_ops_name, ops_name, ..) == 0) > > return 0; > > > > i.e avoid returning error if the same the driver but another > > instance(different ethdev port) updates the same ops_name value. > > > > No, there shall be only one default platform hw pool name. > Any ethdev driven (may be weight based) replacement shall be dealt > separately. OK. Who calls the rte_mbuf_register_platform_mempool_ops() and when? mempool ops registration is using gcc construction scheme so it will be called all the time. I thought, ethdev drivers will call this API on pci or any other bus probe() and if its in probe() then rte_mbuf_register_platform_mempool_ops() will be called multiple time. What is your thought on this API usage? >