DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Xueming Li <xuemingl@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] net/mlx5: revert "fix Memory Region registration"
Date: Mon, 15 Jan 2018 16:26:58 +0100	[thread overview]
Message-ID: <20180115152658.7bglhofuyj7vldgn@shalom> (raw)
In-Reply-To: <20180115065420.44065-1-xuemingl@mellanox.com>

On Mon, Jan 15, 2018 at 02:54:17PM +0800, Xueming Li wrote:
> This reverts commit 17fd4a504a4780455f79969803dc231521254ca8.
> 
> Fixes: 12ed59b702cc ("net/mlx5: fix Memory Region registration")
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>

Is it possible to have a more explicit reason why this patch is
reverted?

> ---
>  drivers/net/mlx5/mlx5_rxtx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index a239642ac..2eb2f0506 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -548,7 +548,7 @@ static __rte_always_inline uint32_t
>  mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb)
>  {
>  	uint16_t i = txq->mr_cache_idx;
> -	uintptr_t addr = rte_pktmbuf_mtod_offset(mb, uintptr_t, DATA_LEN(mb));
> +	uintptr_t addr = rte_pktmbuf_mtod(mb, uintptr_t);
>  	struct mlx5_mr *mr;
>  
>  	assert(i < RTE_DIM(txq->mp2mr));
> -- 
> 2.13.3
> 

Thanks,

-- 
Nélio Laranjeiro
6WIND

      parent reply	other threads:[~2018-01-15 15:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15  6:54 Xueming Li
2018-01-15  6:54 ` [dpdk-dev] [PATCH 2/4] net/mlx5: forbid MR registration in secondary process Xueming Li
2018-01-15 15:33   ` Nélio Laranjeiro
2018-01-15  6:54 ` [dpdk-dev] [PATCH 3/4] net/mlx5: support mempool of multi-mem segments Xueming Li
2018-01-15 16:29   ` Nélio Laranjeiro
2018-01-15  6:54 ` [dpdk-dev] [PATCH 4/4] net/mlx5: remove MR refcnt Xueming Li
2018-01-16  8:09   ` Nélio Laranjeiro
2018-01-15 15:26 ` Nélio Laranjeiro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180115152658.7bglhofuyj7vldgn@shalom \
    --to=nelio.laranjeiro@6wind.com \
    --cc=dev@dpdk.org \
    --cc=shahafs@mellanox.com \
    --cc=xuemingl@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).