From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 14515A498 for ; Mon, 15 Jan 2018 16:25:42 +0100 (CET) Received: by mail-wr0-f194.google.com with SMTP id x1so7918284wrb.5 for ; Mon, 15 Jan 2018 07:25:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=YIYPZlRwQ/P9sPEcQ33DiQBg865hIeaBh+9733c3XUg=; b=tcnv3xWI8pN1lGwHcofIi+NoHb43UZxI8sOTT0ZYAozIduCSaARlghvyi8wjiByS9G dgDOyLo4Sz75EpVdRDoaqqNtx0LNSASzBiI5eXi+skkpM3RJ0XWgTmZAmWRn/j3Xxksg vf2AV+tBBviJOmsu/YsPnaFX23scBrijC6NBWiL6DgCS8p3dfNnO3XmHfaCLd1VshU1g bi479M/Cd1UmdSXWQ63LwPDXiLwizZG6bmRkJrlizKkG+8bMx0N18uAd/JWWmPe/iBIK 782mb2D/Sr7TCfRQXCynu/XPvilUhFRlBuphdR3kOoJNJRR4z2eK9CwB34ShT5iRzmWU KVVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=YIYPZlRwQ/P9sPEcQ33DiQBg865hIeaBh+9733c3XUg=; b=a8awFIGSX9Uze1Qzh2nUQRcodhRhWCEDwwLpKdHP8aoaJ5XLthDbJjG24kNIieXIO1 O0Sox89hBIPMr266HsbbNSKKXmdgCZg0p8JlBpe3ZfP+wNREbcGAtjM31M7FN0KVr3sB 78NL6QOfQTJNHo7nxcF5KvjCGpq7YoIIJAxwM0GuhzSVxqNGRuwiD7a3Wop2Pnsk39eq ezatY2LH2aqYVZ0to6OCgGZWz0vV2q4cESJTA2xg1mdnI5amGB+Ct2UYA96todvfwgzk 2xgKPfvj93RX+3or+0J2nyt87Zbzvf0YwrlTzkXCUzi1ok3KvtyPNZY1EJeeBgaKY2xD Efig== X-Gm-Message-State: AKwxyteTKXLiwUq8sFTDRc4JTpmFcp/ZjZNnUYKjReOdpaySaHMW1KZ2 lYEWGlyh4YE4DH1wAIqBLmeV X-Google-Smtp-Source: ACJfBotOBxH5ut/sWlvTfqH/NgrqhmEMPjTDw7Mp4vEk7cPN3K/eWn1LlfSN4vYwG5t7eTqtVE0Tfw== X-Received: by 10.223.131.70 with SMTP id 64mr9627568wrd.30.1516029942719; Mon, 15 Jan 2018 07:25:42 -0800 (PST) Received: from shalom (lan31-h07-89-80-147-20.dsl.sta.abo.bbox.fr. [89.80.147.20]) by smtp.gmail.com with ESMTPSA id o2sm253823wmf.27.2018.01.15.07.25.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Jan 2018 07:25:42 -0800 (PST) Date: Mon, 15 Jan 2018 16:26:58 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Xueming Li Cc: Shahaf Shuler , dev@dpdk.org Message-ID: <20180115152658.7bglhofuyj7vldgn@shalom> References: <20180115065420.44065-1-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180115065420.44065-1-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/4] net/mlx5: revert "fix Memory Region registration" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 15:25:43 -0000 On Mon, Jan 15, 2018 at 02:54:17PM +0800, Xueming Li wrote: > This reverts commit 17fd4a504a4780455f79969803dc231521254ca8. > > Fixes: 12ed59b702cc ("net/mlx5: fix Memory Region registration") > Signed-off-by: Xueming Li Is it possible to have a more explicit reason why this patch is reverted? > --- > drivers/net/mlx5/mlx5_rxtx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index a239642ac..2eb2f0506 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -548,7 +548,7 @@ static __rte_always_inline uint32_t > mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf *mb) > { > uint16_t i = txq->mr_cache_idx; > - uintptr_t addr = rte_pktmbuf_mtod_offset(mb, uintptr_t, DATA_LEN(mb)); > + uintptr_t addr = rte_pktmbuf_mtod(mb, uintptr_t); > struct mlx5_mr *mr; > > assert(i < RTE_DIM(txq->mp2mr)); > -- > 2.13.3 > Thanks, -- Nélio Laranjeiro 6WIND