From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0054.outbound.protection.outlook.com [104.47.41.54]) by dpdk.org (Postfix) with ESMTP id 5D26A4B4B for ; Mon, 15 Jan 2018 17:24:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Dq4Lvl7VND7mL3GMXqlOj3odiyUfpjwVJntoAVsC73s=; b=kucmN6cURuLi0B3RoJ2i8cG3CZlvAl7I6Z9M6m97ugqUAIHPIdhSWnEQCc4VuAAGYUud3UFq+QGOhhT6wHq0XydWf44uhuJ04pQdFfXnco82mYfAIQqVBNQXBYeRcLtUY9fF/t+0eixoASzSSyPtJNMSd9AsSv3lfgyZs1nzqBo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (122.167.99.131) by BN3PR07MB2515.namprd07.prod.outlook.com (10.167.4.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Mon, 15 Jan 2018 16:23:58 +0000 Date: Mon, 15 Jan 2018 21:53:36 +0530 From: Jerin Jacob To: Hemant Agrawal Cc: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com Message-ID: <20180115162335.GB1245@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-6-git-send-email-hemant.agrawal@nxp.com> <20180115122944.GA833@jerin> <5d7e0a4f-7007-fa43-80f7-d84e822d8f18@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d7e0a4f-7007-fa43-80f7-d84e822d8f18@nxp.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [122.167.99.131] X-ClientProxiedBy: MA1PR0101CA0037.INDPRD01.PROD.OUTLOOK.COM (52.134.137.23) To BN3PR07MB2515.namprd07.prod.outlook.com (10.167.4.140) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd9ae56e-2050-4ae3-cfc0-08d55c346242 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:BN3PR07MB2515; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 3:56YDXPZ6HWvf/l5WXGo3gSk5oIihxK0YZ8s2uWnAJVYMGpHLclMy00w7YafjZRPbQuyffuE9rwV70xQykWKiL/H/XIgiwVC21j8R5TfVv8lrGDYHgqaD6BuRr+p0eY59KwJt17XHtHDhuLu5cTBSd9h4lTzUhYaHXp8y1IOSELKvhdX/DeD/UeZQNoHtFmAJiYriexF774lNaPIjey7zS3v8wGTb5ZWFVsWFml6h9setXTLqM4hoBTomqv/sZfTl; 25:S8H1kC4goVy0We/LnAAAlmwAY8w/vaOm8xqChbfmKJCe739F8+bak326ROIEpBFz22kknrFVk6vIPTdyI7M+f+6lxYIvESgRhobo4W408oahNe/lRAojkjJZeiuN2EUBkBQWZOIaUvSEFnkHWtiuefvmgXjd3w/nPbKTHnB95Vosj8XFYg3hQyGM0Tb66s0MbYA7UIKi25tj3iTHzaKQPAVYKaoaXNvKKudFAg+scWwpMf9tK55bfYxph6gF/fK2tDWYsP83cKh2e1Uj9TSyOR7ewYlZQlVjaVQgEF1MW910UX8yGQYAeUQFwQDqGP827b5V78CG+3QHxs4FyOvQmg==; 31:mUkYQ1O1sfWfBT1QaKX3gjmgvzGH71aefY2G+Ifqb1qYdsj+JtTVTldGm3IYEKzF6f0a0RkMo1cZJPkvpHcJ1JGCcz0D2LakZsx6Y8Q9PzlNnFxrFC/g8JQN9CGzC9gQBdYXnM4WtpIvbXK2bKXUZ9beQ8HRenLioIg/ebCM/NO2TCR7DyILqPWyyc76dLXFlCn+zpd25TqKFwsZ/yWQ9M365oLKiHeqYJBYO2fkFrE= X-MS-TrafficTypeDiagnostic: BN3PR07MB2515: X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 20:hw0AZJcuZNA7pcha2Rncr40AIxkmMeqVnMg3Ml62aglrbL2bMN9QAE3ElOO1pnoIZ1w/cPFSnBg2Tl4E5BiKkPOJmLmvAqfFlThlN8pLmxumWFBxe6OtnHRry/+ZHk9oP3VmNNZ7vwMnxU7pw5naZE8OehN2al04MfvqYxNf0onyu264YI2xw3b/HvZd6mwmCyznPPq35kPv3mjo4owPsiv93Go1iknGFlpZa6e3HBkF0cdU/DdyBFRxUyPmVnPxuEFv8Xi4naX+35ITItUc4Hbnvgr1N5M0pI+s/QQ9jN989mZYEy9mkVMRSNx08+kYFdmsCFVOtQr8+DVbNNB4JD3E9wZ8muGBLm6wcx78kS14J+ZJyiKlP8OH8RQ7qoCBP7FsNVgVkPoCBXvimZcmapRQlvm7szgr9IHAK8GzmgpXa2D3EBQ9wtISiLthmeQLZ72/mdabw21NNPOoxtJsxDQ2QeTJevlem5OwYgOWxzRGsKtVhOCnQidY6x+9XTTh9sJCuJwXSRy7CrHGY6ETEwff9nwLQU5NMd1siLyZNIDrFD1CLtIe7J3Q4FY2QJ0c/r9LasAjUbttT68xKAfl6aZjhnKvR2rDpCKpWC0C0Io=; 4:fiuN3PX8V90NYGbintoYa8To4bllmkMTYPKBUguWDTAN6+YPtw5sNalzaaN0ZxMAsNlf+13BXLtKq6JDVQt+4Z3hGUGklW9OZWeOaj7gX8UV5QlIUbp89JfnFz3wFwNS1UmmgNJfRD23S6BQwXaFUl4Tym+LM2d6XCKJO7qEU5dq56Ko13DSDUNlpnfx2g+qt3oVUOlmr8QYsOwwO1Rhksd2Eq4Nt7WJ+znQlp7hMjjjNNWLb+/aPcZcQ8UWNXwjiRbYC4rrHFPdqgjA5Xnh5C9lEKjDyQ/6gHicD6Yz2Qn32+FqcwYeaamJQmFbolKo X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501161)(93006095)(10201501046)(3002001)(6041268)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011); SRVR:BN3PR07MB2515; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:BN3PR07MB2515; X-Forefront-PRVS: 0553CBB77A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39850400004)(346002)(396003)(366004)(376002)(39380400002)(13464003)(24454002)(189003)(199004)(68736007)(53936002)(5660300001)(9686003)(7736002)(47776003)(42882006)(6666003)(8936002)(81156014)(105586002)(81166006)(93886005)(66066001)(8676002)(305945005)(6916009)(2950100002)(25786009)(106356001)(33716001)(6246003)(478600001)(33656002)(33896004)(59450400001)(316002)(229853002)(55016002)(16586007)(97736004)(58126008)(16526018)(76176011)(6496006)(107886003)(3846002)(1076002)(386003)(2906002)(8656006)(6116002)(4326008)(52116002)(83506002)(23726003)(72206003)(50466002)(53546011)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR07MB2515; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2515; 23:+RNyIwdgvS/3WMUGRJDBMi5p+vjO4tHx8loUqy9VG?= =?us-ascii?Q?Mg10fSWTCKEYpC687qXOk+UI4W4TcW9ExemSLc/Pyw+wHhKjFS4KlkV7qqNd?= =?us-ascii?Q?+WXmy6CFqXXpG7e9pZ0hHmdhnAHGt5ioF1o3NHRB9s5lJ33zIM1A0gW+EGqZ?= =?us-ascii?Q?JFIlfShFMYRa31AD4WBmASk7Sbij/1A7GtbRcyi4Itd5mNL936dAfusI3kaX?= =?us-ascii?Q?MuNpZgCyy2ArS8VBHEzI1IfWMSJd1IxRC5YOu+vZG1aBTuoXCHii+L64DSiL?= =?us-ascii?Q?29ZKOJE/d7Xmc5foccpZRLFE1kQoF8NwiwrTNJNd3xLc/jr3tIAdKtHPCDem?= =?us-ascii?Q?NAo023HU2UmPFlTh+GkcxChI2b2Fiu6nulzjrVHO3EyE7hPPl15JQ0EJVmg6?= =?us-ascii?Q?AdCudtgtkCBitnn7dZ0Z70YaRsi8oOCxyH6mv8pLChxCu5dx9FuxL/AwaXmL?= =?us-ascii?Q?wVolR7sIsUSw1arH4oCUKMfl3bJSquANzhNK72HRAjeO0h2pi19N0zG399Nb?= =?us-ascii?Q?tHkoKovI5y8pZlpa5znSE26QmfkbLKTSVbNvrEt00e8volgFDk4ytwhIIieO?= =?us-ascii?Q?cQ/LcbQX277/othxiPv89wIzXHTB0B20e4OYDgyovaVTCCvkYEGMIjviNjXW?= =?us-ascii?Q?G3pmp54Vy3dEhLZk0aCI6fvqwRyPRuA0lY8a8l89M2TeK0YqwN88iNH6NSQA?= =?us-ascii?Q?adAh1q2q2UKhzN4DiH+10/BeJUu0o01pIGvoBh2BW/ZOp3YuK2vUGVgEefU5?= =?us-ascii?Q?tIRTRdFjjmZTADYVoWTWcJQ9w+Dnllf9SUYvMq5wRhtcOLdDlqTL9ERzCdIN?= =?us-ascii?Q?ERFcgvsWcLtyOyBBB0Fv8us70ABiB/GQCTlZOt3F31/nyFHEdUrKtEk53DCv?= =?us-ascii?Q?icc5InCZAvsGwzoXW9i0Ut6+7TVxOHKrhHp3FvPfEwcVWvrXRX1o+lSbMFyY?= =?us-ascii?Q?fCOoEYXtIQUWdYYpR+PUxRmAApCHkfVIsSbM2CaV9F9dGD/36B27Ve62eP/O?= =?us-ascii?Q?oVUueby2J/MpeGA7VFY4d3KtADAO9DdfwqZ7w2HM57oIPkqxAbsmA0o43G0w?= =?us-ascii?Q?3s7vPH9SEnZrUzQchP7a2WgFq0i1LJ69nwRrOTjbXSpeCrP8NyTgy5qWWsQL?= =?us-ascii?Q?kZpAZoyYuyGAReJ4be/DBVKGrm0UWn3nUAfb99OolKS9ikwmB+7Qpklu1md+?= =?us-ascii?Q?3ZOnaI0uTNQkSz6fv5ISz2riz6MAM6HDxkzG+3UzC/Vv6tIVuO1ea4NzIyVt?= =?us-ascii?Q?HdHOTl35S9I4h6/SKU+qf/cjP4EzylUT7Mdgl7FAdN9a6H8XLEen/WoEpfMN?= =?us-ascii?Q?rR8wyDK7Tau4BNaD4LRtLL7MzWOU/l8xgvmHjEj2Gr2oIiJb/am4VC4aP1iB?= =?us-ascii?Q?k2BzlwO6PW0QTu8p5nq4bjaKtY=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2515; 6:KT7EoYfUHKlu9VFLpacPBw5izuAeD0nQwMd2PdAcK6eEMMih8yAm6k9F49Ah+/4QYsyiO1cm7wbcgeExx12OAUVnn7dpHWRMAGdul2iTz0Ghz8GPwoNKSVKf/vO+7ZIc7o9lwDPF0ffKZxTuEfn6auXlxcckQFJA8VzhxkvXjR7zXqsrdFJm+UGkfNmJVS7c4JZWuM16ABMqqdWfoA7ceN8PGqQfRwO/LSFeO463mZTCm5iq/NBgK/youbX65RPuQhhmlUoSV8g4zjryBPRk7R60VzuLpaXAsdzyHZF9Jr9hBl5+EXFrqBQYmLcaAY98yaRHZVwBVq4zKsW7cUJJxQUPzlYPFfmyOjrhjr2SiMw=; 5:6zoWxTbQ9hZ4v/St0kz093F28Ir46p+QQcyN2hM6F+Avl6ZyXT1vlXWER4pehZtWC/4GvUer6NlRe68usHTS8KnIvVtPJAmjdX0fIcN7+whWStywWutpnMejce/6KbpKLn7DgdDSiGyPYlSEy3B+3VKW3hlVhrTSVRRtOh9MIYc=; 24:L2tua8ogNtpCDFl4VlVSx0Ie/IDhe5N0mOwhHPCWus4QBBoYRCUOI6YrmR9kxylQgXyqO84WrxBmKbaIYutgZcrT4qJ43hL/go1IcXQY0d4=; 7:29yREycgA7uoBiiLWwNnF2uOOdjTRsKO+VKKp5VmOskcxL9YV7lFV0GhJb9KDLyXxI9EUKO6KBLF3xaxXUp+i3iIhBzRHGl98GGtgrrbpRnLoZ3S37iG6TFAuta6PWs+i5jQ74ON62HtcLl1uiGn6WR22jX84z1fSJWFF3aeyKIfyPeQlvEbF+T4mg4raCpn/YG8K/IUlwW9bEIF0tRYpVkB6G7HCEe0HV483Ex/5aawrmA6J3tXLIf5nfiSiuy6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2018 16:23:58.5452 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd9ae56e-2050-4ae3-cfc0-08d55c346242 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2515 Subject: Re: [dpdk-dev] [PATCH v2 5/5] mbuf: add user command line config mempools ops API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jan 2018 16:24:01 -0000 -----Original Message----- > Date: Mon, 15 Jan 2018 20:05:16 +0530 > From: Hemant Agrawal > To: Jerin Jacob > CC: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com > Subject: Re: [PATCH v2 5/5] mbuf: add user command line config mempools ops > API > User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 > Thunderbird/45.8.0 > > On 1/15/2018 5:59 PM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Mon, 15 Jan 2018 11:41:14 +0530 > > > From: Hemant Agrawal > > > > This patch add the user command line configured mempool ops name > > > API to librte_mbuf and sends a deprecation notice to remove the > > > similar API from eal. > > > > > > Signed-off-by: Hemant Agrawal > > > --- > > > doc/guides/rel_notes/deprecation.rst | 7 +++++++ > > > lib/librte_mbuf/rte_mbuf.c | 8 +++++++- > > > lib/librte_mbuf/rte_mbuf.h | 10 ++++++++++ > > > lib/librte_mbuf/rte_mbuf_version.map | 1 + > > > 4 files changed, 25 insertions(+), 1 deletion(-) > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > > index 13e8543..ec8018f 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -8,6 +8,13 @@ API and ABI deprecation notices are to be posted here. > > > Deprecation Notices > > > ------------------- > > > > > > +* eal: a mbuf specific API was part of eal APIs. This is now being > > > + moved to librte_mbuf to be with other similar APIs. > > > + The following API is target to be deprecated on 18.05. > > > + > > > + - ``rte_eal_mbuf_default_mempool_ops`` replaced by > > > + ``rte_mbuf_user_mempool_ops'' > > > + > > > > I think, deprecation notice need to be in a separate 'doc" patch. > > Yes. you are right. > > .. > > > > +const char * > > > +rte_mbuf_user_mempool_ops(void) > > > +{ > > > + return internal_config.user_mbuf_pool_ops_name; > > > +} > > > + > > > /* Return mbuf pool ops name */ > > > static const char * > > > rte_mbuf_best_mempool_ops(void) > > > { > > > /* User defined mempool ops takes the priority */ > > > - const char *best_ops = rte_eal_mbuf_default_mempool_ops(); > > > > I think, we may need to remove the stale rte_eal_mbuf_default_mempool_ops() once > > it is replaced. > > Do you mean that till the API is not deprecated, we shall keep the usage? Yes >