From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <wei.guo.simon@gmail.com>
Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com
 [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id 9798AA48D
 for <dev@dpdk.org>; Tue, 16 Jan 2018 03:13:39 +0100 (CET)
Received: by mail-pf0-f173.google.com with SMTP id j3so8907219pfh.8
 for <dev@dpdk.org>; Mon, 15 Jan 2018 18:13:39 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to:user-agent;
 bh=x3MkDkvDBrQE7h8sI1ufcTlzimtuk6oMhIpJvqw6WVg=;
 b=n1y/3QJu0SDr+kU3R4JfBmjIzqY/eE+t8M5NY3Z+LVxffG263skhqOkGKw3aLGfoUz
 1LrNE6aNqMyF7QAchqvkg0jKGw42FBIiNUG7BrnEyAYC/fC8UcjXHoTkXwk7jzMR4mQ5
 0IUc7Cr6SlBrYWdU1PHM/wRVYdNZNqHjgLED0Tcw2CVWWDHpsdhmPBMj55KTdDdnzuAQ
 oY6wAd1XzhAqdQZxyB4qT67AiMH0HiI01gIgRzPDtS0VzYIUpVtqkBss5gVHmNaILaOn
 lDT9GS6iJcfVROxpXlm3tv7QcpDHcSNDUi8uvBGamCdzSUw+xZW9MD8HAsGicqdY0sWN
 eZ2Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to:user-agent;
 bh=x3MkDkvDBrQE7h8sI1ufcTlzimtuk6oMhIpJvqw6WVg=;
 b=t3nbR8MMsTUfQEeE+DN8468UPLK9MY3s+ZuneT7KofD+fM3VlWK0REr0qg9kj9AZxE
 kXJ/BNYsjHT0yDB0AUBXuIjqXw5C33W+X9LPCwiSdhaqQGa9D4dlSpaIGiACvW7mitc1
 ufwdDqe0/Pn1e7lVejN4DlZoxvsDTr455MVO7xnO7rLj773CUtTW9erI8JCv/7fyBP4N
 ldbXUvXZKp+Lw0FlRGUeITeO9MCTKaptpYVI4kjsN/jjkhIQZjZi047MhIkZJBvNTJT2
 zO9eZjQj7lcJw0mbe1D2wa1enj5PI3Wm3L05U9WLc+62/M5YR6kITNcVuWD11p3Ua1At
 VMtg==
X-Gm-Message-State: AKGB3mLgADa3tmplUFIp54ix8TdAr4oMGQOPv32tMsbGvJF5950olYfY
 98OsUlh94Ez0ds/wpmZ7Wjs=
X-Google-Smtp-Source: ACJfBosrz7pOuqOQDigbVsot9kOGnN4XUnxpVnFS4hnnEMo/WC+NCgutSaYN6X/SBEH0x3t1/elUzg==
X-Received: by 10.101.101.200 with SMTP id y8mr27949284pgv.0.1516068818916;
 Mon, 15 Jan 2018 18:13:38 -0800 (PST)
Received: from localhost ([112.73.0.87])
 by smtp.gmail.com with ESMTPSA id j14sm992436pfh.94.2018.01.15.18.13.37
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 15 Jan 2018 18:13:38 -0800 (PST)
Date: Tue, 16 Jan 2018 10:13:36 +0800
From: Simon Guo <wei.guo.simon@gmail.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Message-ID: <20180116021336.GC2609@simonLocalRHEL7.x64>
References: <1515571177-24040-1-git-send-email-wei.guo.simon@gmail.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B7109A8@shsmsx102.ccr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B7109A8@shsmsx102.ccr.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: add option ring-bind-lcpu to
 bind Q with CPU
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 02:13:39 -0000

Hi Wenzuo,
On Mon, Jan 15, 2018 at 08:31:52AM +0000, Lu, Wenzhuo wrote:
> Hi Simon,
> 
> 
> > -----Original Message-----
> > From: wei.guo.simon@gmail.com [mailto:wei.guo.simon@gmail.com]
> > Sent: Wednesday, January 10, 2018 4:00 PM
> > To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> > Cc: dev@dpdk.org; Simon Guo <wei.guo.simon@gmail.com>
> > Subject: [PATCH v4] app/testpmd: add option ring-bind-lcpu to bind Q with
> > CPU
> > 
> > From: Simon Guo <wei.guo.simon@gmail.com>
> > 
> > Currently the rx/tx queue is allocated from the buffer pool on socket of:
> > - port's socket if --port-numa-config specified
> > - or ring-numa-config setting per port
> > 
> > All the above will "bind" queue to single socket per port configuration.
> > But it can actually archieve better performance if one port's queue can be
> > spread across multiple NUMA nodes, and the rx/tx queue is allocated per
> > lcpu socket.
> > 
> > This patch adds a new option "--ring-bind-lcpu"(no parameter).  With this,
> > testpmd can utilize the PCI-e bus bandwidth on another NUMA nodes.
> > 
> > When --port-numa-config or --ring-numa-config option is specified, this --
> > ring-bind-lcpu option will be suppressed.
> > 
> > Test result:
> > 64bytes package, running in PowerPC with Mellanox
> > CX-4 card, single port(100G), with 8 cores, fw mode:
> > - Without this patch:  52.5Mpps throughput
> > - With this patch: 66Mpps throughput
> >       ~25% improvement
> > 
> > Signed-off-by: Simon Guo <wei.guo.simon@gmail.com>
> This patch is fine. But for the new parameter, please update this doc, run_app.rst. Thanks.
ah...yes. I will rework on v5.

Thanks,
- Simon