DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: Georgios Katsikas <george.dit@gmail.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Adrien Mazarguil (adrien.mazarguil@6wind.com)"
	<adrien.mazarguil@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline
Date: Tue, 16 Jan 2018 09:39:58 +0100	[thread overview]
Message-ID: <20180116083958.hk4rtxfoa2y3uydk@platinum> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B710648@shsmsx102.ccr.corp.intel.com>

Hi Georgios,

On Mon, Jan 15, 2018 at 01:30:35AM +0000, Lu, Wenzhuo wrote:
> Hi,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Georgios Katsikas
> > Sent: Saturday, January 13, 2018 5:01 AM
> > To: olivier.matz@6wind.com
> > Cc: dev@dpdk.org; Georgios Katsikas <george.dit@gmail.com>
> > Subject: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to
> > librte_cmdline
> > 
> > Signed-off-by: Georgios Katsikas <george.dit@gmail.com>
> Looks like a good idea to move this code to the lib.
> cc Adrien the author of this file, app/test-pmd/cmdline_flow.c.

If the command line parsing of rte_flow is something that has some
chances to be shared among multiple applications, I agree it makes sense
to move it in a library.

However, my opinion is that it would be better to have a specific
library for it, like librte_flow_cmdline, because I'm not sure that
people linking with librte_cmdline always want to pull the rte_flow
parsing code.

  reply	other threads:[~2018-01-16  8:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12 21:01 Georgios Katsikas
2018-01-12 21:01 ` [dpdk-dev] [PATCH 2/3] app/testpmd: Added new line and parenthesized macros Georgios Katsikas
2018-01-12 21:01 ` [dpdk-dev] [PATCH 3/3] lib/cmdline: Cross platform fixes for cmdline_flow Georgios Katsikas
2018-01-15  1:30 ` [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline Lu, Wenzhuo
2018-01-16  8:39   ` Olivier Matz [this message]
2018-01-16  8:45     ` george.dit
2018-01-16  9:24       ` Olivier Matz
2018-01-16  9:49         ` Gaëtan Rivet
2018-01-16 14:31         ` Adrien Mazarguil
2018-01-16 14:54           ` george.dit
2018-01-16 17:54             ` Adrien Mazarguil
2018-01-24 11:57               ` george.dit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180116083958.hk4rtxfoa2y3uydk@platinum \
    --to=olivier.matz@6wind.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=george.dit@gmail.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).