From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 408752D13
 for <dev@dpdk.org>; Tue, 16 Jan 2018 10:24:31 +0100 (CET)
Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231]
 helo=droids-corp.org)
 by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
 id 1ebNTq-000839-Ak; Tue, 16 Jan 2018 10:24:31 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
 Tue, 16 Jan 2018 10:24:25 +0100
Date: Tue, 16 Jan 2018 10:24:25 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: george.dit@gmail.com
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Adrien Mazarguil (adrien.mazarguil@6wind.com)" <adrien.mazarguil@6wind.com>
Message-ID: <20180116092425.h4qecfmki2ih5shq@platinum>
References: <1515790887-64502-1-git-send-email-george.dit@gmail.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B710648@shsmsx102.ccr.corp.intel.com>
 <20180116083958.hk4rtxfoa2y3uydk@platinum>
 <CAN9HtFA2Rrhx2OqLJLL4F_M1mF8QFksD8EC_XAW+sOZ1QQp-FQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAN9HtFA2Rrhx2OqLJLL4F_M1mF8QFksD8EC_XAW+sOZ1QQp-FQ@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to
 librte_cmdline
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 09:24:31 -0000

Hi,

> On Tue, Jan 16, 2018 at 9:40 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Tue, Jan 16, 2018 at 08:45:32AM +0000, george.dit@gmail.com wrote:
> > Hi Georgios,
> >
> > On Mon, Jan 15, 2018 at 01:30:35AM +0000, Lu, Wenzhuo wrote:
> > > Hi,
> > >
> > > > -----Original Message-----
> > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Georgios Katsikas
> > > > Sent: Saturday, January 13, 2018 5:01 AM
> > > > To: olivier.matz@6wind.com
> > > > Cc: dev@dpdk.org; Georgios Katsikas <george.dit@gmail.com>
> > > > Subject: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to
> > > > librte_cmdline
> > > >
> > > > Signed-off-by: Georgios Katsikas <george.dit@gmail.com>
> > > Looks like a good idea to move this code to the lib.
> > > cc Adrien the author of this file, app/test-pmd/cmdline_flow.c.
> >
> > If the command line parsing of rte_flow is something that has some
> > chances to be shared among multiple applications, I agree it makes sense
> > to move it in a library.
> >
> > However, my opinion is that it would be better to have a specific
> > library for it, like librte_flow_cmdline, because I'm not sure that
> > people linking with librte_cmdline always want to pull the rte_flow
> > parsing code.
> >
> >
> Hi Lu, Oliver,
> 
> Thanks for your feedback!
> You have a point here, flow commands are only a subset of the parser.
> Do you want me to create this new library and send another patch?

Let's first wait for Adrien's feedback, he can have counter-arguments.

> I guess I have to use librte_cmdline as a template/example for creating the
> librte_flow_cmdline library.

It can be used as an example for Makefile and .map file.