From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 6E33AA48C for ; Tue, 16 Jan 2018 11:24:31 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id 141so7415325wme.3 for ; Tue, 16 Jan 2018 02:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=wH3w9d2CYh5Ix1ju6mzrnE+IVoSXPPpAQl9R3zpbhec=; b=Iq9bs9i2WIxgHbYOTB80Eihg6sNiEZ0MPESN3Zyz9hQ9TFfjWQp/Bc+L/J/YA0UxcV kgySUZah+b1Z2wEY2+Sld8Kd5BxAFPrR+wyeUwDFAGoQmgncuQtSJEkq4OU2IWPYouxB BilStragvDepooQ8/jF9NWMd1oTdoXwxqcfg9ISb0lVKiwPu48HGwDt+GrgivWgDIUTd yef5CBEVVpp+pcxF9v/hLAJqit4ybEW/tCvhIIsX1xhxlzhqzBymQ7re7TRvTNaNWvrg lNvM+ikQx9/yyiqjbhm+BWtvZeLllr48eJsf3ke7Plt3Hzk9bvevw+rvEECDw0f9OPpe hlSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=wH3w9d2CYh5Ix1ju6mzrnE+IVoSXPPpAQl9R3zpbhec=; b=gMELq/HRKd9FA4NXxFa3Bf5Dj2z/4tSkPJbvGtKzQKqujadB7gII4JjxF/Ph+ws9AL IgSsnkHspUKJvr7qoOdMJEh2PlRTs7py8GTDYPlakT9wgK+ZHbJRM05yuJbT/R+Demk5 gJT8DIFNr9wUDogwF5r+Qz84rppZvDgFJ0AdGhCwJhH0UKSKZdEfnkU+1/IExOdceoLQ TnFyjoM9NoSIXyyf1mf6JRycv00JWujSDaN3uAY/0S5qWujFx9LM+6tefKmwDwWV6mCZ D3iLgA/eSk8kkszGrLQgW69VTXVcx8pMiYboO2PoUifSByob4mpyKL0yzWwtDrCi4/tQ KrAg== X-Gm-Message-State: AKwxytc3XJahmHo8o7GRV9pQ7IelM91+u6qDr3yL3dBsS/1rWvluX06P PloqtzgLZ4XsdfZudtwzOCTFyw== X-Google-Smtp-Source: ACJfBotrlioERH1KCCsVTWYGnwHTpnCxRq3JxR9Y8+hlME2vniSU+x2p8onbwdsoJOcNkgXx8nNoZg== X-Received: by 10.80.134.40 with SMTP id o37mr26367327edo.62.1516098270906; Tue, 16 Jan 2018 02:24:30 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a5sm1309253eda.56.2018.01.16.02.24.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 Jan 2018 02:24:29 -0800 (PST) Date: Tue, 16 Jan 2018 11:24:17 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: Ferruh Yigit , Thomas Monjalon , dev@dpdk.org, stephen@networkplumber.org, Adrien Mazarguil , stable@dpdk.org Message-ID: <20180116102417.zwno5vpz7lpyqbmw@bidouze.vm.6wind.com> References: <20171222173846.20731-1-adrien.mazarguil@6wind.com> <1515509253-17834-1-git-send-email-matan@mellanox.com> <1515509253-17834-2-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1515509253-17834-2-git-send-email-matan@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/failsafe: fix invalid free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 10:24:31 -0000 Hi Matan, On Tue, Jan 09, 2018 at 02:47:26PM +0000, Matan Azrad wrote: > From: Adrien Mazarguil > > rte_free() is not supposed to work with pointers returned by calloc(). > > Fixes: a0194d828100 ("net/failsafe: add flexible device definition") > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil Acked-by: Gaetan Rivet > --- > drivers/net/failsafe/failsafe_args.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/failsafe/failsafe_args.c b/drivers/net/failsafe/failsafe_args.c > index cfc83e3..ec63ac9 100644 > --- a/drivers/net/failsafe/failsafe_args.c > +++ b/drivers/net/failsafe/failsafe_args.c > @@ -407,7 +407,7 @@ typedef int (parse_cb)(struct rte_eth_dev *dev, const char *params, > uint8_t i; > > FOREACH_SUBDEV(sdev, i, dev) { > - rte_free(sdev->cmdline); > + free(sdev->cmdline); > sdev->cmdline = NULL; > free(sdev->devargs.args); > sdev->devargs.args = NULL; > -- > 1.8.3.1 > -- Gaëtan Rivet 6WIND