From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f51.google.com (mail-pg0-f51.google.com [74.125.83.51])
 by dpdk.org (Postfix) with ESMTP id D20A11B351
 for <dev@dpdk.org>; Tue, 16 Jan 2018 19:29:09 +0100 (CET)
Received: by mail-pg0-f51.google.com with SMTP id c194so9902926pga.12
 for <dev@dpdk.org>; Tue, 16 Jan 2018 10:29:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:mime-version
 :content-transfer-encoding;
 bh=OFihK7ZAUEjPFDyDtpKDiO65WZ3gT5IrCJeALI4ttbA=;
 b=n1/HTxhHralDplPulvUuQ4cchXn2IyHwo10j/b7sPHojmtsSJHM2qX60yNaaRlYMSL
 YQWPlyjDaAXkIYsvmQuaPbKrs+cU8nXECUsYOtUYnBQZ2ZDO5Ctp3JJ4914n7s7m5+42
 6vYS89wbpu05kPLfvbQkQQ7OihEFSClypjgNopWAeiVKKyHPU8SORpxIWaxzdExcruVv
 wQum8yKP0XJtYeh9eOrEvPXBPdCEDwTlwoUlWFxydso3krqv3U/vC98H4KtgBcODSJB3
 5mtI7g2Ob2l14FZcv8tvt3MaK1FCrlCQ2cZmbLyeuVzV56czB5g4sLVSWyoBGct8gali
 qP1Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
 :content-transfer-encoding;
 bh=OFihK7ZAUEjPFDyDtpKDiO65WZ3gT5IrCJeALI4ttbA=;
 b=gh1SL6PFM0PAlY3eLh10v8u/KN1m2ACeKuvkp8KgcluG7WIOfd4kuG7fvUXC1ie7xQ
 aRQ9u5S4JBFLF+9l893LSf1RijwpZbLkfZsY8jCh0xv2s5tB2974ulE/mzym7N8s+ER3
 bcOCRWDyauyGYDEClPMXt7wsUit+pAy7xubbHglb3xrToxOgPRs0A6NcW08uHsXscZX8
 86TEH4E/+iK+exGugy8P4+Usv9LEiFNH11JOCKwDl2AYTK3a97rtvudHfClh09ADOY0N
 0WFHWzZHvhYS5YVj0lu8ea0OztVA6eaoi0gCpFn0+RyJAAi6iZC3cEbeU/GAY5oaSjZB
 kxsA==
X-Gm-Message-State: AKGB3mJtigRRKMMHQWSUIgESh+clCGOlzSZA8wji27JBWUSVUFJpoDf6
 l3ayA3pau0nJf1MiqgNNxO2r8IslkK4=
X-Google-Smtp-Source: ACJfBotkOAiwlpa5VPvGqaIsAP8MC31RDsxa1lszAZoD+fiS+dZOE4qhUKC78wB1b0FBTeyEdH7JkA==
X-Received: by 10.99.95.213 with SMTP id t204mr26678369pgb.294.1516127348723; 
 Tue, 16 Jan 2018 10:29:08 -0800 (PST)
Received: from xeon-e3 (204-195-18-133.wavecable.com. [204.195.18.133])
 by smtp.gmail.com with ESMTPSA id s186sm4296625pgb.67.2018.01.16.10.29.08
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Tue, 16 Jan 2018 10:29:08 -0800 (PST)
Date: Tue, 16 Jan 2018 10:29:06 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: gaetan.rivet@6wind.com
Cc: dev@dpdk.org
Message-ID: <20180116102906.0df665b6@xeon-e3>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: [dpdk-dev] [BUG] failsafe depending on return value from PMD
 link_update function.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 18:29:10 -0000

While doing link status refactoring, I noticed that the eth_dev_link_update function
return value is unused by common code (in rte_eth_dev_link_get); but is being expected
by failsafe driver.

The return values are not consistent across drivers, and link update function is only
valid if device is not using LSC.  Therefore, the failsafe PMD should not be calling
device internal functions directly and expecting a valid return value.