From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0040.outbound.protection.outlook.com [104.47.36.40]) by dpdk.org (Postfix) with ESMTP id 69E771B021 for ; Tue, 16 Jan 2018 16:08:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qmLiN4NBokESCnT/Zqg46GLmG2eSXEZsI93GJDpSgao=; b=QfzWUB9y3SX9K93SrO5RzxAApgow2cSsWTVZLBUU4Kw4jJ/EYFkTEbOpRXrHSpTxfQVhE79PczV7iFGU/tHLBlPPiwpwfIL6VmytCIoER3ODjFLynW0dHRY6pFRnizanj6w4PEftrPl7vtzL9I3DjtUs8+xsWz8IhF2OZNmi+CE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.61.89.253) by SN2PR07MB2526.namprd07.prod.outlook.com (2603:10b6:804:6::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Tue, 16 Jan 2018 15:08:32 +0000 Date: Tue, 16 Jan 2018 20:38:16 +0530 From: Jerin Jacob To: Olivier Matz Cc: Hemant Agrawal , dev@dpdk.org, santosh.shukla@caviumnetworks.com Message-ID: <20180116150815.GB2651@jerin> References: <1513333483-4372-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1515996674-26338-3-git-send-email-hemant.agrawal@nxp.com> <20180115122445.GB29114@jerin> <90315b96-e3a1-b47c-935c-e6437cef2716@nxp.com> <20180115162635.GC1245@jerin> <20180116150420.loaa43j2u2fwmpzv@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180116150420.loaa43j2u2fwmpzv@platinum> User-Agent: Mutt/1.9.2 (2017-12-15) X-Originating-IP: [171.61.89.253] X-ClientProxiedBy: MA1PR0101CA0038.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:22::24) To SN2PR07MB2526.namprd07.prod.outlook.com (2603:10b6:804:6::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d4e2861-7fbf-4350-dc18-08d55cf30379 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534125)(4602075)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:SN2PR07MB2526; X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 3:w9J5b3vxy8CJoPlFeFRYA0xnUb/Hey4Jv/3TMrEJyhfZ9bj1TDHCxSjhWOCpj48+V3W8pRvnNt6cK/Cvv8K+LQ3JCoE804lRG1CcpTiLoK5oeQ6EVonZ7oDdIWMqlBz6lfsmqfmTRLq680watNAOQ6ZFA5y9WDBmF9uxFMfHl3M3I5PlvtbLkQO6c5Nh4U8eV8X5PYaf9SjGr7xxDmrAKk2Uat30JdLAV72/6GDvL0U69OKEsKfkdbiH835i3KSy; 25:rhcpkVUh+iPG3BZ878o0z6q86n4yVcwuuHO+OIqQSp3USqgP5yBuw506YwdNCyjNcflwjmHxXhm57taW9TCb+YKBGPRjZXtKdU6lNafNnAQIOEN+/w+b49b7IOecFSFB1ePpyszvjmJLvLM7of8B4D4hLDYfP9GfsaDehLpNHIlGtCc6Dvpmawv360tptgQbG4ufVnUsR/Lmtywuc/ToL4WedHHO4kNN9nTmRLfr+0tXn4JH6Kezhf7XS4MNeXyzpn56TSIQJ7EFdkDBPSuXKu8gcruW1NBx01oYjLmbHE1N1UVrmylKUuSMsGbQIIqVJa4MELmepls/MNaAsrXiKA==; 31:mdL+9TUeyDNoH8dWZkTK0fg2zMUtOOs6xaQrFCN07JfJxiPEuJ0HRPhujovpdFlgXoL1rQ3OezyRL/NoSsBK6H4z+orNR5FYt8k2fF9fauTllctwQ8U6PdVsNGaebR3ElAm5RSG/4BzYqSJZm31Dpn89vyLnvhsOdMaq/k+Gcf8S8Gum/BMoce7XYq8bwb0Snd/6w60C5+zkF2OnO3ljtePSLGsdtNJlhgcTL+u9AB4= X-MS-TrafficTypeDiagnostic: SN2PR07MB2526: X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 20:Bsqrr07JeR/ya8Z2of0YOpAv/b+KtUrW9+7Ai5QvO/xOSRzNNXYeQ0Mq+qk5OXf+a+qC2PS8PFeGn9Xwrk9YcBKbBPZd+qWrQZMXQgl6xxgZRC9WEsi5oaqPq+0sqa9MEGtZ3sIOzOYIWyzCaRqWnW+uw4Y30sQ1liulY6GVMYPAX8t1YUj200J5qHkJlGdzQfxHQz3pbDDZhJNy/17VBEAOjX3DW2BpiEeZTZlyCpIY6alrVBlNvdE+dM8UCEvpxBfSYZzDY9zxwLYQKA9JgCyPkLT3G93V3BKBMi9IQfkMQhwvrFkRfqHqRJVMzjWHgqpALLjLBP2Z7mCFnT5BYrhSpKuXxMXtTm2qmQ8kb3DadhHHpy3skgaI3pNq/tB0hSZhj42hyQvzgM3ho06RquE76eCE948HZuDE6WNLhvnompP0JDnxb8UaA0Y1YzK+PPVHjshe3g1aLQ/BiaTB0bLajBEBwcdp288ZGmbRbG88GdfuP9NPMrYUxwwqbMgy18BgeN1zaaXAgO0Vt31sMca4Nt2QKoM6jkLCfy/890c/QBUsOzlyT9vmCze7LKviyrjIV0B+Ei5H4Em5Cs9UPqsqM/Te6G0bbyqF0fpE+Gg=; 4:KCbsNH2RHEelP3JFajMibmX+UxzcXjXUb63ImayPXbuR0ejdxyNRM2eBIEJt+WRnd1oUZPC6pl71eRH5NQeCScOsNfb02xmE8h5f6NDoZQpfc99XN1KPFI36K6i4xVO/pW6HoARbSXHBtFPFji48dCumArh8xMbsJlffBDVW9qbjtXaNNbYDsdepd5iF3xTXY+FP5LLVveTwRr7EXXTF6d8CuOvshkmjudWueAxD6Geoe+ASkAjK5E2LdaqNqu4EBrqCvGWD8/5p+jNE/gz0keP5H7365f9njzLScN0g9dCGZIoKKM7zHFAYXJWdWVMQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(8121501046)(5005006)(3002001)(3231023)(944501161)(10201501046)(93006095)(6041268)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:SN2PR07MB2526; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:SN2PR07MB2526; X-Forefront-PRVS: 0554B1F54F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(39860400002)(366004)(396003)(346002)(376002)(13464003)(199004)(189003)(24454002)(83506002)(1076002)(3846002)(6116002)(23726003)(16526018)(8656006)(106356001)(47776003)(66066001)(105586002)(7736002)(305945005)(72206003)(478600001)(5660300001)(97736004)(8676002)(42882006)(6916009)(6246003)(33656002)(53936002)(229853002)(25786009)(8936002)(9686003)(107886003)(81156014)(81166006)(6666003)(50466002)(55016002)(53546011)(386003)(4326008)(68736007)(33896004)(16586007)(316002)(58126008)(33716001)(93886005)(2906002)(6496006)(52116002)(76176011)(2950100002)(26005)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR07MB2526; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN2PR07MB2526; 23:Z/r13wE6CpvwhIxltT/U/AcCSyRZ11xVgC8OKoRnv?= =?us-ascii?Q?J9s2JV17TBDHoMuEBSqjxV4IBwBnMZAeUBgOIAOfg084e2tVeG+iQY+gDTVQ?= =?us-ascii?Q?31JGap5EAewSZxM5LWxtVgAmQz9F1G/LUqCn+Ok8/4Ut5cU4t0GV569jx9fI?= =?us-ascii?Q?+yJ/OyZvawBi4iCnJpa/IpnhIIGq4HgOnnY0d45YOH/M2JbMM+ARgkYS+PQu?= =?us-ascii?Q?I3OnQdmeWHFnk2xQWHNK6u3X5HYguMq3158O5Pk6E0FaN7kIEfnpgIqyQPex?= =?us-ascii?Q?U3VIxmfyBq6zA44qG7n7ZaATP67/SIQG1fnwsLuUpBX8dy0aTQOIhgb+6AGa?= =?us-ascii?Q?D1M58NmPbSbtlWSSyVNZYoOuW5m/5BwRrui4KHCYbkr+4zrvqLWAiiewHt4P?= =?us-ascii?Q?+/2UcCcOTMi69E8vCXhF33lFw/EAwUf2MVqZWAHVdQM/1mhzRZXjc/r6pYEx?= =?us-ascii?Q?ERgpUZ63m9vjoe6nQaVTaDxU5u4xQLicOb0QppyKnfP5Xjr6OZvM707/py9m?= =?us-ascii?Q?nvvC+pm1diOSVhWn/N5B8GwKMnifWBfizxAxTb9kij8tI4axESDihzbJDF2s?= =?us-ascii?Q?tA0qCLZL9eJDK3e5btfqdD2yBcg38qbhUV5UcT2PrmBBNI5Ve87rYSjS32Wj?= =?us-ascii?Q?mAGzWUPoGuoHnbVzV+rBHk/77JOgB4OJk311c95iuivAw6nF3kaImeT/aSl/?= =?us-ascii?Q?TdqAOaMcLdNEnPaeoSBdhQQov6crwXwWYvGUhWtheMkrssjsCUzRxKRBvAT2?= =?us-ascii?Q?fSv/hN9DtCbERb/uvYEuBL06OWx2wky6L11BAO7Y+uUvPaZOf2TUfDt/wu2I?= =?us-ascii?Q?wEpbBq9bNEifsy7ICF+WNJDC8hALs3ltI9CVFw7wk29UZnOLPds+zOEKVsaH?= =?us-ascii?Q?QYo+s0l5ty4BNM/QtfpE4IvXqV1papIvJuyn8y1LkJFO1+SaSyAskdK+Yymu?= =?us-ascii?Q?6xmrCwV9u05uWoWmjLEFzFvQrjtLap+w4WGi+6SkVdn0HYMrSKB2ai+FRX7o?= =?us-ascii?Q?GH41C8FmOg3A3MKrfJCtV/ffF2GFZuKADQ6HNI5cTykSvHGP1jsZFkobICrG?= =?us-ascii?Q?XkaG2Mj75o9H45lefBKOsu54qWisV3BYO4ANnGGozA59x9xy/lkrumq5zjGm?= =?us-ascii?Q?wp5k0wIPifeNCF12Toz/iWyjN15KQ45mPhoqQxoBowGZSAcCgT+eJ8aDlxw2?= =?us-ascii?Q?QFMt22cmMS+euG8ObZ0t5CJJU2jV0/u475WsoMI6w3zXquRutYRMy6Ae8WVm?= =?us-ascii?Q?9dvV0QhtzkYpRb5+68prjQT7RhABgp4QbgjxyTZ88ieiYYZRgMozXnv5fJsb?= =?us-ascii?Q?azV4aKiOMMDsDaSxLUfxShuV97jUX4chs4oVBFM8TgVlYyxy34ijGaUs2nMF?= =?us-ascii?Q?g8G3A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR07MB2526; 6:TPXmizIIwieiz3mgWHBFv/6K+h7L9ToUWLe8aQ14QaewAYkSFkpYUdStJcNqWxuqxKBbu3l+RKbBD4sXsHyeggKdgPtGIvE7vlqLf2ECbrauE/19G8ssjB6lQMHPBiX0HxBvcQyrH2euNp1ZUUWcZFSVegzZPyHCzUsfeS4My3nGaIGYH1rdTfPb4MEbViX2Mlqet5R4yvqfImWRobbPIpQZ5PyeWRg1yzTnOmmkuzEM8P+fJ9TXqyEv3qF2BuAUFRjW8EL+q+6Pt2CIjsb0w3FXZXpBEP/zr+cnuIyy6EEtE9rZgrU+45EMGN7qYk695ZdR0e92Z2LOtdEgIHiqM/mWvxLuhHnrLJ6JljF5XD4=; 5:K8vHqovgV6GXTVCHZdHqeuSwZsOhBaGDLkz2cAmLfQuvXnj/j2SRGHjLBmcpnXIgUpgO+9TpN0gWnUyrOmSSZ/tnsr62Dm/JHaQtBQnhX2H1xrWKpgOQlKKXLuyhiKLMUb/dbe0VghUzec2rK6SKs8drgSFBpN1VaxNZdV8T70I=; 24:IB2Ss/P5C6igdwiPOFmr+4KrYlt+nYfEETQ6QTsHaQW5NNMork/RJvkzEjYD1Jwfn4Amyrc+DqS8vYekkW/IJ4M0dS6M/WI7V3WHASUTlZU=; 7:qdUpGjJe8xI1kMgKQJOO/GhvtZbKTuXRnDpM6tVL3jpz3xpmPPIAnQkJ5tIBLMRcil2joRIc7tAccGVkWlc27xZO6NOA8fnTEuLbNfr30SKq0eP4kczTvmXLnUG/gIglF5rodb33oIGFzkOn1GNFz+d4O5V5RzDuSEeOE3y1TAq/f29DCTnn09uQOAVID9bFp/hUJmFmC0FxDK/JNoGjXy6Vn3HwTzwPquyt+M5SB1b5liDUKJ+ZP2T3T2uptNlY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jan 2018 15:08:32.9013 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d4e2861-7fbf-4350-dc18-08d55cf30379 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2526 Subject: Re: [dpdk-dev] [PATCH v2 2/5] eal: add platform mempool ops name in internal config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 15:08:36 -0000 -----Original Message----- > Date: Tue, 16 Jan 2018 16:04:20 +0100 > From: Olivier Matz > To: Jerin Jacob > CC: Hemant Agrawal , dev@dpdk.org, > santosh.shukla@caviumnetworks.com > Subject: Re: [PATCH v2 2/5] eal: add platform mempool ops name in internal > config > User-Agent: NeoMutt/20170113 (1.7.2) > > On Mon, Jan 15, 2018 at 09:56:36PM +0530, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Mon, 15 Jan 2018 20:01:14 +0530 > > > From: Hemant Agrawal > > > To: Jerin Jacob > > > CC: dev@dpdk.org, olivier.matz@6wind.com, santosh.shukla@caviumnetworks.com > > > Subject: Re: [PATCH v2 2/5] eal: add platform mempool ops name in internal > > > config > > > User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 > > > Thunderbird/45.8.0 > > > > > > On 1/15/2018 5:54 PM, Jerin Jacob wrote: > > > > > static int > > > > > diff --git a/lib/librte_eal/common/eal_internal_cfg.h b/lib/librte_eal/common/eal_internal_cfg.h > > > > > index 1169fcc..12c5b8a 100644 > > > > > --- a/lib/librte_eal/common/eal_internal_cfg.h > > > > > +++ b/lib/librte_eal/common/eal_internal_cfg.h > > > > > @@ -54,6 +54,8 @@ struct internal_config { > > > > > const char *hugepage_dir; /**< specific hugetlbfs directory to use */ > > > > > const char *user_mbuf_pool_ops_name; > > > > > /**< user defined mbuf pool ops name */ > > > > > + const char *plat_mbuf_pool_ops_name; > > > > > + /**< platform configured mbuf pool ops name */ > > > > > unsigned num_hugepage_sizes; /**< how many sizes on this system */ > > > > > struct hugepage_info hugepage_info[MAX_HUGEPAGE_SIZES]; > > > > > }; > > > > > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > > > > > index 3fa1e13..909691f 100644 > > > > > --- a/lib/librte_eal/rte_eal_version.map > > > > > +++ b/lib/librte_eal/rte_eal_version.map > > > > > @@ -203,6 +203,7 @@ DPDK_17.11 { > > > > > DPDK_18.02 { > > > > > global: > > > > > > > > > > + internal_config; > > > > > > > > I think, exposing the internal_config may not be a good idea. We may > > > > need "plat_mbuf_pool_ops_name" value for multi process case too. > > > > Considering the above points, How about adding it in > > > > struct rte_config and then expose too rte_eal_get_configuration() > > > > On the downside, it would be an ABI change. > > > > > > Yes! I was also not sure about exposing internal_config. > > > > > > rte_config is also a good option. If we add these options in the end, it > > > should not break ABI? > > > > I think, it does break the ABI. > > What about a new API in librte_mbuf as suggested as a reply to the cover > letter? Looks good to me.