From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68])
by dpdk.org (Postfix) with ESMTP id 5E9BB1B2D7
for <dev@dpdk.org>; Tue, 16 Jan 2018 16:52:19 +0100 (CET)
Received: by mail-wm0-f68.google.com with SMTP id i11so9523540wmf.4
for <dev@dpdk.org>; Tue, 16 Jan 2018 07:52:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:content-transfer-encoding:in-reply-to
:user-agent; bh=vleDbtbTIsEq5YU48BXJShhDD0NHKhcUt9DQ8HM5fX4=;
b=HPpsvKS1JDQDRV3ctj22RyDjuclBnfhuKmFLMGWnFff7H1hIWNkkxnD4VEPpMlNCLp
MAgANGE1LMgiVciZTKiW2P5yCUxHzXjjFg75Z1JlkhU2VOLF0h4FvOrHnRqI5JGvz9ar
wUVS6sf5ma5ol5fpSrRwodMvFle6Ksga/SrSUr9jYx5hrKDZBeDkC6Q6U+GCsZSCzb6d
2AKunkCpiRrGOCbSp74PLuHPS4w9qgmtWlBF1UpQdqEPWL8h892XPnPoh6/Qmcl6ISiF
0MyC3xSgA9dTRpSGMhFufHqs8sT5xfvA6OpbJW3t1oHgzrtbp/Dl6ZMwxpgbsKo+lZ/3
CFNg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:content-transfer-encoding
:in-reply-to:user-agent;
bh=vleDbtbTIsEq5YU48BXJShhDD0NHKhcUt9DQ8HM5fX4=;
b=SJFhW2jB5wbJK35nYgOmTTUp3S0olJxUucYhLANmBBKkRnzEYzhImANHzdJLQ9AWgV
eUsHrHm2EQVgkpcGtWr9eoxzoCDaFxGGCEiiaOrnf/g+UKrdfbtEqGOVGymQAxEt9WEE
jcPdkK4GB7QUtI9+jmg6QjqV2COJf+bYmG2I87jhQJpMzfDDrZcbU42bLbGt8oPtrx6i
nBG6zCicBAYHhoAxsUbnhXFMmRfK8RPnDgjXiwX2S+m42sO+IMFVXSK/+lfpQTqALDlm
iw7M+2F0medW8MnXigFW/4GCQMgkG1KVYKbrxif9S02+RB998cUCs9YpSfVL2vAdiiKG
NI3Q==
X-Gm-Message-State: AKwxytfarGA8av29C2+79udkLBEwlWQTogpjDi2GSCd86INpjPXfOMQN
scKBznvF/ts4gFyFnN9yasQG
X-Google-Smtp-Source: ACJfBosiTVybN+vl29zx6ZFOdKvvaQNHzaWjgyrz9b8e3GLEyuJGMDRpwtBIWmXiWS4I/TZ0+q1i8g==
X-Received: by 10.28.116.4 with SMTP id p4mr4794534wmc.82.1516117939030;
Tue, 16 Jan 2018 07:52:19 -0800 (PST)
Received: from laranjeiro-vm.dev.6wind.com
(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
by smtp.gmail.com with ESMTPSA id 201sm3209676wmm.38.2018.01.16.07.52.18
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 16 Jan 2018 07:52:18 -0800 (PST)
Date: Tue, 16 Jan 2018 16:52:01 +0100
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, borisp@mellanox.com
Message-ID: <20180116155201.zz6frinsqyjlxdqo@laranjeiro-vm.dev.6wind.com>
References: <e3a23acbc34bf1a632a32a56580cb403644ca268.1515662067.git.nelio.laranjeiro@6wind.com>
<20180116142409.yazvskvhlgsrzuib@platinum>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180116142409.yazvskvhlgsrzuib@platinum>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH 1/2] net: fix ESP header byte ordering
definition
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jan 2018 15:52:19 -0000
On Tue, Jan 16, 2018 at 03:24:09PM +0100, Olivier Matz wrote:
> On Thu, Jan 11, 2018 at 10:15:58AM +0100, Nelio Laranjeiro wrote:
> > ESP header is defined in the RFC2406 [1] as Big Endian fields it should use
> > the corresponding types in DPDK as well.
> >
> > Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
>
> I wonder if we should really mark this as a fix.
I also agree, the point is some examples application have started using
it as CPU order instead of Network order, this patch also needs to be
applied in stable branch before fixing the code using it.
> > Cc: borisp@mellanox.com
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> >
> > [1] https://tools.ietf.org/html/rfc2406
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
--
Nélio Laranjeiro
6WIND