From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id 35E981B2AA for ; Thu, 18 Jan 2018 09:44:49 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id 141so20940812wme.3 for ; Thu, 18 Jan 2018 00:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=czQ1dfGlGRp8n45lRJY+kBS3tqgfYvT81793hSoR1Rc=; b=1I93lxnB6zj5InTijOHkOpawRPgcS8FvPLG2X5hTpgh5nEuGRuTw7uR7BvuueGDIYH j7v5P1snj3gPQhwKA/SSpi+VesKrAtS1Yh9+vZG1s9TcPcX2NfGf31eAUdKivrN5Fvhc XUVWfnHizkUvJGIitro2TeTp6lzu0an2x08qUebp1IIcc+YULjSznFiBGcveTLFQuvY9 ssmydnjUjqMwrvndUUwBIhPZD1TJ7EFYU1kbuX2c0W3YQVhGfhFv6FSS92vQLd55hSM5 3/vczCIwePV9CgYooGEjE6WGJex062+7mXaci3l+7OWwUyW9h7Jt1jSbfWX7SIpS/LHB 1AyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=czQ1dfGlGRp8n45lRJY+kBS3tqgfYvT81793hSoR1Rc=; b=dFTRKh3E7f+PIEq8+m6EHiLJP2MNgr4LL0g9RZ83s4Qs+E7OPYmPkq0Ngwcu8Om/w2 NbG9NDZWiqL1jGqXlPDecKEhiIwqn8LmoT7owtAe6QqaAy6VK7BvwHNlrMhmBZjUCeoa YcliqqyqWDUSwMEiszOpYakDyVsePo4k6RVxd1i9QJmhaBBCSxomxmy1brywMkRuoV44 xwUYYxQpacrT6bqQjs2cE6oQy2Gbl9BLYElxN/pMglbnovivuQKPT1s41aJ9X6JSK2eG 0fyLMolvPxRHBuwkAxYrqZ04GKxjqonsm3pU5z8Ze8pkrr2HC19He8Ko77XgV7Q75LqW 4yPA== X-Gm-Message-State: AKwxytcIIbf7pwLcGUZ4mGAMesxTfbh/XyZieqLSGWis+HtrOLs3THcl k63RPT0NDapae4SNk313ev7iwA== X-Google-Smtp-Source: ACJfBosi4mr9G/Ntk9g3dz8MLYagrAXI53begoXI25LAn1gEx/N5F8it/5bOPeCdLTlspsxBE1WV9w== X-Received: by 10.80.146.87 with SMTP id j23mr2798187eda.53.1516265089008; Thu, 18 Jan 2018 00:44:49 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o60sm3950506edb.79.2018.01.18.00.44.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jan 2018 00:44:48 -0800 (PST) Date: Thu, 18 Jan 2018 09:44:35 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: Ferruh Yigit , Adrien Mazarguil , Thomas Monjalon , dev@dpdk.org Message-ID: <20180118084435.4qlmrxz6fy5nn2il@bidouze.vm.6wind.com> References: <1515587465-9304-1-git-send-email-matan@mellanox.com> <1516220357-13013-1-git-send-email-matan@mellanox.com> <1516220357-13013-7-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1516220357-13013-7-git-send-email-matan@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v5 6/6] net/failsafe: fix removed device handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 08:44:50 -0000 Hi Matan, On Wed, Jan 17, 2018 at 08:19:17PM +0000, Matan Azrad wrote: > There is time between the physical removal of the device until > sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and > applications still don't know about the removal and may call sub-device > control operation which should return an error. > > In previous code this error is reported to the application contrary to > fail-safe principle that the app should not be aware of device removal. > > Add an removal check in each relevant control command error flow and > prevent an error report to application when the sub-device is removed. > > Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND