From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 561691B024 for ; Thu, 18 Jan 2018 09:48:24 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BAB1020BD3; Thu, 18 Jan 2018 03:48:23 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 18 Jan 2018 03:48:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=Wekurb5Exxz4jgGMPHPxWNLEFrKMN/97vXvlkTdIax8=; b=TPf6a1WG o502Kv9yki/f8Gjv4XOZM662q9GoyTzFQ71NuJF4HXxyPs/AVN6F24fC+ZgFDu08 MBRbaVYHrXoKG3P3pWGQUhzIUivTH6dRjVJJySiE+VJOgSpJZQCLj2rj0XzoLYvR Igt35SB4Hyd2eGICq9YNS2ltU+mKcZ/i0JsA6VAFyE+PCq5QVhnYMinpH/kmzgw1 Zzt1sV5CeIhzxg3acytN0UvUK7AgILnfs6KN5Dl0kR4//VojDaS4WYDibSTrR+J9 1+YvPZ97TBWm0vRt74IbEODBhpc2qliXEMgrm9f6Gvcl/kcZyqM9V++/xOqdz75G FhELSSzU8jFBxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=Wekurb5Exxz4jgGMPHPxWNLEFrKMN /97vXvlkTdIax8=; b=Cj29jovY2mnuOHoqI6QA+9nCYHxXHlxlX2/sI2jVNsAnW l5GiVWW8dvRWun3kWdTcqKCLKL7zVBuPEQ7kOHo+m3Nvo9j9tAY1JkHGsvyNqp/F kItIwDz0nsyz3OqsZNqadf/TR3e/E8aRSSa3dLFb8VrpFoVRAYgi6FtODp1I/n+R n04Cn47GO2jxgumNXQX5wugNaFZIUUmP0HIw0shYS29BVntNNYUdGJuIEAPlqxa0 Sg1me2n3tCdg1AtuS4xGeMQbekeOFQLZK6TvtFYrKHMmjIrPBPSVB2hHRJta6xb0 pWLvKMi0/1134K5cxAtPOAj1dBNVLCzkRndKf2P4g== X-ME-Sender: Received: from yliu-mob (unknown [115.148.90.22]) by mail.messagingengine.com (Postfix) with ESMTPA id A53527E3DB; Thu, 18 Jan 2018 03:48:22 -0500 (EST) Date: Thu, 18 Jan 2018 16:48:20 +0800 From: Yuanhan Liu To: Thomas Monjalon Cc: dev@dpdk.org, "Wang, Xiao W" , "Yigit, Ferruh" , Olivier Matz Message-ID: <20180118084819.GB29540@yliu-mob> References: <20180118030921.GW29540@yliu-mob> <20180118080350.GA29540@yliu-mob> <3694166.292jyCsmFI@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3694166.292jyCsmFI@xps> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 2/2] net: fix build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 08:48:24 -0000 On Thu, Jan 18, 2018 at 09:36:46AM +0100, Thomas Monjalon wrote: > 18/01/2018 09:03, Yuanhan Liu: > > On Thu, Jan 18, 2018 at 07:45:23AM +0000, Wang, Xiao W wrote: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > 18/01/2018 04:14, Yuanhan Liu: > > > > > Fix build error when shared lib is enabled: > > > > > > > > > > LD librte_net.so.1.1 > > > > > rte_arp.o: In function `rte_net_make_rarp_packet': > > > > > rte_arp.c:(.text+0x1f0): undefined reference to `rte_mempool_ops_table' > > > > > rte_arp.c:(.text+0x21d): undefined reference to `rte_mempool_ops_table' > > > > > rte_arp.c:(.text+0x2d5): undefined reference to `rte_mempool_ops_table' > > > > > rte_arp.c:(.text+0x384): undefined reference to `rte_mempool_ops_table' > > > > > rte_arp.c:(.text+0x4b7): undefined reference to `rte_mempool_ops_table' > > > > > > > > This is very strange, I do not see this error on my machine. > > > > > > I could see this error on mine with: > > > +CONFIG_RTE_BUILD_SHARED_LIB=y > > > > Yes, that's what meant in the commit log by "when shared lib is enabled". > > Got it: you are fixing a build issue introduced by the patch 1 > in this series. > So please merge them. Right. I will merge them. --yliu