From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 93BEC1B16C for ; Thu, 18 Jan 2018 10:11:09 +0100 (CET) Received: by mail-wm0-f68.google.com with SMTP id f71so20399570wmf.0 for ; Thu, 18 Jan 2018 01:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=83kTLddOpD1cyRoUFdXggg+NIkXObpKpcEzmKFg7t9I=; b=EGL5+Ka7WSYSyUKKWtB9iTQvmEzLpKmPh8BpTNUdMSd5saJa9jrT99Kq3dI9iCE4+Z 2jF5q0J7jVxehatSMbwx7u0L9lPPMxc4e/bC8cQ6SCaSp7lCyXWvOJeEJPIwmstrXQKt PtJw2GiduEn3VFPf0M5fJSFT0/Zmn9cuB+E17Wn+scrDEz0jo0UmA1f+z60ZUZLPwNhC +pvZ34/7Qqmaam4Qq7qHcH3gYycBBLxaivG2s7d3Q8A+vO8bF2WIlF41J7fJNblz/psB etz5kQ1Vl/bBXnQTcsgpv2hCnvELuIQIps5vQ+6IQiI9IXfSB4mcHMR7vUOUO7mepiQL E8Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=83kTLddOpD1cyRoUFdXggg+NIkXObpKpcEzmKFg7t9I=; b=TLyphi6JY9ImrYK4Yq6F8D2ZDvfsAbo6+YzWE/zJGz+B3XiFPB5B+Qq9KRXKhlEdlL 89ndQHUvcaEMI2t94dt4LevQN9taOWM6IHkeqHkNRYSWFssxU+roKhj1d9R/MQQ3lc09 NsaJ7OWvg42Ytp79bbcw09x2O8z6WdHARpFnsJ8Co3mhEsFIdg4Cb48SX0jSh9daESiK Xmg51sFt2ZkPBHYxBEVBF6Ij8aIE10pBDtJqVKHiHJ9h/nVNm0OkAOncEUdAsBuAacM3 Sj/uISOVVn2XjeZ1FfmdNjr6Iz3gENMWKqPmsHGdfskN8SudR4UOGAI5FwI2622yudAL 1r9Q== X-Gm-Message-State: AKwxytesZZJQ6iLvB8ZPSs7c3KG5U9URbE2QpbVtNcobKajRen6I0Lah sR3Yd52E4tnUMuYQIo+ZfT+nDg== X-Google-Smtp-Source: ACJfBov2/b7SZ7Y177M/3FT5oiMAdXL0FvWJ01tJhbM8tqaJX12PpimI2TvTjgzPgYTeUnWiouRSnQ== X-Received: by 10.80.134.44 with SMTP id o41mr6812754edo.243.1516266669190; Thu, 18 Jan 2018 01:11:09 -0800 (PST) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q45sm797820eda.53.2018.01.18.01.11.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Jan 2018 01:11:08 -0800 (PST) Date: Thu, 18 Jan 2018 10:10:56 +0100 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Matan Azrad Cc: Ferruh Yigit , Thomas Monjalon , dev@dpdk.org, stephen@networkplumber.org Message-ID: <20180118091056.5pims3wlnwlxqz7a@bidouze.vm.6wind.com> References: <1515509253-17834-1-git-send-email-matan@mellanox.com> <1516265026-6469-1-git-send-email-matan@mellanox.com> <1516265026-6469-4-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1516265026-6469-4-git-send-email-matan@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 3/8] net/failsafe: add probed etherdev capture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 09:11:09 -0000 Hi Matan, On Thu, Jan 18, 2018 at 08:43:41AM +0000, Matan Azrad wrote: > Previous fail-safe code didn't support probed sub-devices capture and > failed when it tried to probe them. > > Skip fail-safe sub-device probing when it already was probed. > What happens when app --vdev "net_failsafe0,dev(net_failsafe0)" -- -i ? I guess infinite recursion. > Signed-off-by: Matan Azrad > Cc: Gaetan Rivet > --- > doc/guides/nics/fail_safe.rst | 5 +++ > drivers/net/failsafe/failsafe_args.c | 2 - > drivers/net/failsafe/failsafe_eal.c | 78 ++++++++++++++++++++++++--------- > drivers/net/failsafe/failsafe_private.h | 2 + > 4 files changed, 65 insertions(+), 22 deletions(-) > > diff --git a/doc/guides/nics/fail_safe.rst b/doc/guides/nics/fail_safe.rst > index 5b1b47e..b89e53b 100644 > --- a/doc/guides/nics/fail_safe.rst > +++ b/doc/guides/nics/fail_safe.rst > @@ -115,6 +115,11 @@ Fail-safe command line parameters > order to take only the last line into account (unlike ``exec()``) at every > probe attempt. > > +.. note:: > + > + In case of whitelist sub-device probed by EAL, fail-safe PMD will take the device > + as is, which means that EAL device options are taken in this case. > + This note should be right under the "dev()" parameter help I think. If the self-capture is possible and you fix it, you should as well add a line here about the limitation, concerning the PCI blacklist mode and the expected PCI id format? Something like: --- 8< --- When trying to use a PCI device automatically probed in blacklist mode, the syntax for the fail-safe must be with the full PCI id: Domain:Bus:Device.Function. See the usage example section. .. ^^^^^^^^^^^^^ Here, an ReST reference .. Would be nice, I don't recall .. the exact syntax. .. In the `Usage example` section: #. Start testpmd, automatically probing the device 84:00.0 and using it with the fail-safe .. code-block:: console $RTE_TARGET/build/app/testpmd -c 0xff -n 4 \ --vdev 'net_failsafe0,dev(0000:84:00.0),dev(net_ring0)' \ -- -i --- >8 --- Ensure that this is working before using this command, I haven't tested it. Regards, -- Gaëtan Rivet 6WIND