From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id CEAD01B2C2; Thu, 18 Jan 2018 14:01:02 +0100 (CET) Received: from glumotte.dev.6wind.com. (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id 9D7AD123B13; Thu, 18 Jan 2018 13:59:29 +0100 (CET) From: Olivier Matz To: dev@dpdk.org, Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh Cc: stable@dpdk.org Date: Thu, 18 Jan 2018 14:00:42 +0100 Message-Id: <20180118130043.31773-1-olivier.matz@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 13:01:03 -0000 On error, mlx5_dev_start() does not return a negative value as it is supposed to do. The consequence is that the application (ex: testpmd) does not notice that the port is not started and begins the rxtx on an uninitialized port, which crashes. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") Cc: stable@dpdk.org Signed-off-by: Olivier Matz --- drivers/net/mlx5/mlx5_trigger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 1a20967a2..44f702daa 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -166,6 +166,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) ERROR("%p: an error occurred while configuring control flows:" " %s", (void *)priv, strerror(err)); + err = -err; goto error; } err = priv_flow_start(priv, &priv->flows); @@ -173,6 +174,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) ERROR("%p: an error occurred while configuring flows:" " %s", (void *)priv, strerror(err)); + err = -err; goto error; } err = priv_rx_intr_vec_enable(priv); @@ -196,7 +198,7 @@ mlx5_dev_start(struct rte_eth_dev *dev) priv_rxq_stop(priv); priv_flow_delete_drop_queue(priv); priv_unlock(priv); - return -err; + return err; } /** -- 2.11.0