From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4590D1B1B3; Thu, 18 Jan 2018 14:27:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8755320C4E; Thu, 18 Jan 2018 08:27:15 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 18 Jan 2018 08:27:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=1u3ElQhteQ4nw+M1pkORdfBhcfhbJpUNGB6CJgSUq20=; b=qc9/5kC5 ejRevhVYZvIi1Im/qULWAg26TQTIqtdSWO3QusTO4y1wphIH6+GKTIP4QNRLAtSj bg8nLTsOV5BrzYoTyijt0sSu15Rpxj/pk83cNpTEyYM0D37/y0nNgux8LON5uVE/ poWnWdUC1dgb/LfYOwP6nkib7uLky80QBftIAl6Z8w2ZtE1YJ1OgyODVH5iycZrk 6w9ZX5UCs50TYrsB2EEmQwSA1MdUREbCS+U/gGyoLDf6Uw1uDwsWY7yijT4ppaB4 N842A6dsFqKTztRCf2wKmpEgSrqlYc2QteAiXNQNzPHRZKRrcr2BDiV0daCq+hIH A0e6skdy6MURBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=1u3ElQhteQ4nw+M1pkORdfBhcfhbJ pUNGB6CJgSUq20=; b=rKTS25ZTB5xqPcQfKZ7GcLaZfIpApOaNQSKbGnwCQQFjJ GLvRAa4YQjr5EAQ3mY2RNnu2cAV9qrrPew8f1ZW3bo5OTGCFXVxk6YMwhSaE4v6u Ew8XSW6WteUqPuxzPce1Z8xH+FFnWDuXfZwmQF09UC2qCMl11e2h6FFSUQisXTrT COEmbihzBCvnTK8zRA5hx3nJ71G2zswpMLb4H2Wf3jtooLMxTYVvE9lQFq/zw3fy hK+Ybosd3oUHNZI+C3zOclE46MrgDoMgrPpUsQTPB1BUm10XCEvoHmOif1ON2M/q n7bGba9NXlaQJyyHE6PbyuiKCsbapx5X1cspaLCBg== X-ME-Sender: Received: from yliu-mob (unknown [115.148.90.22]) by mail.messagingengine.com (Postfix) with ESMTPA id 863427E43A; Thu, 18 Jan 2018 08:27:14 -0500 (EST) Date: Thu, 18 Jan 2018 21:27:10 +0800 From: Yuanhan Liu To: Olivier Matz Cc: dev@dpdk.org, Maxime Coquelin , Tiwei Bie , stable@dpdk.org Message-ID: <20180118132710.GH29540@yliu-mob> References: <20180118090733.12728-1-olivier.matz@6wind.com> <20180118090733.12728-2-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180118090733.12728-2-olivier.matz@6wind.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix typo in function name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 13:27:16 -0000 On Thu, Jan 18, 2018 at 10:07:31AM +0100, Olivier Matz wrote: > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: stable@dpdk.org I would not suggest to include such patch for a stable release. It doesn't fix a real issue. Thanks. --yliu > > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_ethdev.c | 4 ++-- > drivers/net/virtio/virtqueue.c | 2 +- > drivers/net/virtio/virtqueue.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index ec012c2ac..c7426951c 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1879,7 +1879,7 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev) > VIRTQUEUE_DUMP(rxvq->vq); > > PMD_INIT_LOG(DEBUG, "rx_queues[%d]=%p", i, rxvq); > - while ((buf = virtqueue_detatch_unused(rxvq->vq)) != NULL) { > + while ((buf = virtqueue_detach_unused(rxvq->vq)) != NULL) { > rte_pktmbuf_free(buf); > mbuf_num++; > } > @@ -1899,7 +1899,7 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev) > VIRTQUEUE_DUMP(txvq->vq); > > mbuf_num = 0; > - while ((buf = virtqueue_detatch_unused(txvq->vq)) != NULL) { > + while ((buf = virtqueue_detach_unused(txvq->vq)) != NULL) { > rte_pktmbuf_free(buf); > mbuf_num++; > } > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c > index 1ada4fe08..6988bfea4 100644 > --- a/drivers/net/virtio/virtqueue.c > +++ b/drivers/net/virtio/virtqueue.c > @@ -16,7 +16,7 @@ > * 2) mbuf that hasn't been consued by backend. > */ > struct rte_mbuf * > -virtqueue_detatch_unused(struct virtqueue *vq) > +virtqueue_detach_unused(struct virtqueue *vq) > { > struct rte_mbuf *cookie; > int idx; > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index fedbaa39c..1288e5287 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -270,7 +270,7 @@ void virtqueue_dump(struct virtqueue *vq); > /** > * Get all mbufs to be freed. > */ > -struct rte_mbuf *virtqueue_detatch_unused(struct virtqueue *vq); > +struct rte_mbuf *virtqueue_detach_unused(struct virtqueue *vq); > > /* Flush the elements in the used ring. */ > void virtqueue_rxvq_flush(struct virtqueue *vq); > -- > 2.11.0