From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
by dpdk.org (Postfix) with ESMTP id 83FC41B2E8;
Thu, 18 Jan 2018 14:45:57 +0100 (CET)
Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231]
helo=droids-corp.org)
by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256)
(Exim 4.89) (envelope-from <olivier.matz@6wind.com>)
id 1ecAVu-0007jw-Bn; Thu, 18 Jan 2018 14:45:55 +0100
Received: by droids-corp.org (sSMTP sendmail emulation);
Thu, 18 Jan 2018 14:45:48 +0100
Date: Thu, 18 Jan 2018 14:45:48 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Yuanhan Liu <yliu@fridaylinux.org>
Cc: dev@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>, stable@dpdk.org
Message-ID: <20180118134548.jf3pp447xm6hevg5@platinum>
References: <20180118090733.12728-1-olivier.matz@6wind.com>
<20180118090733.12728-2-olivier.matz@6wind.com>
<20180118132710.GH29540@yliu-mob>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180118132710.GH29540@yliu-mob>
User-Agent: NeoMutt/20170113 (1.7.2)
Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix typo in function name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jan 2018 13:45:57 -0000
On Thu, Jan 18, 2018 at 09:27:10PM +0800, Yuanhan Liu wrote:
> On Thu, Jan 18, 2018 at 10:07:31AM +0100, Olivier Matz wrote:
> > Fixes: c1f86306a026 ("virtio: add new driver")
> > Cc: stable@dpdk.org
>
> I would not suggest to include such patch for a stable release. It doesn't
> fix a real issue.
Yes.
I've included it in the patchset to avoid conflicts for backports because it
changes the same code area.
If you prefer, I can send a new patchset with the current 2/3 and 3/3, plus
the typo fix as a individual patch, on top of them.
Does it look good to you?
Thanks
>
> Thanks.
>
> --yliu
> >
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > ---
> > drivers/net/virtio/virtio_ethdev.c | 4 ++--
> > drivers/net/virtio/virtqueue.c | 2 +-
> > drivers/net/virtio/virtqueue.h | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> > index ec012c2ac..c7426951c 100644
> > --- a/drivers/net/virtio/virtio_ethdev.c
> > +++ b/drivers/net/virtio/virtio_ethdev.c
> > @@ -1879,7 +1879,7 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev)
> > VIRTQUEUE_DUMP(rxvq->vq);
> >
> > PMD_INIT_LOG(DEBUG, "rx_queues[%d]=%p", i, rxvq);
> > - while ((buf = virtqueue_detatch_unused(rxvq->vq)) != NULL) {
> > + while ((buf = virtqueue_detach_unused(rxvq->vq)) != NULL) {
> > rte_pktmbuf_free(buf);
> > mbuf_num++;
> > }
> > @@ -1899,7 +1899,7 @@ static void virtio_dev_free_mbufs(struct rte_eth_dev *dev)
> > VIRTQUEUE_DUMP(txvq->vq);
> >
> > mbuf_num = 0;
> > - while ((buf = virtqueue_detatch_unused(txvq->vq)) != NULL) {
> > + while ((buf = virtqueue_detach_unused(txvq->vq)) != NULL) {
> > rte_pktmbuf_free(buf);
> > mbuf_num++;
> > }
> > diff --git a/drivers/net/virtio/virtqueue.c b/drivers/net/virtio/virtqueue.c
> > index 1ada4fe08..6988bfea4 100644
> > --- a/drivers/net/virtio/virtqueue.c
> > +++ b/drivers/net/virtio/virtqueue.c
> > @@ -16,7 +16,7 @@
> > * 2) mbuf that hasn't been consued by backend.
> > */
> > struct rte_mbuf *
> > -virtqueue_detatch_unused(struct virtqueue *vq)
> > +virtqueue_detach_unused(struct virtqueue *vq)
> > {
> > struct rte_mbuf *cookie;
> > int idx;
> > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> > index fedbaa39c..1288e5287 100644
> > --- a/drivers/net/virtio/virtqueue.h
> > +++ b/drivers/net/virtio/virtqueue.h
> > @@ -270,7 +270,7 @@ void virtqueue_dump(struct virtqueue *vq);
> > /**
> > * Get all mbufs to be freed.
> > */
> > -struct rte_mbuf *virtqueue_detatch_unused(struct virtqueue *vq);
> > +struct rte_mbuf *virtqueue_detach_unused(struct virtqueue *vq);
> >
> > /* Flush the elements in the used ring. */
> > void virtqueue_rxvq_flush(struct virtqueue *vq);
> > --
> > 2.11.0