From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <yliu@fridaylinux.org> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 402F81B340 for <dev@dpdk.org>; Thu, 18 Jan 2018 15:59:57 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BE234207F3; Thu, 18 Jan 2018 09:59:56 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Thu, 18 Jan 2018 09:59:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=SaLSNVYfvHc6fRPBAvo3U8zlHAFr+BGoyN1+XRvr9Co=; b=Jzst3+Ar w4zGxQHBtXiLQmt0Z67YPgKF4bonwvXyTNgEqq/ki38Tk7sjYxo6XEDrBxTdQhC8 IGBU86Gb4hqrjHYgC9zxWNydKUiYWFyphgzkrp2+WX/hoNKBPHTmDgVdGz73eaie fj/mA0oJwnkhaCs33aT9lPXr6ElSVpGJIeqkvmO3dlDlN5oFYZikR/YI7bQqpZ+K pUPLmTEdRYaBunaUhxn3nb9ZKsKZFw/wspy6TLHkwTqjWj8ug9V6luSlsX3GCSXC SBioIKjQq7teDFcUD+Dlw75QJWjpctHgP5zZIFuVKufF1v9VkPHpWRwZUynIxZEE itZPBUr736CCSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=SaLSNVYfvHc6fRPBAvo3U8zlHAFr+ BGoyN1+XRvr9Co=; b=TmdI1JRQCLcZytzzMRXrwaoPBXH8k46A7DvTjAhuIwwbf pyQ2ptMzcNIHnSbntHRHws5p2icNlhzgyyXQh8NzUnKuyd/ZgEnD4RImMtFJr4r4 Dl2iKiw8bNrBeona7qduQJY/+/Qt1QXJFw10VVIr3HPyoEFJnx9Ox/B8FYbZVczV AJ4q2W5mQQO40QCBBtgAawkCFGBncQiYVluLzh4sEqLtCNRaDjdnUDsCd4zDmFGE 7NQ4ouHTX5Qd9RJOLHabFp21hm+y6stDkYwQQ1RgIYaxZGT0+rHoc/XGX6HdwwY7 VJ7gZvIV8JSx1yTc+QE53QCq7wgzSC4fxLR9rpU5g== X-ME-Sender: <xms:bLZgWkJNO1108ppR4K9mg5ZSAk_n0v3vs3bMpQ43BAAsLx7cjD2cvQ> Received: from yliu-mob (unknown [115.148.90.22]) by mail.messagingengine.com (Postfix) with ESMTPA id 794D77E3DF; Thu, 18 Jan 2018 09:59:55 -0500 (EST) Date: Thu, 18 Jan 2018 22:59:52 +0800 From: Yuanhan Liu <yliu@fridaylinux.org> To: Fan Zhang <roy.fan.zhang@intel.com> Cc: dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com Message-ID: <20180118145952.GN29540@yliu-mob> References: <20171127200115.31049-1-roy.fan.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171127200115.31049-1-roy.fan.zhang@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 00/12] lib/librte_vhost: introduce new vhost_user crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 18 Jan 2018 14:59:57 -0000 On Mon, Nov 27, 2017 at 08:01:03PM +0000, Fan Zhang wrote: > This patchset adds crypto backend suppport to vhost_user library, > including a proof-of-concept sample application. The implementation > follows the virtio-crypto specification and have been tested > with qemu 2.9.50 (with several patches applied, detailed later) > with Fedora 24 running in the frontend. > > The vhost_user library acts as a "bridge" method that translate > the virtio-crypto crypto requests to DPDK crypto operations, so it > is purely software implementation. However it does require the user > to provide the DPDK Cryptodev ID so it knows how to handle the > virtio-crypto session creation and deletion mesages. > > Currently the implementation supports AES-CBC-128 and HMAC-SHA1 > cipher only/chaining modes and does not support sessionless mode > yet. The guest can use standard virtio-crypto driver to set up > session and sends encryption/decryption requests to backend. The > vhost-crypto sample application provided in this patchset will > do the actual crypto work. > > To make this patchset working, a few tweaks need to be done: > > In the host: > 1. Download the qemu source code, and apply the patches in: > list.nongnu.org/archive/html/qemu-devel/2017-07/msg04664.html. I could not open it. What's the status of them now? Have they got merged? Besides that, this patchset doesn't seem well organized. For example, Makefile, version_map, config file, doc (etc.) are all updated separately. Could you do a re-organization? Personally, I'd suggest something below: - one patch for introduce extra msg_handler - one patch for implementing vhost_crypto (release doc should also be updated here). - one patch for adding an example (example doc should also be included here). Of course, if you could split 2nd item a bit further, that'd be better. Also, the new functions should be marked as "experimental". --yliu > As the patches have been out for over 2 months, they cannot be > cleanly applied to the latest code. I have reverted the commits > back to 4c4414a to make the patches applied cleanly. > > 2. Recompile your qemu. > > 3. Apply this patchset to latest DPDK code and recompile DPDK. > > 4. Compile and run vhost-crypto sample application. > > ./examples/vhost_crypto/build/vhost-crypto -l 11,12,13 -w 0000:86:01.0 \ > --socket-mem 2048,2048 > > Where 0000:86:01.0 is the QAT PCI address. You may use AES-NI-MB if it is > not available. The sample application requires 3 lcores: 1 master, 1 worker, > and 1 statistics displaying worker. The application will create a UNIX socket > file /tmp/vhost_crypto1.socket. > > 5. Start your qemu application. Here is my command: > > qemu/x86_64-softmmu/qemu-system-x86_64 -machine accel=kvm -cpu host \ > -smp 2 -m 1G -hda ~/path-to-your/image.qcow \ > -object memory-backend-file,id=mem,size=1G,mem-path=/dev/hugepages,share=on \ > -mem-prealloc -numa node,memdev=mem -chardev \ > socket,id=charcrypto0,path=/tmp/vhost_crypto1.socket \ > -object cryptodev-vhost-user,id=cryptodev0,chardev=charcrypto0 \ > -device virtio-crypto-pci,id=crypto0,cryptodev=cryptodev0 > > 6. Once guest is booted. The Linux virtio_crypto kernel module is loaded by > default. You shall see the following logs in your demsg: > > [ 17.611723] virtio_crypto virtio0: max_queues: 1, max_cipher_key_len: ... > [ 17.612156] virtio_crypto virtio0: will run requests pump with realtime ... > [ 18.376100] virtio_crypto virtio0: Accelerator is ready > > The virtio_crypto driver in the guest is now up and running. > > 7. The rest steps can be as same as the Testing section in > https://wiki.qemu.org/Features/VirtioCrypto > > Fan Zhang (12): > lib/librte_vhost: add private data field > lib/librte_vhost: add vhost_user private info structure > lib/librte_vhost: add virtio crypto user message structure > lib/librte_vhost: add session messsage handler > lib/librte_vhost: add request handler > lib/librte_vhost: add head file > lib/librte_vhost: add public function implementation > lib/librte_vhost: update version map > lib/librte_vhost: update makefile > config: added no copy configuration item > example/vhost_crypto: add vhost_crypto sample application > doc: update vhost crypto documentation > > config/common_base | 1 + > doc/guides/prog_guide/vhost_lib.rst | 16 + > doc/guides/rel_notes/release_18_02.rst | 7 + > doc/guides/sample_app_ug/index.rst | 1 + > doc/guides/sample_app_ug/vhost_crypto.rst | 95 +++ > examples/vhost_crypto/Makefile | 59 ++ > examples/vhost_crypto/main.c | 588 +++++++++++++ > lib/librte_vhost/Makefile | 6 +- > lib/librte_vhost/rte_vhost_crypto.h | 150 ++++ > lib/librte_vhost/rte_vhost_version.map | 11 + > lib/librte_vhost/vhost.h | 4 +- > lib/librte_vhost/vhost_crypto.c | 1314 +++++++++++++++++++++++++++++ > lib/librte_vhost/vhost_user.c | 13 +- > lib/librte_vhost/vhost_user.h | 34 +- > 14 files changed, 2294 insertions(+), 5 deletions(-) > create mode 100644 doc/guides/sample_app_ug/vhost_crypto.rst > create mode 100644 examples/vhost_crypto/Makefile > create mode 100644 examples/vhost_crypto/main.c > create mode 100644 lib/librte_vhost/rte_vhost_crypto.h > create mode 100644 lib/librte_vhost/vhost_crypto.c > > -- > 2.9.5