From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 13E151B2E0 for ; Fri, 19 Jan 2018 11:01:32 +0100 (CET) Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ecTUM-0001Fd-Vr; Fri, 19 Jan 2018 11:01:36 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Fri, 19 Jan 2018 11:01:28 +0100 Date: Fri, 19 Jan 2018 11:01:28 +0100 From: Olivier Matz To: Hemant Agrawal Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com Message-ID: <20180119100128.7w6waquio6s3gjvr@platinum> References: <1515996674-26338-1-git-send-email-hemant.agrawal@nxp.com> <1516281992-6873-1-git-send-email-hemant.agrawal@nxp.com> <1516281992-6873-2-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1516281992-6873-2-git-send-email-hemant.agrawal@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v3 1/7] eal: prefix mbuf pool ops name with user defined X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 10:01:32 -0000 On Thu, Jan 18, 2018 at 06:56:26PM +0530, Hemant Agrawal wrote: > This patch prefix the mbuf pool ops name with "user" to indicate > that it is user defined. > > This patch also change the logic to maintain the value of > user defined and compile time i.e. RTE_MBUF_DEFAULT_MEMPOOL_OPS. > > The pktmbuf_create_pool is updated to reflect the same. The patch itself looks good to me, but I think it deserves to be split in 2 patches.