From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 780BA1B00B
 for <dev@dpdk.org>; Fri, 19 Jan 2018 17:24:27 +0100 (CET)
X-Amp-Result: UNSCANNABLE
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 19 Jan 2018 08:24:26 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,381,1511856000"; d="scan'208";a="11674510"
Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.77])
 by fmsmga008.fm.intel.com with SMTP; 19 Jan 2018 08:24:23 -0800
Received: by  (sSMTP sendmail emulation); Fri, 19 Jan 2018 16:24:22 +0000
Date: Fri, 19 Jan 2018 16:24:22 +0000
From: Bruce Richardson <bruce.richardson@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
 herbert.guan@arm.com, dev@dpdk.org, hemant.agrawal@nxp.com,
 shreyansh.jain@nxp.com
Message-ID: <20180119162422.GB16980@bricha3-MOBL3.ger.corp.intel.com>
References: <20171219105338.198727-1-bruce.richardson@intel.com>
 <20180119135251.10171-1-pbhagavatula@caviumnetworks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180119135251.10171-1-pbhagavatula@caviumnetworks.com>
Organization: Intel Research and Development Ireland Ltd.
User-Agent: Mutt/1.9.1 (2017-09-22)
Subject: Re: [dpdk-dev] [PATCH v3 1/2] build: add support for ARM builds
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jan 2018 16:24:27 -0000

On Fri, Jan 19, 2018 at 07:22:50PM +0530, Pavan Nikhilesh wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
> 
> Add files to enable compiling for ARM cross builds.
> This can be tested by doing a cross-compile for armv8-a type using
> the linaro gcc toolchain.
> 
>         meson arm-build --cross-file aarch64_cross.txt
>         ninja -C arm-build
> 
> where aarch64_cross.txt contained the following
> 
>         [binaries]
>         c = 'aarch64-linux-gnu-gcc'
>         cpp = 'aarch64-linux-gnu-cpp'
>         ar = 'aarch64-linux-gnu-ar'
> 
>         [host_machine]
>         system = 'linux'
>         cpu_family = 'aarch64'
>         cpu = 'armv8-a'
>         endian = 'little'
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
>  v3 Changes:
>  - Fix missing SPDX license tags
> 
>  v2 Changes:
>  - Merged RFC patch.
>  - Added framework to easily other vendor specific flags
>  - renamed machine_arg to machine_args
> 
Set LGTM, but it would be nice to get an ACK or review from another ARM
expert. Any volunteers?

/Bruce