From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 554231B29B for <dev@dpdk.org>; Fri, 19 Jan 2018 17:38:26 +0100 (CET) Received: from lfbn-lil-1-110-231.w90-45.abo.wanadoo.fr ([90.45.197.231] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from <olivier.matz@6wind.com>) id 1ecZgR-0001sl-BR; Fri, 19 Jan 2018 17:38:28 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Fri, 19 Jan 2018 17:38:20 +0100 Date: Fri, 19 Jan 2018 17:38:20 +0100 From: Olivier Matz <olivier.matz@6wind.com> To: Hemant Agrawal <hemant.agrawal@nxp.com> Cc: Jia He <hejianet@gmail.com>, dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob <jerin.jacob@caviumnetworks.com>, Jianbo Liu <jianbo.liu@arm.com>, Jan Viktorin <viktorin@rehivetech.com>, konstantin.ananyev@intel.com, Jia He <jia.he@hxt-semitech.com> Message-ID: <20180119163820.lk6mi6mjxaomb5nq@platinum> References: <1516161831-28719-1-git-send-email-hejianet@gmail.com> <1516161831-28719-3-git-send-email-hejianet@gmail.com> <a779a7be-50ee-7d58-52d6-865b802bfff6@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <a779a7be-50ee-7d58-52d6-865b802bfff6@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v8 2/3] ring: introduce new header file to include common functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 19 Jan 2018 16:38:26 -0000 Hi Hemant, On Fri, Jan 19, 2018 at 07:45:30PM +0530, Hemant Agrawal wrote: > Hi Jia, > > On 1/17/2018 9:33 AM, Jia He wrote: > > Move the common part of rte_ring.h into rte_ring_generic.h. > > Move the memory barrier part into update_tail(). > > > > No functional changes here. > > > > Signed-off-by: Jia He <jia.he@hxt-semitech.com> > > Suggested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Suggested-by: Ananyev Konstantin <konstantin.ananyev@intel.com> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > > Acked-by: Olivier Matz <olivier.matz@6wind.com> > > --- > > diff --git a/lib/librte_ring/rte_ring_generic.h b/lib/librte_ring/rte_ring_generic.h > > new file mode 100644 > > index 0000000..01f2cae > > --- /dev/null > > +++ b/lib/librte_ring/rte_ring_generic.h > > @@ -0,0 +1,202 @@ > > +/*- > > + * Copyright(c) 2017 Intel Corporation. All rights reserved. > > + * All rights reserved. > > + * > > + * SPDX-License-Identifier: BSD-3-Clause > > The SPDX should be first line. See other files for Intel or NXP. > > > + */ > > + > > +/* > > + * Derived from FreeBSD's bufring.h > > + * > > + ************************************************************************** > > + * > > + * Copyright (c) 2007-2009 Kip Macy kmacy@freebsd.org > > + * All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions are met: > > + * > > + * 1. Redistributions of source code must retain the above copyright notice, > > + * this list of conditions and the following disclaimer. > > + * > > + * 2. The name of Kip Macy nor the names of other > > + * contributors may be used to endorse or promote products derived from > > + * this software without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" > > + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE > > + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > > + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > > + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > > + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > > + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > > + * POSSIBILITY OF SUCH DAMAGE. > > + * > > + ***************************************************************************/ > > + > > This is BSD-2-freebsd, which is not a approved license for DPDK. > Can you ask Kip Macy, if he/she is ok to re-license it with BSD-3? > > Please check with legal, if you can just keep the copyright of Kip Macy and > re license it with BSD-3. > > I see the BSD-3 license to be permissive enough to be re-licensed as BSD-3. > But I am not a lawyer. > I agree this is something we should do, as a maintainer of librte_ring, I can do it. But here, Jia is just moving code in a new file. I don't think this should block his patchset from beeing included.