From: Bruce Richardson <bruce.richardson@intel.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM cross builds
Date: Fri, 19 Jan 2018 16:41:26 +0000 [thread overview]
Message-ID: <20180119164126.GC16980@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20180119131508.7768-1-pbhagavatula@caviumnetworks.com>
On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote:
> Add various vendor specific cross build targets.
> This can be verified by using linaro toolchain and running
>
> meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
>
"arch64-armv8"? I thought we were standardizing on "arm64" as the naming
here, or alternatively I think it should be "aarch64", right?
In terms of file naming, do we want to have a file extension on these
files. I wondering if we want to change "_cross" to ".cross" for
instance. The basic example in the meson docs uses a .txt extension but
that looks weird to me. No strong opinion on my end, just looking for
any other ideas.
> In future more cross build targets can be added.
Yes, good idea. Is config/<arch> the best place to hold these, or should
we have a separate cross-build folder? I quite like having them in
config like you have done, but wondering if anyone disagrees?
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
> config/arm/arch64_armv8_generic_cross | 10 +++++++
> config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
> config/arm/meson.build | 52 +++++++++++++++++++---------------
> 3 files changed, 52 insertions(+), 23 deletions(-)
> create mode 100644 config/arm/arch64_armv8_generic_cross
> create mode 100644 config/arm/arch64_armv8_thunderx_cross
>
Adding Thomas on CC as he always has opinions on file locations and
naming.
/Bruce
next prev parent reply other threads:[~2018-01-19 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 13:15 Pavan Nikhilesh
2018-01-19 16:41 ` Bruce Richardson [this message]
2018-01-19 17:26 ` Pavan Nikhilesh
2018-01-19 17:35 ` Bruce Richardson
2018-01-22 12:38 ` Jerin Jacob
2018-01-22 13:14 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
2018-01-22 13:40 ` Jerin Jacob
2018-01-22 14:49 ` Pavan Nikhilesh
2018-01-22 14:12 ` Bruce Richardson
2018-01-22 14:26 ` Pavan Nikhilesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119164126.GC16980@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).